Simplify exchange in critical section

kiri11 · kiri11 · commit e1f1f4ad387a · 2026-05-18T18:33:04.000-07:00
diff --git a/Modules/_ssl.c b/Modules/_ssl.c
@@ -5316,9 +5316,7 @@ _ssl__SSLContext_sni_callback_set_impl(PySSLContext *self, PyObject *value)
         }
     }
     else {
-        Py_INCREF(value);
-        PyObject *old_cb = _Py_atomic_exchange_ptr(&self->set_sni_cb, value);
-        Py_XDECREF(old_cb);
+        Py_XSETREF(self->set_sni_cb, Py_NewRef(value));
         SSL_CTX_set_tlsext_servername_arg(self->ctx, self);
         SSL_CTX_set_tlsext_servername_callback(self->ctx, _servername_callback);
     }

Original file line number	Diff line number	Diff line change
`@@ -5316,9 +5316,7 @@ _ssl__SSLContext_sni_callback_set_impl(PySSLContext self, PyObject value)`
`5316`	`5316`	`}`
`5317`	`5317`	`}`
`5318`	`5318`	`else {`
`5319`		`- Py_INCREF(value);`
`5320`		`- PyObject *old_cb = _Py_atomic_exchange_ptr(&self->set_sni_cb, value);`
`5321`		`- Py_XDECREF(old_cb);`
	`5319`	`+ Py_XSETREF(self->set_sni_cb, Py_NewRef(value));`
`5322`	`5320`	`SSL_CTX_set_tlsext_servername_arg(self->ctx, self);`
`5323`	`5321`	`SSL_CTX_set_tlsext_servername_callback(self->ctx, _servername_callback);`
`5324`	`5322`	`}`