Skip to content

Commit eba449a

Browse files
authored
GH-142234: Allow --enable-wasm-dynamic-linking under WASI (GH-142235)
While CPython doesn't support `--enable-wasm-dynamic-linking`, external tools like componentize-py do and they have to patch around it. Since the flag is off by default, allowing the flag so external users can add/inject dynamic linking support seems acceptable.
1 parent d49e6f3 commit eba449a

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Allow ``--enable-wasm-dynamic-linking`` for WASI. While CPython doesn't
2+
directly support it so external/downstream users do not have to patch in
3+
support for the flag.

configure

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

configure.ac

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1323,11 +1323,11 @@ dnl See https://emscripten.org/docs/compiling/Dynamic-Linking.html
13231323
AC_MSG_CHECKING([for --enable-wasm-dynamic-linking])
13241324
AC_ARG_ENABLE([wasm-dynamic-linking],
13251325
[AS_HELP_STRING([--enable-wasm-dynamic-linking],
1326-
[Enable dynamic linking support for WebAssembly (default is no)])],
1326+
[Enable dynamic linking support for WebAssembly (default is no); WASI requires an external dynamic loader to handle imports])],
13271327
[
13281328
AS_CASE([$ac_sys_system],
13291329
[Emscripten], [],
1330-
[WASI], [AC_MSG_ERROR([WASI dynamic linking is not implemented yet.])],
1330+
[WASI], [],
13311331
[AC_MSG_ERROR([--enable-wasm-dynamic-linking only applies to Emscripten and WASI])]
13321332
)
13331333
], [

0 commit comments

Comments
 (0)