From d2301258d2b8981b6fd75bd59d32376c0fe99b0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20H=C3=B6ffner?= Date: Sun, 18 Dec 2022 15:29:29 +0100 Subject: [PATCH 1/2] gh-73138 Add strict attribute to csv.Dialect --- Lib/csv.py | 3 ++- .../next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst diff --git a/Lib/csv.py b/Lib/csv.py index 75e35b23236795f..6d9827ecd802de2 100644 --- a/Lib/csv.py +++ b/Lib/csv.py @@ -90,7 +90,7 @@ class Dialect: This must be subclassed (see csv.excel). Valid attributes are: delimiter, quotechar, escapechar, doublequote, skipinitialspace, - lineterminator, quoting. + lineterminator, quoting, strict. """ _name = "" @@ -103,6 +103,7 @@ class Dialect: skipinitialspace = None lineterminator = None quoting = None + strict = None def __init__(self): if self.__class__ != Dialect: diff --git a/Misc/NEWS.d/next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst b/Misc/NEWS.d/next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst new file mode 100644 index 000000000000000..dd86309410bb220 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst @@ -0,0 +1 @@ +Add missing :attr:`Dialect.strict` attribute to :class:`csv.Dialect`. From dcaa29e07258323343ebefe72f2ca47657515d41 Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Fri, 21 Aug 2026 13:32:40 +0100 Subject: [PATCH 2/2] Minor adjustments --- Lib/test/test_csv.py | 2 +- .../next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_csv.py b/Lib/test/test_csv.py index 73e282d1abf7177..5096861f06f8c75 100644 --- a/Lib/test/test_csv.py +++ b/Lib/test/test_csv.py @@ -754,7 +754,7 @@ class mydialect(csv.Dialect): self.assertEqual(dialect.delimiter, ';') self.assertEqual(dialect.quoting, csv.QUOTE_ALL) self.assertEqual(list(csv.reader(['a:b'], new)), [['a', 'b']]) - # "strict" is supported even if it is not set on the class. + # "strict" is supported even if it is not set on the subclass. self.assertTrue(copy.replace(dialect, strict=True).strict) with self.assertRaises(csv.Error): diff --git a/Misc/NEWS.d/next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst b/Misc/NEWS.d/next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst index dd86309410bb220..2e8f8839cf715f2 100644 --- a/Misc/NEWS.d/next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst +++ b/Misc/NEWS.d/next/Library/2022-12-18-21-24-48.gh-issue-73138.9TOxub.rst @@ -1 +1 @@ -Add missing :attr:`Dialect.strict` attribute to :class:`csv.Dialect`. +Add the :attr:`~csv.Dialect.strict` attribute to :class:`csv.Dialect`.