From 424f73732e29c988b9921639a60ccac4be168088 Mon Sep 17 00:00:00 2001 From: Irit Katriel Date: Thu, 27 Aug 2026 22:13:20 +0100 Subject: [PATCH] gh-156466: fix cleanup on error in codegen_leave_annotations_scope --- Python/codegen.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Python/codegen.c b/Python/codegen.c index df52f2c734e69a..6fb83ced307335 100644 --- a/Python/codegen.c +++ b/Python/codegen.c @@ -775,10 +775,11 @@ codegen_rename_annotations_format_param(PyCodeObject *co) } static int -codegen_leave_annotations_scope(compiler *c, location loc) +codegen_finish_annotations_scope(compiler *c, location loc) { ADDOP_IN_SCOPE(c, loc, RETURN_VALUE); PyCodeObject *co = _PyCompile_OptimizeAndAssemble(c, 1); + _PyCompile_ExitScope(c); if (co == NULL) { return ERROR; } @@ -788,7 +789,6 @@ codegen_leave_annotations_scope(compiler *c, location loc) return ERROR; } - _PyCompile_ExitScope(c); int ret = codegen_make_closure(c, loc, co, 0); Py_DECREF(co); RETURN_IF_ERROR(ret); @@ -891,7 +891,7 @@ codegen_process_deferred_annotations(compiler *c, location loc) Py_DECREF(deferred_anno); Py_DECREF(conditional_annotation_indices); - RETURN_IF_ERROR(codegen_leave_annotations_scope(c, loc)); + RETURN_IF_ERROR(codegen_finish_annotations_scope(c, loc)); RETURN_IF_ERROR(codegen_nameop( c, loc, ste->ste_type == ClassBlock ? &_Py_ID(__annotate_func__) : &_Py_ID(__annotate__), @@ -1197,7 +1197,7 @@ codegen_function_annotations(compiler *c, location loc, c, codegen_annotations_in_scope(c, loc, args, returns, &annotations_len) ); ADDOP_I(c, loc, BUILD_MAP, annotations_len); - RETURN_IF_ERROR(codegen_leave_annotations_scope(c, loc)); + RETURN_IF_ERROR(codegen_finish_annotations_scope(c, loc)); return MAKE_FUNCTION_ANNOTATE; } else {