Skip to content

Commit 9dd56fd

Browse files
author
Daniel Sperber
committed
refinement
1 parent f3c8644 commit 9dd56fd

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

peps/pep-0821.rst

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ callback protocol whose ``__call__`` method is defined as
138138
``def __call__(self, **kwargs: Unpack[TD]) -> R: ...``.
139139
All rules — handling of required and optional keys, ``extra_items``,
140140
``closed``, assignment compatibility — follow from this equivalence per
141-
:pep:`692`, :pep:`728`, and other existing typing specifications related to
141+
:pep:`692`, :pep:`728`, and other existing typing specifications related to
142142
``Protocol`` and ``**kwargs`` unpacking through ``TypedDict``.
143143
When positional parameters precede ``Unpack[TD]``, as in
144144
``Callable[[int, str, Unpack[TD]], R]``, the same equivalence applies with
@@ -266,7 +266,7 @@ Rejected Ideas
266266
class TD1(TypedDict):
267267
a: int
268268
b: int
269-
269+
270270
class TD2(TypedDict):
271271
b: str
272272

@@ -308,8 +308,7 @@ Open Questions
308308
:pep:`692` did not address generic ``TypedDict`` in ``**kwargs``, and
309309
the rules remain an open ambiguity in the typing spec. If the equivalence
310310
principle applies, the rules should follow from the callback protocol
311-
equivalent — but it is unclear whether type checkers can currently reason
312-
about this correctly.
311+
equivalent.
313312

314313

315314
Acknowledgements
@@ -318,9 +317,9 @@ Acknowledgements
318317
Thanks to Jelle Zijlstra for sponsoring this PEP and his valuable review
319318
feedback.
320319

321-
Hugo van Kemenade, for helpful feedback on the draft and PR of this PEP.
320+
Eric Traut, for careful review, detailed feedback, and valuable input.
322321

323-
Eric Traut, for feedback on the initial idea and discussions.
322+
Hugo van Kemenade, for helpful feedback on the draft and PR of this PEP.
324323

325324

326325
References

0 commit comments

Comments
 (0)