Skip to content

Cleanup of old/broken Saved Scenario Reports feature #4669

@aaccensi

Description

@aaccensi

Context

During the removal of Energy Mix infographic and adding the deprecation notice to the Scenario Report feature, some queries were found that looked only related tot he Energy Mix yet under a completely different feature.

That feature that generated a CSV export for a saved scenario when those were still in etmodel. It is broken, likely since saved scenarios were moved to my-etm.

Proposed enhancement

Since there are no complains about this feature and it has been broken a very long time it is safe to remove, for which the following actions have been estimated:

To delete the following files:

File Notes
app/controllers/saved_scenario_reports_controller.rb The broken controller
app/views/saved_scenario_reports/show.csv.erb CSV view template
app/services/fetch_api_scenario_queries.rb Only used by this controller
spec/services/fetch_api_scenario_queries_spec.rb Spec for the above service
config/saved_scenario_reports/ovm.yml The only report config (delete dir too)

To remove the following line from the routes: config/routes.rb:55

Remove get '/report/:report_name' => 'saved_scenario_reports#show'

Success criteria

Remove any trace of this old feature without disrupting anything else.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions