Commit ebe918d
committed
Fix SO2/SE2.interp1(), which raised NameError for every input
The fix for #33 dropped the `start` local from interp1() but only replaced its
two uses in the N == 3 branch, so the SO(2)/SE(2) branch has referenced an
undefined name ever since:
SE2(1, 2, 0.3).interp1(0.5) # NameError: name 'start' is not defined
#33 did report it for both SE2 and SE3. Pass None like the N == 3 branch does;
trinterp2() already treats a None start as the identity. interp1() had no test
coverage for either dimension, hence the four years.1 parent 2f20bf7 commit ebe918d
2 files changed
Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
512 | 512 | | |
513 | 513 | | |
514 | 514 | | |
515 | | - | |
| 515 | + | |
516 | 516 | | |
517 | 517 | | |
518 | | - | |
| 518 | + | |
519 | 519 | | |
520 | 520 | | |
521 | 521 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
466 | 466 | | |
467 | 467 | | |
468 | 468 | | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
469 | 486 | | |
470 | 487 | | |
471 | 488 | | |
| |||
0 commit comments