From 314280ad83c90e0eb6a3aa7c0b1e3df9f5cf138c Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Wed, 29 Apr 2026 18:06:28 +0530 Subject: [PATCH 01/13] Update rrdRunCmdThread.c --- src/rrdRunCmdThread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index ce873d5d..b719aa36 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -357,7 +357,7 @@ bool executeCommands(issueData *cmdinfo) strncat(finalOutFile,RRD_OUTPUT_FILE, strlen(RRD_OUTPUT_FILE) + 1); /* Open debug_output.txt file*/ - filePointer = fopen(finalOutFile, "a+"); + filePointer = fopen(finalOutFile, "w+"); if (filePointer == NULL) { RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Unable to Open File:%s\n",__FUNCTION__,__LINE__,finalOutFile); From d80af784716cf256e191467658eee067cff63f5a Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Sat, 2 May 2026 09:47:03 +0530 Subject: [PATCH 02/13] Update rrdRunCmdThread.c --- src/rrdRunCmdThread.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index b719aa36..65b37027 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -377,9 +377,10 @@ bool executeCommands(issueData *cmdinfo) /*Executing Commands using systemd-run*/ RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Executing following commands using systemd-run:\n \"%s\"\n",__FUNCTION__,__LINE__,cmdData->command); - strncpy(remoteDebuggerServiceStr, remoteDebuggerPrefix, sizeof(remoteDebuggerServiceStr) - 1); - remoteDebuggerServiceStr[sizeof(remoteDebuggerServiceStr) - 1] = '\0'; - strncat(remoteDebuggerServiceStr, cmdData->rfcvalue, sizeof(remoteDebuggerServiceStr) - strlen(remoteDebuggerServiceStr) - 1); + snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname) + //strncpy(remoteDebuggerServiceStr, remoteDebuggerPrefix, sizeof(remoteDebuggerServiceStr) - 1); + //remoteDebuggerServiceStr[sizeof(remoteDebuggerServiceStr) - 1] = '\0'; + //strncat(remoteDebuggerServiceStr, cmdData->rfcvalue, sizeof(remoteDebuggerServiceStr) - strlen(remoteDebuggerServiceStr) - 1); removeQuotes(cmdData->command); From 39b2e5c26466f9aa89d9fda2bacee809c8c24209 Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Sat, 2 May 2026 11:55:48 +0530 Subject: [PATCH 03/13] Update rrdRunCmdThread.c --- src/rrdRunCmdThread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index 65b37027..5e9bb083 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -377,7 +377,7 @@ bool executeCommands(issueData *cmdinfo) /*Executing Commands using systemd-run*/ RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Executing following commands using systemd-run:\n \"%s\"\n",__FUNCTION__,__LINE__,cmdData->command); - snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname) + snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname); //strncpy(remoteDebuggerServiceStr, remoteDebuggerPrefix, sizeof(remoteDebuggerServiceStr) - 1); //remoteDebuggerServiceStr[sizeof(remoteDebuggerServiceStr) - 1] = '\0'; //strncat(remoteDebuggerServiceStr, cmdData->rfcvalue, sizeof(remoteDebuggerServiceStr) - strlen(remoteDebuggerServiceStr) - 1); From 02ad766715f97d7b1a512b1fe581bfd016b68894 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 2 May 2026 07:11:32 +0000 Subject: [PATCH 04/13] Fix format-truncation: increase remoteDebuggerServiceStr buffer to BUF_LEN_512 Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/f3e6d001-a244-4693-b073-fad00bcf7bf7 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> --- .gitignore | 36 +++++++++++++++++++++++++++ src/rrdRunCmdThread.c | 5 +--- src/rrdRunCmdThread.h | 1 + src/unittest/UTJson/device.properties | 0 4 files changed, 38 insertions(+), 4 deletions(-) create mode 100644 .gitignore create mode 100644 src/unittest/UTJson/device.properties diff --git a/.gitignore b/.gitignore new file mode 100644 index 00000000..0f238cfe --- /dev/null +++ b/.gitignore @@ -0,0 +1,36 @@ +# Build artifacts +*.o +*.gcda +*.gcno +*.gcov +*.a +*.so +*.lo +*.la + +# Autotools build artifacts +src/unittest/Makefile +src/unittest/Makefile.in +src/unittest/aclocal.m4 +src/unittest/autom4te.cache/ +src/unittest/compile +src/unittest/config.guess +src/unittest/config.log +src/unittest/config.status +src/unittest/config.sub +src/unittest/configure +src/unittest/depcomp +src/unittest/install-sh +src/unittest/missing +src/unittest/COPYING +src/unittest/INSTALL +src/unittest/.deps/ + +# Test output directories +src/unittest/dummy_*/ + +# Test binaries +src/unittest/remotedebugger_gtest + +# Dependency tracking +**/.deps/ diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index 5e9bb083..d6160d20 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -287,7 +287,7 @@ bool executeCommands(issueData *cmdinfo) char pathname[BUF_LEN_256] = {'\0'}; char *outdirpath = NULL; char finalOutFile[BUF_LEN_256] = {'\0'}; - char remoteDebuggerServiceStr[BUF_LEN_256] = {'\0'}; + char remoteDebuggerServiceStr[BUF_LEN_512] = {'\0'}; char *printbuffer = NULL; FILE *filePointer; const char *remoteDebuggerPrefix = "remote_debugger_"; @@ -378,9 +378,6 @@ bool executeCommands(issueData *cmdinfo) RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Executing following commands using systemd-run:\n \"%s\"\n",__FUNCTION__,__LINE__,cmdData->command); snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname); - //strncpy(remoteDebuggerServiceStr, remoteDebuggerPrefix, sizeof(remoteDebuggerServiceStr) - 1); - //remoteDebuggerServiceStr[sizeof(remoteDebuggerServiceStr) - 1] = '\0'; - //strncat(remoteDebuggerServiceStr, cmdData->rfcvalue, sizeof(remoteDebuggerServiceStr) - strlen(remoteDebuggerServiceStr) - 1); removeQuotes(cmdData->command); diff --git a/src/rrdRunCmdThread.h b/src/rrdRunCmdThread.h index a1bd9816..fb92fb08 100644 --- a/src/rrdRunCmdThread.h +++ b/src/rrdRunCmdThread.h @@ -48,6 +48,7 @@ extern "C" #endif #define RRD_OUTPUT_FILE "debug_outputs.txt" #define BUF_LEN_256 256 +#define BUF_LEN_512 512 /*Public Function*/ void initCache(void); diff --git a/src/unittest/UTJson/device.properties b/src/unittest/UTJson/device.properties new file mode 100644 index 00000000..e69de29b From b01379fb405e0574624b4c830121c46757f62ca3 Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Mon, 4 May 2026 22:14:19 +0530 Subject: [PATCH 05/13] Delete src/unittest/UTJson/device.properties --- src/unittest/UTJson/device.properties | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 src/unittest/UTJson/device.properties diff --git a/src/unittest/UTJson/device.properties b/src/unittest/UTJson/device.properties deleted file mode 100644 index e69de29b..00000000 From f7173993b718ceb3fba1489461318538919b7a4d Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Mon, 4 May 2026 22:14:57 +0530 Subject: [PATCH 06/13] Delete .gitignore --- .gitignore | 36 ------------------------------------ 1 file changed, 36 deletions(-) delete mode 100644 .gitignore diff --git a/.gitignore b/.gitignore deleted file mode 100644 index 0f238cfe..00000000 --- a/.gitignore +++ /dev/null @@ -1,36 +0,0 @@ -# Build artifacts -*.o -*.gcda -*.gcno -*.gcov -*.a -*.so -*.lo -*.la - -# Autotools build artifacts -src/unittest/Makefile -src/unittest/Makefile.in -src/unittest/aclocal.m4 -src/unittest/autom4te.cache/ -src/unittest/compile -src/unittest/config.guess -src/unittest/config.log -src/unittest/config.status -src/unittest/config.sub -src/unittest/configure -src/unittest/depcomp -src/unittest/install-sh -src/unittest/missing -src/unittest/COPYING -src/unittest/INSTALL -src/unittest/.deps/ - -# Test output directories -src/unittest/dummy_*/ - -# Test binaries -src/unittest/remotedebugger_gtest - -# Dependency tracking -**/.deps/ From 39991edae731ec3e47f101e60378dc0194de14c9 Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Tue, 5 May 2026 08:23:38 +0530 Subject: [PATCH 07/13] Update rrdRunCmdThread.c --- src/rrdRunCmdThread.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index d6160d20..0d28c7db 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -376,8 +376,15 @@ bool executeCommands(issueData *cmdinfo) /*Executing Commands using systemd-run*/ RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Executing following commands using systemd-run:\n \"%s\"\n",__FUNCTION__,__LINE__,cmdData->command); + time_t epochTime = time(NULL); + if (epochTime == ((time_t)-1)) + { + RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to get epoch time\n", __FUNCTION__, __LINE__); + return false; + } - snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname); + snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr),"%s%s_%ld", remoteDebuggerPrefix, cmdData->rfcvalue, (long)epochTime); + //snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname); removeQuotes(cmdData->command); From d01b8e68205cf7e75784b779c69a306d6092344c Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Tue, 5 May 2026 08:52:27 +0530 Subject: [PATCH 08/13] Update L2-tests.yml --- .github/workflows/L2-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/L2-tests.yml b/.github/workflows/L2-tests.yml index a06430a8..e4c1befa 100644 --- a/.github/workflows/L2-tests.yml +++ b/.github/workflows/L2-tests.yml @@ -54,11 +54,11 @@ jobs: - name: Start mock-xconf service run: | - docker run -d --name mockxconf -p 50050:50050 -p 50051:50051 -p 50052:50052 -p 50054:50054 -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/mockxconf:latest + docker run -d --name mockxconf -p 50050:50050 -p 50051:50051 -p 50052:50052 -p 50054:50054 -e ENABLE_MTLS=true -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/mockxconf:latest - name: Start l2-container service run: | - docker run -d --name native-platform --link mockxconf -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest + docker run -d --name native-platform --link mockxconf -e ENABLE_MTLS=true -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest - name: Move dependent repositories in native-platform container to /usr From cf98df3631321779597daa33c4318e7b6556a308 Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Tue, 5 May 2026 10:00:00 +0530 Subject: [PATCH 09/13] Update rrdRunCmdThread.c --- src/rrdRunCmdThread.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index 0d28c7db..d7e48e1f 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -391,11 +391,11 @@ bool executeCommands(issueData *cmdinfo) FILE *systemdfp = v_secure_popen("r", "systemd-run -r --unit=%s --service-type=oneshot -p RemainAfterExit=yes /bin/sh -c %s", remoteDebuggerServiceStr, cmdData->command); if(systemdfp == NULL) { - RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,cmdData->rfcvalue); + RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); } else { - RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue); + RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); copyDebugLogDestFile(systemdfp, filePointer); v_secure_pclose(systemdfp); } @@ -405,11 +405,11 @@ bool executeCommands(issueData *cmdinfo) FILE *journalctlfp = v_secure_popen("r", "journalctl -a -u %s", remoteDebuggerServiceStr); if(journalctlfp == NULL) { - RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: journalctl remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,cmdData->rfcvalue); + RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: journalctl remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); } else { - RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: journalctl remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue); + RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: journalctl remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); copyDebugLogDestFile(journalctlfp, filePointer); v_secure_pclose(journalctlfp); } @@ -422,7 +422,7 @@ bool executeCommands(issueData *cmdinfo) sleep(cmdData->timeout); /*Stop or Reset runtime service for issue*/ - RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Stopping remote_debugger_%s service...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue); + RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Stopping remote_debugger_%s service...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); #if !defined(GTEST_ENABLE) v_secure_system("systemctl stop %s", remoteDebuggerServiceStr); free(cmdData->rfcvalue); // free rfcvalue received from RRDEventThreadFunc From 21333060d439d8f41afc5c72440df85278d7ee81 Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Tue, 5 May 2026 10:07:16 +0530 Subject: [PATCH 10/13] Update rrdRunCmdThread.c --- src/rrdRunCmdThread.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index d7e48e1f..c1daa25f 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -391,11 +391,11 @@ bool executeCommands(issueData *cmdinfo) FILE *systemdfp = v_secure_popen("r", "systemd-run -r --unit=%s --service-type=oneshot -p RemainAfterExit=yes /bin/sh -c %s", remoteDebuggerServiceStr, cmdData->command); if(systemdfp == NULL) { - RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); + RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting %s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); } else { - RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); + RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Starting %s service success...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); copyDebugLogDestFile(systemdfp, filePointer); v_secure_pclose(systemdfp); } @@ -405,7 +405,7 @@ bool executeCommands(issueData *cmdinfo) FILE *journalctlfp = v_secure_popen("r", "journalctl -a -u %s", remoteDebuggerServiceStr); if(journalctlfp == NULL) { - RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: journalctl remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); + RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: journalctl %s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); } else { @@ -422,7 +422,7 @@ bool executeCommands(issueData *cmdinfo) sleep(cmdData->timeout); /*Stop or Reset runtime service for issue*/ - RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Stopping remote_debugger_%s service...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); + RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Stopping %s service...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr); #if !defined(GTEST_ENABLE) v_secure_system("systemctl stop %s", remoteDebuggerServiceStr); free(cmdData->rfcvalue); // free rfcvalue received from RRDEventThreadFunc From be60956f32a92f55972447a65880dea64f46cd8a Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Tue, 5 May 2026 17:34:15 +0530 Subject: [PATCH 11/13] Update L2-tests.yml --- .github/workflows/L2-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/L2-tests.yml b/.github/workflows/L2-tests.yml index e4c1befa..a06430a8 100644 --- a/.github/workflows/L2-tests.yml +++ b/.github/workflows/L2-tests.yml @@ -54,11 +54,11 @@ jobs: - name: Start mock-xconf service run: | - docker run -d --name mockxconf -p 50050:50050 -p 50051:50051 -p 50052:50052 -p 50054:50054 -e ENABLE_MTLS=true -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/mockxconf:latest + docker run -d --name mockxconf -p 50050:50050 -p 50051:50051 -p 50052:50052 -p 50054:50054 -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/mockxconf:latest - name: Start l2-container service run: | - docker run -d --name native-platform --link mockxconf -e ENABLE_MTLS=true -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest + docker run -d --name native-platform --link mockxconf -v ${{ github.workspace }}:/mnt/L2_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest - name: Move dependent repositories in native-platform container to /usr From a2844ad4db2f78bc84a61b71fe9948df5fe85baf Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Tue, 5 May 2026 18:25:52 +0530 Subject: [PATCH 12/13] Update rrdRunCmdThread.c --- src/rrdRunCmdThread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index c1daa25f..52b35d2b 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -383,7 +383,7 @@ bool executeCommands(issueData *cmdinfo) return false; } - snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr),"%s%s_%ld", remoteDebuggerPrefix, cmdData->rfcvalue, (long)epochTime); + snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr),"%s%s%ld", remoteDebuggerPrefix, cmdData->rfcvalue, (long)epochTime); //snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname); removeQuotes(cmdData->command); From ff5fda36537c7c78d8bd46b00a04f71765cc2c34 Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Tue, 5 May 2026 18:26:55 +0530 Subject: [PATCH 13/13] Remove error handling for epoch time retrieval --- src/rrdRunCmdThread.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index 52b35d2b..27b97e0d 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -380,7 +380,6 @@ bool executeCommands(issueData *cmdinfo) if (epochTime == ((time_t)-1)) { RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to get epoch time\n", __FUNCTION__, __LINE__); - return false; } snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr),"%s%s%ld", remoteDebuggerPrefix, cmdData->rfcvalue, (long)epochTime);