Seal renderer Graphics public boundary

Summary:
Keep the CSS-free color parsing helpers (`parsePlatformColorFn`, `fromRawValueShared`, and `parsePlatformColor`) in the public Graphics API so the platform `fromRawValue` wrappers remain inline. Move `hashGetColourArguments` and `configurePlatformColorCacheInvalidationHook` into private implementation scope, and remove unsupported dormant parser headers from the React Native macOS mirror.

Stop exporting CSS, fbjni, and the Android cache library from the Buck target, and express implementation-only dependencies privately in Buck and CMake. The retained shared helper header depends only on `RawValue`, `Color`, and `ContextContainer`; CSS parsing headers remain confined to the implementation file.

Regenerate C++ API snapshots to remove the private hash and cache declarations while retaining the public color parser helpers and inline `fromRawValue` entry point.

Changelog: [Internal]

Differential Revision: D119500886

Author: coado

packages/react-native/ReactCommon/react/renderer/graphics/CMakeLists.txt

@@ -27,14 +27,17 @@ target_include_directories(react_renderer_graphics INTERFACE ${REACT_COMMON_DIR}
 
 react_native_android_selector(fbjni fbjni "")
 target_link_libraries(react_renderer_graphics
-        glog
-        ${fbjni}
-        folly_runtime
-        react_cxxstableapi
-        react_debug
-        react_renderer_css
-        react_renderer_debug
-        react_utils
+        PUBLIC
+          ${fbjni}
+          folly_runtime
+          react_cxxstableapi
+          react_renderer_debug
+          react_utils
+        PRIVATE
+          glog
+          react_debug
+          react_featureflags
+          react_renderer_css
 )
 target_compile_reactnative_options(react_renderer_graphics PRIVATE)
 target_compile_options(react_renderer_graphics PRIVATE -Wpedantic)

packages/react-native/ReactCommon/react/renderer/graphics/React/Graphics.h

@@ -55,10 +55,6 @@
 #include <react/renderer/graphics/fromRawValueShared.h>
 #include <react/renderer/graphics/rounding.h>
 
-#ifdef ANDROID
-#include <react/renderer/graphics/configurePlatformColorCacheInvalidationHook.h>
-#endif
-
 #if defined(__APPLE__) && defined(__OBJC__)
 #include <react/renderer/graphics/RCTPlatformColorUtils.h>
 #endif

packages/react-native/ReactCommon/react/renderer/graphics/platform/android/react/renderer/graphics/PlatformColorParser.cpp

@@ -7,8 +7,7 @@
 
 #include <react/renderer/graphics/PlatformColorParser.h>
 
-#include "configurePlatformColorCacheInvalidationHook.h"
-
+#include <fbjni/NativeRunnable.h>
 #include <fbjni/fbjni.h>
 #include <folly/container/EvictingCacheMap.h>
 #include <react/renderer/css/CSSColor.h>
@@ -20,6 +19,22 @@
 
 namespace facebook::react {
 
+namespace {
+
+void configurePlatformColorCacheInvalidationHook(std::function<void()>&& hook) {
+  auto appearanceModuleClass = jni::findClassLocal(
+      "com/facebook/react/modules/appearance/AppearanceModule");
+  if (appearanceModuleClass) {
+    auto callbackField =
+        appearanceModuleClass->getStaticField<jni::JRunnable::javaobject>(
+            "invalidatePlatformColorCache");
+    jni::local_ref<jni::JRunnable> invalidationCallback =
+        jni::JNativeRunnable::newObjectCxxArgs(std::move(hook));
+    appearanceModuleClass->setStaticFieldValue(
+        callbackField, invalidationCallback.get());
+  }
+}
+
 size_t hashGetColourArguments(
     int32_t surfaceId,
     const std::vector<std::string>& resourcePaths) {
@@ -31,6 +46,8 @@ size_t hashGetColourArguments(
   return seed;
 }
 
+} // namespace
+
 SharedColor parsePlatformColor(
     const ContextContainer& contextContainer,
     int32_t surfaceId,

packages/react-native/ReactCommon/react/renderer/graphics/platform/android/react/renderer/graphics/PlatformColorParser.h

@@ -12,14 +12,9 @@
 #include <react/renderer/graphics/Color.h>
 #include <react/renderer/graphics/fromRawValueShared.h>
 #include <react/utils/ContextContainer.h>
-#include <cstddef>
-#include <string>
-#include <vector>
 
 namespace facebook::react {
 
-size_t hashGetColourArguments(int32_t surfaceId, const std::vector<std::string> &resourcePaths);
-
 SharedColor parsePlatformColor(const ContextContainer &contextContainer, int32_t surfaceId, const RawValue &value);
 
 inline void

packages/react-native/ReactCommon/react/renderer/graphics/platform/android/react/renderer/graphics/configurePlatformColorCacheInvalidationHook.cpp

@@ -943,7 +943,6 @@ size_t facebook::react::attributedStringFragmentHashDisplayWise(const facebook::
 size_t facebook::react::attributedStringFragmentHashLayoutWise(const facebook::react::AttributedString::Fragment& fragment);
 size_t facebook::react::attributedStringHashDisplayWise(const facebook::react::AttributedString& attributedString);
 size_t facebook::react::attributedStringHashLayoutWise(const facebook::react::AttributedString& attributedString);
-size_t facebook::react::hashGetColourArguments(int32_t surfaceId, const std::vector<std::string>& resourcePaths);
 size_t facebook::react::textAttributesHashLayoutWise(const facebook::react::TextAttributes& textAttributes);
 std::function<void(folly::dynamic)> facebook::react::makeCallback(std::weak_ptr<facebook::react::Instance> instance, const folly::dynamic& callbackId);
 std::optional<facebook::react::BlendMode> facebook::react::blendModeFromString(std::string_view blendModeName);
@@ -1073,7 +1072,6 @@ void facebook::react::bindHasComponentProvider(facebook::jsi::Runtime& runtime,
 void facebook::react::bindNativeLogger(facebook::jsi::Runtime& runtime, facebook::react::Logger logger);
 void facebook::react::bindNativePerformanceNow(facebook::jsi::Runtime& runtime);
 void facebook::react::cloneProp(facebook::react::BaseViewProps& viewProps, const facebook::react::AnimatedPropBase& animatedProp);
-void facebook::react::configurePlatformColorCacheInvalidationHook(std::function<void()>&& hook);
 void facebook::react::defineReadOnlyGlobal(facebook::jsi::Runtime& runtime, const std::string& propName, facebook::jsi::Value&& value);
 void facebook::react::ensureThreadDurationJNIEnvAttached();
 void facebook::react::fromRawValue(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value, facebook::react::SharedColor& result);

packages/react-native/ReactCommon/react/renderer/graphics/platform/android/react/renderer/graphics/configurePlatformColorCacheInvalidationHook.h

@@ -942,7 +942,6 @@ size_t facebook::react::attributedStringFragmentHashDisplayWise(const facebook::
 size_t facebook::react::attributedStringFragmentHashLayoutWise(const facebook::react::AttributedString::Fragment& fragment);
 size_t facebook::react::attributedStringHashDisplayWise(const facebook::react::AttributedString& attributedString);
 size_t facebook::react::attributedStringHashLayoutWise(const facebook::react::AttributedString& attributedString);
-size_t facebook::react::hashGetColourArguments(int32_t surfaceId, const std::vector<std::string>& resourcePaths);
 size_t facebook::react::textAttributesHashLayoutWise(const facebook::react::TextAttributes& textAttributes);
 std::optional<facebook::react::BlendMode> facebook::react::blendModeFromString(std::string_view blendModeName);
 std::optional<facebook::react::BoxShadow> facebook::react::fromCSSShadow(const facebook::react::CSSShadow& cssShadow);
@@ -1069,7 +1068,6 @@ void facebook::react::bindHasComponentProvider(facebook::jsi::Runtime& runtime,
 void facebook::react::bindNativeLogger(facebook::jsi::Runtime& runtime, facebook::react::Logger logger);
 void facebook::react::bindNativePerformanceNow(facebook::jsi::Runtime& runtime);
 void facebook::react::cloneProp(facebook::react::BaseViewProps& viewProps, const facebook::react::AnimatedPropBase& animatedProp);
-void facebook::react::configurePlatformColorCacheInvalidationHook(std::function<void()>&& hook);
 void facebook::react::defineReadOnlyGlobal(facebook::jsi::Runtime& runtime, const std::string& propName, facebook::jsi::Value&& value);
 void facebook::react::ensureThreadDurationJNIEnvAttached();
 void facebook::react::fromRawValue(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value, facebook::react::SharedColor& result);

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

@@ -943,7 +943,6 @@ size_t facebook::react::attributedStringFragmentHashDisplayWise(const facebook::
 size_t facebook::react::attributedStringFragmentHashLayoutWise(const facebook::react::AttributedString::Fragment& fragment);
 size_t facebook::react::attributedStringHashDisplayWise(const facebook::react::AttributedString& attributedString);
 size_t facebook::react::attributedStringHashLayoutWise(const facebook::react::AttributedString& attributedString);
-size_t facebook::react::hashGetColourArguments(int32_t surfaceId, const std::vector<std::string>& resourcePaths);
 size_t facebook::react::textAttributesHashLayoutWise(const facebook::react::TextAttributes& textAttributes);
 std::function<void(folly::dynamic)> facebook::react::makeCallback(std::weak_ptr<facebook::react::Instance> instance, const folly::dynamic& callbackId);
 std::optional<facebook::react::BlendMode> facebook::react::blendModeFromString(std::string_view blendModeName);
@@ -1073,7 +1072,6 @@ void facebook::react::bindHasComponentProvider(facebook::jsi::Runtime& runtime,
 void facebook::react::bindNativeLogger(facebook::jsi::Runtime& runtime, facebook::react::Logger logger);
 void facebook::react::bindNativePerformanceNow(facebook::jsi::Runtime& runtime);
 void facebook::react::cloneProp(facebook::react::BaseViewProps& viewProps, const facebook::react::AnimatedPropBase& animatedProp);
-void facebook::react::configurePlatformColorCacheInvalidationHook(std::function<void()>&& hook);
 void facebook::react::defineReadOnlyGlobal(facebook::jsi::Runtime& runtime, const std::string& propName, facebook::jsi::Value&& value);
 void facebook::react::ensureThreadDurationJNIEnvAttached();
 void facebook::react::fromRawValue(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value, facebook::react::SharedColor& result);