Skip to content

Commit 4eb7885

Browse files
sammy-SCmeta-codesync[bot]
authored andcommitted
Remove dead StartupLogger::getInitReactRuntimeEndTime getter
Summary: X-link: #57140 `StartupLogger::getInitReactRuntimeEndTime()` was a public getter returning the `initReactRuntimeEndTime` member, but it had no callers. `NativePerformance` (the only consumer of `StartupLogger`) never reads it. This removes the dead getter; the backing member `initReactRuntimeEndTime` is kept because `logStartupEvent`/`reset` still write it. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D108012904 fbshipit-source-id: 56a6710c485a926caf82ecb1cc08e845571b2dd8
1 parent de57be5 commit 4eb7885

11 files changed

Lines changed: 0 additions & 14 deletions

packages/react-native/ReactCommon/cxxreact/ReactMarker.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,6 @@ double StartupLogger::getInitReactRuntimeStartTime() {
102102
return initReactRuntimeStartTime;
103103
}
104104

105-
double StartupLogger::getInitReactRuntimeEndTime() {
106-
return initReactRuntimeEndTime;
107-
}
108-
109105
double StartupLogger::getRunJSBundleStartTime() {
110106
return runJSBundleStartTime;
111107
}

packages/react-native/ReactCommon/cxxreact/ReactMarker.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ class RN_EXPORT StartupLogger {
9393
void reset();
9494
double getAppStartupStartTime();
9595
double getInitReactRuntimeStartTime();
96-
double getInitReactRuntimeEndTime();
9796
double getRunJSBundleStartTime();
9897
double getAppStartupEndTime();
9998

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11714,7 +11714,6 @@ facebook::react::ReactMarker::AtomicLogTaggedMarker facebook::react::ReactMarker
1171411714
class facebook::react::ReactMarker::StartupLogger {
1171511715
public double getAppStartupEndTime();
1171611716
public double getAppStartupStartTime();
11717-
public double getInitReactRuntimeEndTime();
1171811717
public double getInitReactRuntimeStartTime();
1171911718
public double getRunJSBundleStartTime();
1172011719
public static facebook::react::ReactMarker::StartupLogger& getInstance();

scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11340,7 +11340,6 @@ facebook::react::ReactMarker::AtomicLogTaggedMarker facebook::react::ReactMarker
1134011340
class facebook::react::ReactMarker::StartupLogger {
1134111341
public double getAppStartupEndTime();
1134211342
public double getAppStartupStartTime();
11343-
public double getInitReactRuntimeEndTime();
1134411343
public double getInitReactRuntimeStartTime();
1134511344
public double getRunJSBundleStartTime();
1134611345
public static facebook::react::ReactMarker::StartupLogger& getInstance();

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11567,7 +11567,6 @@ facebook::react::ReactMarker::AtomicLogTaggedMarker facebook::react::ReactMarker
1156711567
class facebook::react::ReactMarker::StartupLogger {
1156811568
public double getAppStartupEndTime();
1156911569
public double getAppStartupStartTime();
11570-
public double getInitReactRuntimeEndTime();
1157111570
public double getInitReactRuntimeStartTime();
1157211571
public double getRunJSBundleStartTime();
1157311572
public static facebook::react::ReactMarker::StartupLogger& getInstance();

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13545,7 +13545,6 @@ facebook::react::ReactMarker::AtomicLogTaggedMarker facebook::react::ReactMarker
1354513545
class facebook::react::ReactMarker::StartupLogger {
1354613546
public double getAppStartupEndTime();
1354713547
public double getAppStartupStartTime();
13548-
public double getInitReactRuntimeEndTime();
1354913548
public double getInitReactRuntimeStartTime();
1355013549
public double getRunJSBundleStartTime();
1355113550
public static facebook::react::ReactMarker::StartupLogger& getInstance();

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13233,7 +13233,6 @@ facebook::react::ReactMarker::AtomicLogTaggedMarker facebook::react::ReactMarker
1323313233
class facebook::react::ReactMarker::StartupLogger {
1323413234
public double getAppStartupEndTime();
1323513235
public double getAppStartupStartTime();
13236-
public double getInitReactRuntimeEndTime();
1323713236
public double getInitReactRuntimeStartTime();
1323813237
public double getRunJSBundleStartTime();
1323913238
public static facebook::react::ReactMarker::StartupLogger& getInstance();

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13408,7 +13408,6 @@ facebook::react::ReactMarker::AtomicLogTaggedMarker facebook::react::ReactMarker
1340813408
class facebook::react::ReactMarker::StartupLogger {
1340913409
public double getAppStartupEndTime();
1341013410
public double getAppStartupStartTime();
13411-
public double getInitReactRuntimeEndTime();
1341213411
public double getInitReactRuntimeStartTime();
1341313412
public double getRunJSBundleStartTime();
1341413413
public static facebook::react::ReactMarker::StartupLogger& getInstance();

scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8699,7 +8699,6 @@ facebook::react::ReactMarker::AtomicLogTaggedMarker facebook::react::ReactMarker
86998699
class facebook::react::ReactMarker::StartupLogger {
87008700
public double getAppStartupEndTime();
87018701
public double getAppStartupStartTime();
8702-
public double getInitReactRuntimeEndTime();
87038702
public double getInitReactRuntimeStartTime();
87048703
public double getRunJSBundleStartTime();
87058704
public static facebook::react::ReactMarker::StartupLogger& getInstance();

scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8527,7 +8527,6 @@ facebook::react::ReactMarker::AtomicLogTaggedMarker facebook::react::ReactMarker
85278527
class facebook::react::ReactMarker::StartupLogger {
85288528
public double getAppStartupEndTime();
85298529
public double getAppStartupStartTime();
8530-
public double getInitReactRuntimeEndTime();
85318530
public double getInitReactRuntimeStartTime();
85328531
public double getRunJSBundleStartTime();
85338532
public static facebook::react::ReactMarker::StartupLogger& getInstance();

0 commit comments

Comments
 (0)