Skip to content

Commit 5eee40e

Browse files
coadometa-codesync[bot]
authored andcommitted
Add umbrella for react/renderer/graphics subtree (#58373)
Summary: Pull Request resolved: #58373 Pull Request resolved: #58032 Rolls the umbrella-header + include-guard mechanism across the `react/renderer/graphics` module, classifying the target as public. - Adds `<React/Graphics.h>`, re-exporting the module's public interface headers. - Adds `<react/cxxstableapi/UmbrellaGuard.h>` to 24 root headers and all 18 platform headers. - Wires the umbrella header directory into the Buck, CMake, CocoaPods, Gradle, and iOS prebuild header configurations. `conversions.h` and `Geometry.h` are deliberately left unguarded. Both are deprecation shims whose only content is a `#warning` redirecting to their replacements. `PlatformColorParser.h` and `fromRawValueShared.h` include `react/renderer/core/RawValue.h`, which was only reachable on Apple platforms because `react/renderer/core:rawValue` was restricted to `platforms = APPLE`. No source inside the graphics target included those headers off-Apple, so the breakage was latent and invisible; reaching them through the umbrella surfaces it. Changelog: [Internal] Reviewed By: javache Differential Revision: D116779866
1 parent d2a6ce5 commit 5eee40e

40 files changed

Lines changed: 160 additions & 2 deletions

packages/react-native/ReactAndroid/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ val preparePrefab by
153153
Pair("../ReactCommon/react/renderer/debug/React/", "React/"),
154154
// react_renderer_graphics
155155
Pair("../ReactCommon/react/renderer/graphics/", "react/renderer/graphics/"),
156+
Pair("../ReactCommon/react/renderer/graphics/React/", "React/"),
156157
Pair("../ReactCommon/react/renderer/graphics/platform/android/", ""),
157158
// react_renderer_imagemanager
158159
Pair(

packages/react-native/ReactCommon/react/renderer/graphics/BackgroundImage.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/graphics/LinearGradient.h>
1113
#include <react/renderer/graphics/RadialGradient.h>
1214

packages/react-native/ReactCommon/react/renderer/graphics/BackgroundPosition.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/graphics/ValueUnit.h>
1113
#include <optional>
1214

packages/react-native/ReactCommon/react/renderer/graphics/BackgroundRepeat.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
namespace facebook::react {
1113

1214
enum class BackgroundRepeatStyle {

packages/react-native/ReactCommon/react/renderer/graphics/BackgroundSize.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/graphics/ValueUnit.h>
1113
#include <variant>
1214

packages/react-native/ReactCommon/react/renderer/graphics/BlendMode.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <optional>
1113
#include <string_view>
1214

packages/react-native/ReactCommon/react/renderer/graphics/BoxShadow.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/graphics/Color.h>
1113
#include <react/renderer/graphics/Float.h>
1214

packages/react-native/ReactCommon/react/renderer/graphics/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,14 @@ target_include_directories(react_renderer_graphics
2323
${REACT_COMMON_DIR}
2424
${platform_DIR}
2525
)
26+
target_include_directories(react_renderer_graphics INTERFACE ${REACT_COMMON_DIR}/react/renderer/graphics)
2627

2728
react_native_android_selector(fbjni fbjni "")
2829
target_link_libraries(react_renderer_graphics
2930
glog
3031
${fbjni}
3132
folly_runtime
33+
react_cxxstableapi
3234
react_debug
3335
react_renderer_debug
3436
react_utils

packages/react-native/ReactCommon/react/renderer/graphics/Color.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/graphics/ColorComponents.h>
1113
#include <react/renderer/graphics/HostPlatformColor.h>
1214

packages/react-native/ReactCommon/react/renderer/graphics/ColorComponents.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
namespace facebook::react {
1113

1214
enum class ColorSpace { sRGB, DisplayP3 };

0 commit comments

Comments
 (0)