Remove remaining test deep imports (#58573)

Summary:
Pull Request resolved: #58573

Migrate the remaining Flow-visible deep imports in React Native tests. Use public DOM globals where their types are sufficient, and use relative imports for implementation-specific helpers, observer types, and native specs that are not publicly exported.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D120537585

Author: rubennorte

packages/react-native/Libraries/Text/__tests__/Text-itest.js

@@ -13,16 +13,16 @@ import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 import type {HostInstance} from 'react-native';
 import type {AccessibilityProps} from 'react-native';
 
+import accessibilityPropsSuite, {
+  rolePropSuite,
+} from '../../../src/private/__tests__/utilities/accessibilityPropsSuite';
+import {testIDPropSuite} from '../../../src/private/__tests__/utilities/commonPropsSuite';
 import ensureInstance from '../../../src/private/__tests__/utilities/ensureInstance';
 import * as Fantom from '@react-native/fantom';
 import nullthrows from 'nullthrows';
 import * as React from 'react';
 import {createRef} from 'react';
 import {Text} from 'react-native';
-import accessibilityPropsSuite, {
-  rolePropSuite,
-} from 'react-native/src/private/__tests__/utilities/accessibilityPropsSuite';
-import {testIDPropSuite} from 'react-native/src/private/__tests__/utilities/commonPropsSuite';
 
 const TEST_TEXT = 'the text';
 

packages/react-native/Libraries/Utilities/__tests__/BackHandler-itest.js

@@ -10,11 +10,11 @@
 
 import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 
+import {HardwareBackPressEvent} from '../HardwareBackPressEvent';
 import {BackHandler, DeviceEventEmitter} from 'react-native';
-import {HardwareBackPressEvent as HardwareBackPressEventClass} from 'react-native/Libraries/Utilities/HardwareBackPressEvent';
 
 type BackPressHandler = Parameters<typeof BackHandler.addEventListener>[1];
-type HardwareBackPressEvent = Parameters<BackPressHandler>[0];
+type HardwareBackPressEventType = Parameters<BackPressHandler>[0];
 
 describe('BackHandler', () => {
   const subscriptions: Array<{remove: () => void, ...}> = [];
@@ -28,11 +28,11 @@ describe('BackHandler', () => {
 
   it('calls handlers in reverse order (LIFO)', () => {
     const callOrder: Array<string> = [];
-    const handler1 = (_event: HardwareBackPressEvent) => {
+    const handler1 = (_event: HardwareBackPressEventType) => {
       callOrder.push('first');
       return false;
     };
-    const handler2 = (_event: HardwareBackPressEvent) => {
+    const handler2 = (_event: HardwareBackPressEventType) => {
       callOrder.push('second');
       return true;
     };
@@ -51,11 +51,11 @@ describe('BackHandler', () => {
 
   it('calls all handlers when none return true', () => {
     const callOrder: Array<string> = [];
-    const handler1 = (_event: HardwareBackPressEvent) => {
+    const handler1 = (_event: HardwareBackPressEventType) => {
       callOrder.push('first');
       return false;
     };
-    const handler2 = (_event: HardwareBackPressEvent) => {
+    const handler2 = (_event: HardwareBackPressEventType) => {
       callOrder.push('second');
       return false;
     };
@@ -73,8 +73,8 @@ describe('BackHandler', () => {
   });
 
   it('passes HardwareBackPressEvent to handlers', () => {
-    let receivedEvent: ?HardwareBackPressEvent = null;
-    const handler = (event: HardwareBackPressEvent) => {
+    let receivedEvent: ?HardwareBackPressEventType = null;
+    const handler = (event: HardwareBackPressEventType) => {
       receivedEvent = event;
       return true;
     };
@@ -85,12 +85,12 @@ describe('BackHandler', () => {
 
     DeviceEventEmitter.emit('hardwareBackPress', {timeStamp: 42});
 
-    expect(receivedEvent).toBeInstanceOf(HardwareBackPressEventClass);
+    expect(receivedEvent).toBeInstanceOf(HardwareBackPressEvent);
   });
 
   it('event has native timestamp as timeStamp', () => {
-    let receivedEvent: ?HardwareBackPressEvent = null;
-    const handler = (event: HardwareBackPressEvent) => {
+    let receivedEvent: ?HardwareBackPressEventType = null;
+    const handler = (event: HardwareBackPressEventType) => {
       receivedEvent = event;
       return true;
     };
@@ -105,8 +105,8 @@ describe('BackHandler', () => {
   });
 
   it('event falls back to performance.now() when no native timestamp', () => {
-    let receivedEvent: ?HardwareBackPressEvent = null;
-    const handler = (event: HardwareBackPressEvent) => {
+    let receivedEvent: ?HardwareBackPressEventType = null;
+    const handler = (event: HardwareBackPressEventType) => {
       receivedEvent = event;
       return true;
     };
@@ -129,7 +129,7 @@ describe('BackHandler', () => {
 
   it('removes handler on subscription.remove()', () => {
     let called = false;
-    const handler = (_event: HardwareBackPressEvent) => {
+    const handler = (_event: HardwareBackPressEventType) => {
       called = true;
       return true;
     };

packages/react-native/Libraries/Utilities/__tests__/HardwareBackPressEvent-itest.js

@@ -10,8 +10,8 @@
 
 import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 
-import {HardwareBackPressEvent} from 'react-native/Libraries/Utilities/HardwareBackPressEvent';
-import {setEventInitTimeStamp} from 'react-native/src/private/webapis/dom/events/internals/EventInternals';
+import {setEventInitTimeStamp} from '../../../src/private/webapis/dom/events/internals/EventInternals';
+import {HardwareBackPressEvent} from '../HardwareBackPressEvent';
 
 describe('HardwareBackPressEvent', () => {
   it('extends Event', () => {

packages/react-native/src/private/webapis/dom/events/__tests__/Event-itest.js

@@ -13,7 +13,7 @@ import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 import {
   setEventInitTimeStamp,
   setInPassiveListenerFlag,
-} from 'react-native/src/private/webapis/dom/events/internals/EventInternals';
+} from '../internals/EventInternals';
 
 type EventOptions = EventInit & {
   rnIsDirect?: boolean,

packages/react-native/src/private/webapis/dom/events/__tests__/EventHandlerAttributes-itest.js

@@ -15,7 +15,7 @@ import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 import {
   getEventHandlerAttribute,
   setEventHandlerAttribute,
-} from 'react-native/src/private/webapis/dom/events/EventHandlerAttributes';
+} from '../EventHandlerAttributes';
 
 type EventCallback = (event: Event) => void;
 

packages/react-native/src/private/webapis/dom/events/__tests__/EventTarget-benchmark-itest.js

@@ -11,9 +11,9 @@
 
 import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 
+import {EVENT_TARGET_GET_DECLARATIVE_LISTENER_KEY} from '../internals/EventTargetInternals';
 import createEventTargetHierarchyWithDepth from './createEventTargetHierarchyWithDepth';
 import {unstable_benchmark} from '@react-native/fantom';
-import {EVENT_TARGET_GET_DECLARATIVE_LISTENER_KEY} from 'react-native/src/private/webapis/dom/events/internals/EventTargetInternals';
 
 let event: Event;
 let eventTarget: EventTarget;

packages/react-native/src/private/webapis/dom/nodes/__tests__/ReactNativeDocument-itest.js

@@ -19,8 +19,6 @@ import nullthrows from 'nullthrows';
 import * as React from 'react';
 import {createRef} from 'react';
 import {View} from 'react-native';
-import ReactNativeDocument from 'react-native/src/private/webapis/dom/nodes/ReactNativeDocument';
-import ReactNativeElement from 'react-native/src/private/webapis/dom/nodes/ReactNativeElement';
 
 describe('ReactNativeDocument', () => {
   it('is connected until the surface is destroyed', () => {
@@ -32,7 +30,7 @@ describe('ReactNativeDocument', () => {
     });
 
     const element = nullthrows(nodeRef.current);
-    const document = ensureInstance(element.ownerDocument, ReactNativeDocument);
+    const document = ensureInstance(element.ownerDocument, Document);
 
     expect(document.isConnected).toBe(true);
 
@@ -58,14 +56,15 @@ describe('ReactNativeDocument', () => {
     });
 
     const element = nullthrows(nodeRef.current);
-    const document = ensureInstance(element.ownerDocument, ReactNativeDocument);
+    const document = ensureInstance(element.ownerDocument, Document);
+    const documentElement = nullthrows(document.documentElement);
 
     expect(document.childNodes.length).toBe(1);
-    expect(document.childNodes[0]).toBe(document.documentElement);
-    expect(document.documentElement.parentNode).toBe(document);
-    expect(document.documentElement.childNodes.length).toBe(1);
-    expect(document.documentElement.childNodes[0]).toBe(element);
-    expect(element.parentNode).toBe(document.documentElement);
+    expect(document.childNodes[0]).toBe(documentElement);
+    expect(documentElement.parentNode).toBe(document);
+    expect(documentElement.childNodes.length).toBe(1);
+    expect(documentElement.childNodes[0]).toBe(element);
+    expect(element.parentNode).toBe(documentElement);
   });
 
   it('allows traversal through document-specific methods', () => {
@@ -77,7 +76,7 @@ describe('ReactNativeDocument', () => {
     });
 
     const element = nullthrows(nodeRef.current);
-    const document = ensureInstance(element.ownerDocument, ReactNativeDocument);
+    const document = ensureInstance(element.ownerDocument, Document);
 
     expect(document.childElementCount).toBe(1);
     expect(document.firstElementChild).toBe(document.documentElement);
@@ -95,7 +94,7 @@ describe('ReactNativeDocument', () => {
     });
 
     const element = nullthrows(nodeRef.current);
-    const document = ensureInstance(element.ownerDocument, ReactNativeDocument);
+    const document = ensureInstance(element.ownerDocument, Document);
 
     expect(document.nodeName).toBe('#document');
     expect(document.nodeType).toBe(Node.DOCUMENT_NODE);
@@ -117,19 +116,19 @@ describe('ReactNativeDocument', () => {
     });
 
     const element = nullthrows(nodeRef.current);
-    const document = ensureInstance(element.ownerDocument, ReactNativeDocument);
+    const document = ensureInstance(element.ownerDocument, Document);
+    const documentElement = nullthrows(document.documentElement);
 
-    const {x, y, width, height} =
-      document.documentElement.getBoundingClientRect();
+    const {x, y, width, height} = documentElement.getBoundingClientRect();
 
     expect(x).toBe(111);
     expect(y).toBe(222);
     expect(width).toBe(200);
     expect(height).toBe(100);
 
-    expect(document.documentElement.offsetParent).toBe(null);
-    expect(document.documentElement.offsetTop).toBe(0);
-    expect(document.documentElement.offsetLeft).toBe(0);
+    expect(documentElement.offsetParent).toBe(null);
+    expect(documentElement.offsetTop).toBe(0);
+    expect(documentElement.offsetLeft).toBe(0);
   });
 
   it('implements compareDocumentPosition correctly', () => {
@@ -140,18 +139,14 @@ describe('ReactNativeDocument', () => {
       root.render(<View ref={nodeRef} />);
     });
 
-    const element = nullthrows(nodeRef.current);
-    const document = ensureInstance(element.ownerDocument, ReactNativeDocument);
-    const documentElement = document.documentElement;
+    const element = ensureInstance(nodeRef.current, Element);
+    const document = ensureInstance(element.ownerDocument, Document);
+    const documentElement = nullthrows(document.documentElement);
 
     /* eslint-disable no-bitwise */
 
     expect(document.compareDocumentPosition(document)).toBe(0);
-    expect(
-      document.documentElement.compareDocumentPosition(
-        document.documentElement,
-      ),
-    ).toBe(0);
+    expect(documentElement.compareDocumentPosition(documentElement)).toBe(0);
 
     expect(document.compareDocumentPosition(documentElement)).toBe(
       Node.DOCUMENT_POSITION_CONTAINED_BY | Node.DOCUMENT_POSITION_FOLLOWING,
@@ -185,10 +180,7 @@ describe('ReactNativeDocument', () => {
     let maybeWeakDocument;
     Fantom.runTask(() => {
       maybeWeakDocument = new WeakRef(
-        ensureInstance(
-          nullthrows(nodeRef.current).ownerDocument,
-          ReactNativeDocument,
-        ),
+        ensureInstance(nullthrows(nodeRef.current).ownerDocument, Document),
       );
       maybeWeakNode = new WeakRef(nullthrows(nodeRef.current));
     });
@@ -250,11 +242,8 @@ describe('ReactNativeDocument', () => {
         );
       });
 
-      const element = ensureInstance(lastNode, ReactNativeElement);
-      const document = ensureInstance(
-        element.ownerDocument,
-        ReactNativeDocument,
-      );
+      const element = ensureInstance(lastNode, Element);
+      const document = ensureInstance(element.ownerDocument, Document);
 
       expect(document.getElementById('foo')).toBe(fooNode);
       expect(document.getElementById('bar')).toBe(barFirstNode);

packages/react-native/src/private/webapis/dom/nodes/__tests__/ReactNativeElement-itest.js

@@ -17,6 +17,7 @@ import type {HostInstance} from 'react-native';
 
 import ensureInstance from '../../../../__tests__/utilities/ensureInstance';
 import TextInputState from '../../../../../../Libraries/Components/TextInput/TextInputState';
+import {NativeVirtualText} from '../../../../../../Libraries/Text/TextNativeComponent';
 import * as Fantom from '@react-native/fantom';
 import nullthrows from 'nullthrows';
 import * as React from 'react';
@@ -29,7 +30,6 @@ import {
   View,
   unstable_NativeText as NativeText,
 } from 'react-native';
-import {NativeVirtualText} from 'react-native/Libraries/Text/TextNativeComponent';
 import {ReactNativeFeatureFlags} from 'react-native/react-private-interface';
 
 // The public imperative EventTarget API is not part of the static type of this

packages/react-native/src/private/webapis/dom/nodes/__tests__/ReadOnlyText-itest.js

@@ -15,14 +15,14 @@ import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 import type {HostInstance} from 'react-native';
 
 import ensureInstance from '../../../../__tests__/utilities/ensureInstance';
+import ReadOnlyText from '../ReadOnlyText';
 import * as Fantom from '@react-native/fantom';
 import invariant from 'invariant';
 import nullthrows from 'nullthrows';
 import * as React from 'react';
 import {createRef} from 'react';
 import {unstable_NativeText as NativeText} from 'react-native';
 import {ReactNativeFeatureFlags} from 'react-native/react-private-interface';
-import ReadOnlyText from 'react-native/src/private/webapis/dom/nodes/ReadOnlyText';
 
 function ensureReadOnlyText(value: unknown): ReadOnlyText {
   return ensureInstance(value, ReadOnlyText);

packages/react-native/src/private/webapis/intersectionobserver/__tests__/IntersectionObserver-benchmark-itest.js

@@ -11,9 +11,9 @@
 
 import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 
+import type IntersectionObserverType from '../IntersectionObserver';
 import type {Root} from '@react-native/fantom';
 import type {HostInstance} from 'react-native';
-import type IntersectionObserverType from 'react-native/src/private/webapis/intersectionobserver/IntersectionObserver';
 
 import * as Fantom from '@react-native/fantom';
 import nullthrows from 'nullthrows';