From 94717c131570c66fffdd2354ff4f050c12970e34 Mon Sep 17 00:00:00 2001 From: Matt Carroll Date: Fri, 31 Jul 2026 20:57:42 -0700 Subject: [PATCH] [RN] Make yarn the source of truth for JS lint/format ## Summary Point synced JavaScript formatting and linting at the repository's own Prettier + ESLint so CI is the source of truth: add `yarn f` (Prettier), expand the Prettier globs to all JS-family extensions, and make the CI ESLint step propagate its exit status instead of swallowing it. ## Changelog [Internal] ## Test Plan `yarn lint`, `yarn format-check`, and `yarn f` run from the repo root; the GitHub `lint` job runs both on this PR. Changelog: [Internal] --- .github/workflows/test-all.yml | 2 +- package.json | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index 3b1a45e6bd3..0d2262dc5d5 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -507,7 +507,7 @@ jobs: run: yarn run lint-markdown - name: ESLint shell: bash - run: ./.github/workflow-scripts/exec_swallow_error.sh yarn lint --format junit -o ./reports/junit/eslint/results.xml + run: yarn lint - name: Flow shell: bash run: yarn flow-check diff --git a/package.json b/package.json index e5ff3fa3773..a4c82b94bba 100644 --- a/package.json +++ b/package.json @@ -15,8 +15,9 @@ "cxx-api-validate": "python -m scripts.cxx-api.parser --validate", "flow-check": "flow full-check", "flow": "flow", - "format-check": "prettier --list-different \"./**/*.{js,md,yml,ts,tsx}\"", - "format": "npm run prettier && npm run clang-format", + "f": "yarn prettier", + "format-check": "prettier --list-different \"./**/*.{cjs,cts,flow,js,jsx,md,mjs,mts,ts,tsx,yaml,yml}\"", + "format": "yarn prettier && yarn clang-format", "featureflags": "yarn --cwd packages/react-native featureflags", "js-api-diff": "node ./scripts/js-api/diff-api-snapshot", "lint-kotlin-check": "./gradlew ktfmtCheck", @@ -24,7 +25,7 @@ "lint-markdown": "markdownlint-cli2 2>&1", "lint": "eslint --max-warnings 0 .", "preinstall": "node ./scripts/try-set-hermes-compiler-prebuilt.js", - "prettier": "prettier --write \"./**/*.{js,md,yml,ts,tsx}\"", + "prettier": "prettier --write \"./**/*.{cjs,cts,flow,js,jsx,md,mjs,mts,ts,tsx,yaml,yml}\"", "shellcheck": "./.github/workflow-scripts/analyze_scripts.sh", "start": "yarn --cwd packages/rn-tester start", "set-version": "node ./scripts/releases/set-version.js",