From 9d1f0b1576ddaac4cec1743cffd7b79523bd93c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Ma=C5=82ecki?= Date: Thu, 17 Sep 2026 09:07:25 -0700 Subject: [PATCH] Use ComponentRegistry umbrella in generated descriptors (#58554) Summary: Generate component descriptor headers through the public umbrella instead of directly including ComponentDescriptorProviderRegistry.h. Refresh codegen snapshots and the checked-in popup-menu binding, and export the ComponentRegistry dependency needed by that public generated header. Changelog: [Internal]. Reviewed By: cipolleschi Differential Revision: D120317127 --- .../GenerateComponentDescriptorH-test.js.snap | 36 ++++----- .../GenerateComponentDescriptorH-test.js.snap | 36 ++++----- .../GenerateComponentDescriptorH.js | 2 +- .../GenerateComponentDescriptorH-test.js.snap | 76 +++++++++---------- .../ComponentDescriptors.h | 2 +- .../tester/codegen/CMakeLists.txt | 1 + 6 files changed, 77 insertions(+), 76 deletions(-) diff --git a/packages/react-native-codegen/e2e/deep_imports/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap b/packages/react-native-codegen/e2e/deep_imports/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap index 46757e6c95c0..6d4e694d14d5 100644 --- a/packages/react-native-codegen/e2e/deep_imports/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap +++ b/packages/react-native-codegen/e2e/deep_imports/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap @@ -15,8 +15,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -45,8 +45,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -75,8 +75,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -105,8 +105,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -135,8 +135,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -165,8 +165,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -195,8 +195,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -225,8 +225,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -255,8 +255,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -285,8 +285,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -315,8 +315,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -345,8 +345,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -375,8 +375,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -405,8 +405,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -435,8 +435,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -465,8 +465,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -495,8 +495,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -525,8 +525,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { diff --git a/packages/react-native-codegen/e2e/namespaced/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap b/packages/react-native-codegen/e2e/namespaced/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap index 049c9f244add..94010f4fdbe3 100644 --- a/packages/react-native-codegen/e2e/namespaced/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap +++ b/packages/react-native-codegen/e2e/namespaced/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap @@ -15,8 +15,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -45,8 +45,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -75,8 +75,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -105,8 +105,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -135,8 +135,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -165,8 +165,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -195,8 +195,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -225,8 +225,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -255,8 +255,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -285,8 +285,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -315,8 +315,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -345,8 +345,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -375,8 +375,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -405,8 +405,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -435,8 +435,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -465,8 +465,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -495,8 +495,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { @@ -525,8 +525,8 @@ Object { #pragma once #include +#include #include -#include namespace facebook::react { diff --git a/packages/react-native-codegen/src/generators/components/GenerateComponentDescriptorH.js b/packages/react-native-codegen/src/generators/components/GenerateComponentDescriptorH.js index 75dba99e559c..b5f508277e5b 100644 --- a/packages/react-native-codegen/src/generators/components/GenerateComponentDescriptorH.js +++ b/packages/react-native-codegen/src/generators/components/GenerateComponentDescriptorH.js @@ -38,8 +38,8 @@ const FileTemplate = ({ #pragma once ${IncludeTemplate({headerPrefix, file: 'ShadowNodes.h'})} +#include #include -#include namespace facebook::react { diff --git a/packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GenerateComponentDescriptorH-test.js.snap b/packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GenerateComponentDescriptorH-test.js.snap index 8657a4701bff..0248e91ba64e 100644 --- a/packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GenerateComponentDescriptorH-test.js.snap +++ b/packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GenerateComponentDescriptorH-test.js.snap @@ -15,8 +15,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -45,8 +45,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -75,8 +75,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -105,8 +105,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -135,8 +135,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -165,8 +165,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -195,8 +195,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -225,8 +225,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -255,8 +255,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -285,8 +285,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -315,8 +315,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -345,8 +345,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -375,8 +375,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -405,8 +405,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -435,8 +435,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -465,8 +465,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -495,8 +495,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -525,8 +525,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -555,8 +555,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -585,8 +585,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -615,8 +615,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -646,8 +646,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -676,8 +676,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -706,8 +706,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -736,8 +736,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -766,8 +766,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -796,8 +796,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -826,8 +826,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -856,8 +856,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -886,8 +886,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -916,8 +916,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -946,8 +946,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -976,8 +976,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -1006,8 +1006,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -1036,8 +1036,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -1066,8 +1066,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -1096,8 +1096,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { @@ -1127,8 +1127,8 @@ Map { #pragma once #include +#include #include -#include namespace facebook::react { diff --git a/packages/react-native-popup-menu-android/android/src/main/jni/react/renderer/components/ReactPopupMenuAndroidSpecs/ComponentDescriptors.h b/packages/react-native-popup-menu-android/android/src/main/jni/react/renderer/components/ReactPopupMenuAndroidSpecs/ComponentDescriptors.h index 48fbdfabc578..b89a3e123540 100644 --- a/packages/react-native-popup-menu-android/android/src/main/jni/react/renderer/components/ReactPopupMenuAndroidSpecs/ComponentDescriptors.h +++ b/packages/react-native-popup-menu-android/android/src/main/jni/react/renderer/components/ReactPopupMenuAndroidSpecs/ComponentDescriptors.h @@ -11,8 +11,8 @@ #pragma once #include "ShadowNodes.h" +#include #include -#include namespace facebook::react { diff --git a/private/react-native-fantom/tester/codegen/CMakeLists.txt b/private/react-native-fantom/tester/codegen/CMakeLists.txt index 368d33014609..5c5f88997dff 100644 --- a/private/react-native-fantom/tester/codegen/CMakeLists.txt +++ b/private/react-native-fantom/tester/codegen/CMakeLists.txt @@ -24,6 +24,7 @@ target_link_libraries( react_codegen_rncore jsi react_nativemodule_core + react_renderer_componentregistry rrc_view )