Repository navigation
Commit 5430bc9
committed
docs: fix an inverted comment in the quiz-form example
The comment in final_form/app.py said ReactPy 'still submits the form's
defaults' when preventDefault() is detected -- the opposite of what it does. It
suppresses the default navigation, which is the only reason the async handler
survives long enough to render the result. Verified in Chrome: submitting stays
on the page (pathname '/'), the textarea and button lock during the await, and
the error paragraph appears after it resolves.
Measured prevent_default detection on the shipped bytecode: direct call True,
async handler awaiting after the call True, call hidden in a helper False,
rebound argument False -- so the comment's warning about indirection is now
stated explicitly.
Also correct running-tests.md's summary bullet that called the docs checks a
gate on every pull request; nothing gates them (see about/code.md).1 parent 24cbacd commit 5430bc9
2 files changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
0 commit comments