Fix some flow errors

There are still some errors left which I'm not sure are worth fixing :-/

Author: fkling

flow/react-docgen.js

@@ -32,4 +32,4 @@ declare class Documentation {
 
 type Handler = (documentation: Documentation, path: NodePath) => void;
 type Resolver =
-  (node: ASTNode, recast: Recast) => (NodePath|Array<NodePath>|void);
+  (node: ASTNode, recast: Recast) => (?NodePath|?Array<NodePath>);

flow/recast.js

@@ -8,6 +8,8 @@
  *
  */
 
+/*eslint no-unused-vars: 0*/
+
 /**
  * A minimal set of declarations to make flow work with the recast API.
  */
@@ -16,17 +18,21 @@ type ASTNode = Object;
 
 declare class Scope {
   lookup(name: string): ?Scope;
-  getBindings(): Object<string, Array<NodePath>>;
+  getBindings(): {[key: string]: NodePath};
+  node: NodePath;
 }
 
 declare class NodePath {
+  value: (ASTNode|Array<ASTNode>);
   node: ASTNode;
   parent: NodePath;
+  parentPath: NodePath;
   scope: Scope;
 
-  get(...x: (string|number)): NodePath;
-  each(f: (p: NodePath) => void): void;
+  get(...x: Array<string|number>): NodePath;
+  each(f: (p: NodePath) => any): any;
   map<T>(f: (p: NodePath) => T): Array<T>;
+  filter(f: (p: NodePath) => bool): Array<NodePath>;
 }
 
 type Recast = {

src/main.js

@@ -15,8 +15,8 @@ import parse from './parse';
 import * as resolver from './resolver';
 import * as utils from './utils';
 
-const defaultResolver = resolver.findExportedComponentDefinition;
-const defaultHandlers = [
+var defaultResolver = resolver.findExportedComponentDefinition;
+var defaultHandlers = [
   handlers.propTypeHandler,
   handlers.propDocBlockHandler,
   handlers.defaultPropsHandler,

src/parse.js

@@ -15,7 +15,7 @@ import Documentation from './Documentation';
 import babylon from './babylon';
 import recast from 'recast';
 
-const ERROR_MISSING_DEFINITION = 'No suitable component definition found.';
+var ERROR_MISSING_DEFINITION = 'No suitable component definition found.';
 
 function executeHandlers(handlers, componentDefinitions) {
   return componentDefinitions.map(componentDefinition => {

src/utils/docblock.js

@@ -13,9 +13,7 @@
  * Helper functions to work with docblock comments.
  */
 
-import recast from 'recast';
-
-const DOCLET_PATTERN = /^@(\w+)(?:$|\s((?:[^](?!^@\w))*))/gmi;
+var DOCLET_PATTERN = /^@(\w+)(?:$|\s((?:[^](?!^@\w))*))/gmi;
 
 function parseDocblock(str) {
   var lines = str.split('\n');

src/utils/getClassMemberValuePath.js

@@ -18,7 +18,7 @@ var {types: {namedTypes: types}} = recast;
 export default function getClassMemberValuePath(
   classDefinition: NodePath,
   memberName: string
-) {
+): ?NodePath {
   // Fortunately it seems like that all members of a class body, be it
   // ClassProperty or MethodDefinition, have the same structure: They have a
   // "key" and a "value"

src/utils/getMemberValuePath.js

@@ -16,12 +16,12 @@ import recast from 'recast';
 
 var {types: {namedTypes: types}} = recast;
 
-const SYNONYMS = {
+var SYNONYMS = {
   getDefaultProps: 'defaultProps',
   defaultProps: 'getDefaultProps',
 };
 
-const LOOKUP_METHOD = {
+var LOOKUP_METHOD = {
   [types.ObjectExpression.name]: getPropertyValuePath,
   [types.ClassDeclaration.name]: getClassMemberValuePath,
   [types.ClassExpression.name]: getClassMemberValuePath,

src/utils/getMembers.js

@@ -38,7 +38,7 @@ var {types: {namedTypes: types}} = recast;
  *   {path: NodePath<42>, arguments: null, computed: false}
  * ]
  */
-export default function getMembers(path: NodePath): Array<MemberExpression> {
+export default function getMembers(path: NodePath): Array<MemberDescriptor> {
   var result = [];
   var argumentsPath = null;
   loop: while(true) { // eslint-disable-line no-constant-condition
@@ -62,5 +62,3 @@ export default function getMembers(path: NodePath): Array<MemberExpression> {
   }
   return result.reverse();
 }
-
-module.exports = getMembers;

src/utils/getPropType.js

@@ -128,12 +128,14 @@ export default function getPropType(path: NodePath): PropTypeDescriptor {
     } else if (types.Identifier.check(node) && !member.computed) {
       name = node.name;
     }
-    if (simplePropTypes.hasOwnProperty(name)) {
-      descriptor = {name};
-      return true;
-    } else if (propTypes.hasOwnProperty(name) && member.argumentsPath) {
-      descriptor = propTypes[name](member.argumentsPath.get(0));
-      return true;
+    if (name) {
+      if (simplePropTypes.hasOwnProperty(name)) {
+        descriptor = {name};
+        return true;
+      } else if (propTypes.hasOwnProperty(name) && member.argumentsPath) {
+        descriptor = propTypes[name](member.argumentsPath.get(0));
+        return true;
+      }
     }
   });
   if (!descriptor) {

src/utils/isReactCreateClassCall.js

@@ -30,5 +30,5 @@ export default function isReactCreateClassCall(path: NodePath): boolean {
     return false;
   }
   var module = resolveToModule(path.get('callee', 'object'));
-  return module && isReactModuleName(module);
+  return Boolean(module && isReactModuleName(module));
 }