Skip to content

Commit 18faeed

Browse files
BookOfGregBookOfGreg
committed
Remove final references to React.createClass
1 parent 1ba1110 commit 18faeed

File tree

7 files changed

+86
-50
lines changed

7 files changed

+86
-50
lines changed

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ Now, you can create React components in `.jsx` files:
9999
```js
100100
// app/assets/javascripts/components/post.jsx
101101

102-
window.Post = React.createClass({
102+
window.Post = createReactClass({
103103
render: function() {
104104
return <h1>{this.props.title}</h1>
105105
}

‎lib/assets/javascripts/JSXTransformer.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15708,22 +15708,22 @@ function addDisplayName(displayName, object, state) {
1570815708
/**
1570915709
* Transforms the following:
1571015710
*
15711-
* var MyComponent = React.createClass({
15711+
* var MyComponent = createReactClass({
1571215712
* render: ...
1571315713
* });
1571415714
*
1571515715
* into:
1571615716
*
15717-
* var MyComponent = React.createClass({
15717+
* var MyComponent = createReactClass({
1571815718
* displayName: 'MyComponent',
1571915719
* render: ...
1572015720
* });
1572115721
*
1572215722
* Also catches:
1572315723
*
15724-
* MyComponent = React.createClass(...);
15725-
* exports.MyComponent = React.createClass(...);
15726-
* module.exports = {MyComponent: React.createClass(...)};
15724+
* MyComponent = createReactClass(...);
15725+
* exports.MyComponent = createReactClass(...);
15726+
* module.exports = {MyComponent: createReactClass(...)};
1572715727
*/
1572815728
function visitReactDisplayName(traverse, object, path, state) {
1572915729
var left, right;
@@ -15916,4 +15916,4 @@ function inlineSourceMap(sourceMap, sourceCode, sourceFilename) {
1591615916
module.exports = inlineSourceMap;
1591715917

1591815918
},{"buffer":3}]},{},[1])(1)
15919-
});
15919+
});

‎test/dummy_webpacker1/app/javascript/components/WithSetTimeout.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
var React = require("react")
22
var createReactClass = require("create-react-class")
33

4-
module.exports = React.createClass({
4+
module.exports = createReactClass({
55
componentWillMount: function () {
66
setTimeout(function () {}, 1000)
77
clearTimeout(0)

‎test/dummy_webpacker1/package.json‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"coffee-loader": "^0.7.3",
1010
"coffee-script": "^1.12.6",
1111
"compression-webpack-plugin": "^0.4.0",
12+
"create-react-class": "^15.6.2",
1213
"css-loader": "^0.28.1",
1314
"extract-text-webpack-plugin": "^2.1.0",
1415
"file-loader": "^0.11.1",
@@ -19,10 +20,10 @@
1920
"postcss-loader": "^2.0.5",
2021
"postcss-smart-import": "^0.7.0",
2122
"precss": "^1.4.0",
22-
"prop-types": "^15.5.10",
23+
"prop-types": "^15.6.0",
2324
"rails-erb-loader": "^5.0.1",
24-
"react": "^15.5.4",
25-
"react-dom": "^15.5.4",
25+
"react": "^16.0.0",
26+
"react-dom": "^16.0.0",
2627
"react_ujs": "^2.1.0",
2728
"resolve-url-loader": "^2.0.2",
2829
"sass-loader": "^6.0.5",

‎test/dummy_webpacker1/yarn.lock‎

Lines changed: 37 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1265,6 +1265,14 @@ create-hmac@^1.1.0, create-hmac@^1.1.2:
12651265
create-hash "^1.1.0"
12661266
inherits "^2.0.1"
12671267

1268+
create-react-class@^15.6.2:
1269+
version "15.6.2"
1270+
resolved "https://registry.yarnpkg.com/create-react-class/-/create-react-class-15.6.2.tgz#cf1ed15f12aad7f14ef5f2dfe05e6c42f91ef02a"
1271+
dependencies:
1272+
fbjs "^0.8.9"
1273+
loose-envify "^1.3.1"
1274+
object-assign "^4.1.1"
1275+
12681276
cross-spawn@^3.0.0:
12691277
version "3.0.1"
12701278
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-3.0.1.tgz#1256037ecb9f0c5f79e3d6ef135e30770184b982"
@@ -1687,6 +1695,18 @@ faye-websocket@~0.11.0:
16871695
dependencies:
16881696
websocket-driver ">=0.5.1"
16891697

1698+
fbjs@^0.8.16:
1699+
version "0.8.16"
1700+
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.16.tgz#5e67432f550dc41b572bf55847b8aca64e5337db"
1701+
dependencies:
1702+
core-js "^1.0.0"
1703+
isomorphic-fetch "^2.1.1"
1704+
loose-envify "^1.0.0"
1705+
object-assign "^4.1.0"
1706+
promise "^7.1.1"
1707+
setimmediate "^1.0.5"
1708+
ua-parser-js "^0.7.9"
1709+
16901710
fbjs@^0.8.9:
16911711
version "0.8.12"
16921712
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.12.tgz#10b5d92f76d45575fd63a217d4ea02bea2f8ed04"
@@ -3553,12 +3573,13 @@ promise@^7.1.1:
35533573
dependencies:
35543574
asap "~2.0.3"
35553575

3556-
prop-types@^15.5.10, prop-types@^15.5.7, prop-types@~15.5.7:
3557-
version "15.5.10"
3558-
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.5.10.tgz#2797dfc3126182e3a95e3dfbb2e893ddd7456154"
3576+
prop-types@^15.6.0:
3577+
version "15.6.0"
3578+
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.6.0.tgz#ceaf083022fc46b4a35f69e13ef75aed0d639856"
35593579
dependencies:
3560-
fbjs "^0.8.9"
3580+
fbjs "^0.8.16"
35613581
loose-envify "^1.3.1"
3582+
object-assign "^4.1.1"
35623583

35633584
proxy-addr@~1.1.3:
35643585
version "1.1.4"
@@ -3651,23 +3672,23 @@ rc@^1.1.7:
36513672
minimist "^1.2.0"
36523673
strip-json-comments "~2.0.1"
36533674

3654-
react-dom@^15.5.4:
3655-
version "15.5.4"
3656-
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-15.5.4.tgz#ba0c28786fd52ed7e4f2135fe0288d462aef93da"
3675+
react-dom@^16.0.0:
3676+
version "16.0.0"
3677+
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.0.0.tgz#9cc3079c3dcd70d4c6e01b84aab2a7e34c303f58"
36573678
dependencies:
3658-
fbjs "^0.8.9"
3679+
fbjs "^0.8.16"
36593680
loose-envify "^1.1.0"
3660-
object-assign "^4.1.0"
3661-
prop-types "~15.5.7"
3681+
object-assign "^4.1.1"
3682+
prop-types "^15.6.0"
36623683

3663-
react@^15.5.4:
3664-
version "15.5.4"
3665-
resolved "https://registry.yarnpkg.com/react/-/react-15.5.4.tgz#fa83eb01506ab237cdc1c8c3b1cea8de012bf047"
3684+
react@^16.0.0:
3685+
version "16.0.0"
3686+
resolved "https://registry.yarnpkg.com/react/-/react-16.0.0.tgz#ce7df8f1941b036f02b2cca9dbd0cb1f0e855e2d"
36663687
dependencies:
3667-
fbjs "^0.8.9"
3688+
fbjs "^0.8.16"
36683689
loose-envify "^1.1.0"
3669-
object-assign "^4.1.0"
3670-
prop-types "^15.5.7"
3690+
object-assign "^4.1.1"
3691+
prop-types "^15.6.0"
36713692

36723693
react_ujs@^2.1.0:
36733694
version "2.1.0"

‎test/dummy_webpacker2/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"coffee-loader": "^0.8.0",
1212
"coffee-script": "^1.12.7",
1313
"compression-webpack-plugin": "^1.0.0",
14-
"create-react-class": "^15.6.0",
14+
"create-react-class": "^15.6.2",
1515
"css-loader": "^0.28.7",
1616
"extract-text-webpack-plugin": "2.x.x",
1717
"file-loader": "^0.11.2",
@@ -22,10 +22,10 @@
2222
"postcss-loader": "^2.0.6",
2323
"postcss-smart-import": "^0.7.5",
2424
"precss": "^2.0.0",
25-
"prop-types": "^15.5.10",
25+
"prop-types": "^15.6.0",
2626
"rails-erb-loader": "^5.2.1",
27-
"react": "15.4.x",
28-
"react-dom": "^15.6.1",
27+
"react": "^16.0.0",
28+
"react-dom": "^16.0.0",
2929
"react_ujs": "^2.2.1",
3030
"resolve-url-loader": "^2.1.0",
3131
"sass-loader": "^6.0.6",

‎test/dummy_webpacker2/yarn.lock‎

Lines changed: 33 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1308,9 +1308,9 @@ create-hmac@^1.1.0, create-hmac@^1.1.2, create-hmac@^1.1.4:
13081308
safe-buffer "^5.0.1"
13091309
sha.js "^2.4.8"
13101310

1311-
create-react-class@^15.6.0:
1312-
version "15.6.0"
1313-
resolved "https://registry.yarnpkg.com/create-react-class/-/create-react-class-15.6.0.tgz#ab448497c26566e1e29413e883207d57cfe7bed4"
1311+
create-react-class@^15.6.2:
1312+
version "15.6.2"
1313+
resolved "https://registry.yarnpkg.com/create-react-class/-/create-react-class-15.6.2.tgz#cf1ed15f12aad7f14ef5f2dfe05e6c42f91ef02a"
13141314
dependencies:
13151315
fbjs "^0.8.9"
13161316
loose-envify "^1.3.1"
@@ -1779,7 +1779,19 @@ faye-websocket@~0.11.0:
17791779
dependencies:
17801780
websocket-driver ">=0.5.1"
17811781

1782-
fbjs@^0.8.4, fbjs@^0.8.9:
1782+
fbjs@^0.8.16:
1783+
version "0.8.16"
1784+
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.16.tgz#5e67432f550dc41b572bf55847b8aca64e5337db"
1785+
dependencies:
1786+
core-js "^1.0.0"
1787+
isomorphic-fetch "^2.1.1"
1788+
loose-envify "^1.0.0"
1789+
object-assign "^4.1.0"
1790+
promise "^7.1.1"
1791+
setimmediate "^1.0.5"
1792+
ua-parser-js "^0.7.9"
1793+
1794+
fbjs@^0.8.9:
17831795
version "0.8.15"
17841796
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.15.tgz#4f0695fdfcc16c37c0b07facec8cb4c4091685b9"
17851797
dependencies:
@@ -3785,12 +3797,13 @@ promise@^7.1.1:
37853797
dependencies:
37863798
asap "~2.0.3"
37873799

3788-
prop-types@^15.5.10:
3789-
version "15.5.10"
3790-
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.5.10.tgz#2797dfc3126182e3a95e3dfbb2e893ddd7456154"
3800+
prop-types@^15.6.0:
3801+
version "15.6.0"
3802+
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.6.0.tgz#ceaf083022fc46b4a35f69e13ef75aed0d639856"
37913803
dependencies:
3792-
fbjs "^0.8.9"
3804+
fbjs "^0.8.16"
37933805
loose-envify "^1.3.1"
3806+
object-assign "^4.1.1"
37943807

37953808
proxy-addr@~1.1.5:
37963809
version "1.1.5"
@@ -3893,22 +3906,23 @@ rc@^1.1.7:
38933906
minimist "^1.2.0"
38943907
strip-json-comments "~2.0.1"
38953908

3896-
react-dom@^15.6.1:
3897-
version "15.6.1"
3898-
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-15.6.1.tgz#2cb0ed4191038e53c209eb3a79a23e2a4cf99470"
3909+
react-dom@^16.0.0:
3910+
version "16.0.0"
3911+
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.0.0.tgz#9cc3079c3dcd70d4c6e01b84aab2a7e34c303f58"
38993912
dependencies:
3900-
fbjs "^0.8.9"
3913+
fbjs "^0.8.16"
39013914
loose-envify "^1.1.0"
3902-
object-assign "^4.1.0"
3903-
prop-types "^15.5.10"
3915+
object-assign "^4.1.1"
3916+
prop-types "^15.6.0"
39043917

3905-
react@15.4.x:
3906-
version "15.4.2"
3907-
resolved "https://registry.yarnpkg.com/react/-/react-15.4.2.tgz#41f7991b26185392ba9bae96c8889e7e018397ef"
3918+
react@^16.0.0:
3919+
version "16.0.0"
3920+
resolved "https://registry.yarnpkg.com/react/-/react-16.0.0.tgz#ce7df8f1941b036f02b2cca9dbd0cb1f0e855e2d"
39083921
dependencies:
3909-
fbjs "^0.8.4"
3922+
fbjs "^0.8.16"
39103923
loose-envify "^1.1.0"
3911-
object-assign "^4.1.0"
3924+
object-assign "^4.1.1"
3925+
prop-types "^15.6.0"
39123926

39133927
react_ujs@^2.2.1:
39143928
version "2.2.1"

0 commit comments

Comments
 (0)