PHPStan reports errors from extensions

[alleknalle]

I have some PHPStan extensions installed in my project which return errors when I run argtyper.
It looks like currently only 'basic' PHPStan rules are disabled in phpstan-collecting-data.neon

I got it working by disabling all the errors in phpstan-collecting-data.neon manually, but I think it would be good to create an IgnoreErrorExtension (https://phpstan.org/developing-extensions/ignore-error-extensions) to suppress all errors that are not applicate to argtyper.

[TomasVotruba]

Hi, thanks for reporting. I'm not sure what feature you're talking about.
What exact error is argtyper reporting that it should not? How exactly can we fix it here? Ideally with PR to our configs here, so I can see directly what you mean.

Thanks 👍

[alleknalle]

Hi,

I've installed phpstan/phpstan-strict-rules and phpstan/phpstan-doctrine in my project.
When running vendor/bin/argtyper add-types ., Argtyper will first run PHPStan to collect data for Argtyper. It runs with the specific config file config/phpstan-collection-data.neon.
This config file disables all PHPStan rules to run because of customRulesetUsed: true and only runs the rules mentioned in the rules section.
But customRulesetUsed: true only disables 'basic' PHPStan rules, not other rules that ire configured by 'other' packages like phpstan/phpstan-strict-rules and phpstan/phpstan-doctrine.
Since you can't know what other rules people have installed/configured in their project, you can't rely on disabling all 'other' rules in the config file, also because some packages (like phpstan/phpstan-doctrine) don't have any configuration available to disable running the rules after it is installed.
So Argtyper still runs the 'other' rules resulting in multiple errors in step 1. Running PHPStan to collect data.... This is also because these errors have been placed in a baseline file which is not loaded anymore.

So my suggestion is to create an IgnoreErrorExtension as mentioned on phpstan.org/developing-extensions/ignore-error-extensions to suppress all errors that are not part of the rules that are specified in the rules section of config/phpstan-collection-data.neon.

I have not checked out how and if this will work in the project.
For now I have just edited the config/phpstan-collection-data.neon in my vendor folder to suppress the errors that are not needed for Argtyper.

Hope I made it a bit more clear.

[TomasVotruba]

So my suggestion is to create an IgnoreErrorExtension as mentioned on phpstan.org/developing-extensions/ignore-error-extensions to suppress all errors that are not part of the rules that are specified in the rules section of config/phpstan-collection-data.neon.

I see. Thanks for clarifying 👍

If you add the extension locally in your project and ignore those unwanted error, does it fix the issue for you? If so, please send it here and let's ignore all but argtyper.* errors

[alleknalle]

I will see if I got some time to check it out somewhere in the upcoming weeks 👍

[alleknalle]

See #4