Java settings don't need to be sent with all telemetry events

[fbricon]

Java settings don't need to be sent with all telemetry events, but they are:

vscode-java/src/telemetry.ts

Line 49 in 30cbd5b

properties: { ...data, ...javaSettings }

Does this make sense, from a typescript POV?

const javaSettings = getNonDefaultJavaSettings(workspace.getConfiguration());

let properties: any;
if (eventName === STARTUP_EVT) {
	serverInitializedReceived = true;
	properties= { ...data, ...javaSettings };
} else {
	properties= { ...data};
}

return telemetryManager.send({
	name: eventName,
	properties
});