Button component is setting props as HTML attributes

[barelyfitz]

I noticed in one of our implementations using the Button component, the element on the page looks like this:

<button themed="[object Object]" 

Could this be caused because the Button component renders the node and passes through all the props? Perhaps this needs to be refactored.

https://github.com/rentpath/react-ui/blob/master/packages/react-ui-core/src/Button/Button.js#L37

[tadjohnston]

The pass through of spread props is intentional. A better question would be why a themed prop is being passed to the component. That looks like a typo to me.

[barelyfitz]

Thanks - I'll take a look at it from my end and see if there is something coded wrong. Seems like it might be related to the @themed decorator but I'll investigate.

[tadjohnston]

@barelyfitz let me know how it goes.