treat signature help as a stable feature

Author: zth

CHANGELOG.md

@@ -16,6 +16,10 @@
 
 - Enable completion for `Js.Exn.Error(error)` when pattern matching on `exn`. This is to make the `Js.Exn.Error` API more discoverable. https://github.com/rescript-lang/rescript-vscode/pull/728
 
+#### :nail_care: Polish
+
+- Signature Help is now considered stable, and enabled for all users. Can still be turned off in settings.
+
 ## 1.12.0
 
 #### :rocket: New Feature

README.md

@@ -104,7 +104,7 @@ You'll find all ReScript specific settings under the scope `rescript.settings`.
 | ReScript Platform Path         | The extension will look for the existence of a `node_modules/rescript` directory and use the subdirectory corresponding to the current platform as the `platformPath`. If it does not find it at the project root (which is where the nearest `bsconfig.json` resides), it goes up folders in the filesystem recursively until it either finds it (often the case in monorepos) or hits the top level. To override this lookup process, the path can be configured explicitly using the setting `rescript.settings.platformPath` |
 | Inlay Hints (experimental)     | This allows an editor to place annotations inline with text to display type hints. Enable using `rescript.settings.inlayHints.enable: true`                                                                                                                                                                                                                                                                                                                                                                                      |
 | Code Lens (experimental)       | This tells the editor to add code lenses to function definitions, showing its full type above the definition. Enable using `rescript.settings.codeLens: true`                                                                                                                                                                                                                                                                                                                                                                    |
-| Signature Help (experimental)  | This tells the editor to show signature help when you're writing function calls. Enable using `rescript.settings.signatureHelp.enable: true`                                                                                                                                                                                                                                                                                                                                                                                     |
+| Signature Help                 | This tells the editor to show signature help when you're writing function calls. Enable using `rescript.settings.signatureHelp.enable: true`                                                                                                                                                                                                                                                                                                                                                                                     |
 | Autostarting the Code Analyzer | The Code Analyzer needs to be started manually by default. However, you can configure the extension to start the Code Analyzer automatically via the setting `rescript.settings.autoRunCodeAnalysis`.                                                                                                                                                                                                                                                                                                                            |
 
 **Default settings:**

package.json

@@ -158,10 +158,10 @@
 					"default": false,
 					"description": "Enable (experimental) code lens for function definitions."
 				},
-				"rescript.settings.signatureHelp.enable": {
+				"rescript.settings.signatureHelp.enabled": {
 					"type": "boolean",
-					"default": false,
-					"description": "Enable (experimental) signature help for function calls."
+					"default": true,
+					"description": "Enable signature help for function calls."
 				},
 				"rescript.settings.binaryPath": {
 					"type": ["string", "null"],

server/src/server.ts

@@ -37,7 +37,7 @@ interface extensionConfiguration {
   binaryPath: string | null;
   platformPath: string | null;
   signatureHelp: {
-    enable: boolean;
+    enabled: boolean;
   };
 }
 
@@ -63,7 +63,7 @@ let extensionConfiguration: extensionConfiguration = {
   binaryPath: null,
   platformPath: null,
   signatureHelp: {
-    enable: false,
+    enabled: true,
   },
 };
 // Below here is some state that's not important exactly how long it lives.
@@ -1145,7 +1145,7 @@ function onMessage(msg: p.Message) {
                 workDoneProgress: false,
               }
             : undefined,
-          signatureHelpProvider: extensionConfiguration.signatureHelp?.enable
+          signatureHelpProvider: extensionConfiguration.signatureHelp?.enabled
             ? {
                 triggerCharacters: ["("],
                 retriggerCharacters: ["=", ","],