Put cursor after pattern on field completion (#857)

* put cursor after pattern

* changelog

Author: zth

CHANGELOG.md

@@ -12,6 +12,10 @@
 
 ## master
 
+#### :nail_care: Polish
+
+- Change end position of cursor when completing `Some(<fieldName>)` in patterns. https://github.com/rescript-lang/rescript-vscode/pull/857
+
 ## 1.28.0
 
 #### :bug: Bug Fix

analysis/src/CompletionBackEnd.ml

@@ -1275,7 +1275,7 @@ let rec completeTypedValue ~full ~prefix ~completionContext ~mode
           Completion.createWithSnippet
             ~name:("Some(" ^ fieldName ^ ")")
             ~kind:(kindFromInnerType t) ~env
-            ~insertText:("Some(${1:" ^ fieldName ^ "})")
+            ~insertText:("Some(" ^ fieldName ^ ")$0")
             ();
           someAnyCase;
           noneCase;

analysis/tests/src/expected/CompletionExpressions.res.txt

@@ -196,7 +196,7 @@ Path fnTakingRecord
     "tags": [],
     "detail": "otherRecord",
     "documentation": null,
-    "insertText": "Some(${1:nested})",
+    "insertText": "Some(nested)$0",
     "insertTextFormat": 2
   }, {
     "label": "Some(_)",
@@ -616,7 +616,7 @@ Path fnTakingRecordWithOptVariant
     "tags": [],
     "detail": "someVariant",
     "documentation": null,
-    "insertText": "Some(${1:someVariant})",
+    "insertText": "Some(someVariant)$0",
     "insertTextFormat": 2
   }, {
     "label": "Some(_)",