propagate deprecated for constructors

Author: zth

analysis/src/CompletionBackEnd.ml

@@ -108,6 +108,7 @@ let completionsForExportedConstructors ~(env : QueryEnv.t) ~prefix ~exact
                    let () = Hashtbl.add namesUsed name () in
                    Some
                      (Completion.create name ~env ~docstring:c.docstring
+                        ?deprecated:c.deprecated
                         ~kind:
                           (Completion.Constructor
                              (c, t.item.decl |> Shared.declToString t.name.txt)))
@@ -1073,7 +1074,7 @@ let rec completeTypedValue ~full ~prefix ~completionContext ~mode
              | InlineRecord _ -> 1
              | Args args -> List.length args
            in
-           Completion.createWithSnippet
+           Completion.createWithSnippet ?deprecated:constructor.deprecated
              ~name:
                (constructor.cname.txt
                ^ printConstructorArgs numArgs ~asSnippet:false)

analysis/src/ProcessCmt.ml

@@ -100,6 +100,9 @@ let rec forTypeSignatureItem ~(env : SharedTypes.Env.t) ~(exported : Exported.t)
                              res = cd_res;
                              typeDecl = (name, decl);
                              docstring = attrsToDocstring cd_attributes;
+                             deprecated =
+                               ProcessAttributes.findDeprecatedAttribute
+                                 cd_attributes;
                            }
                          in
                          let declared =
@@ -201,6 +204,9 @@ let forTypeDeclaration ~env ~(exported : Exported.t)
                          {
                            Constructor.stamp;
                            cname;
+                           deprecated =
+                             ProcessAttributes.findDeprecatedAttribute
+                               cd_attributes;
                            args =
                              (match cd_args with
                              | Cstr_tuple args ->

analysis/src/SharedTypes.ml

@@ -47,6 +47,7 @@ module Constructor = struct
     res: Types.type_expr option;
     typeDecl: string * Types.type_declaration;
     docstring: string list;
+    deprecated: string option;
   }
 end
 
@@ -368,12 +369,12 @@ module Completion = struct
       detail;
     }
 
-  let createWithSnippet ~name ?insertText ~kind ~env ?sortText ?filterText
-      ?(docstring = []) () =
+  let createWithSnippet ~name ?insertText ~kind ~env ?sortText ?deprecated
+      ?filterText ?(docstring = []) () =
     {
       name;
       env;
-      deprecated = None;
+      deprecated;
       docstring;
       kind;
       sortText;

analysis/tests/src/Completion.res

@@ -440,5 +440,13 @@ let rWithDepr: someRecordWithDeprecatedField = {
   someFloat: 12.,
 }
 
+// Should show deprecated status
 // rWithDepr.so
 //             ^com
+
+type someVariantWithDeprecated =
+  | @deprecated DoNotUseMe | UseMeInstead | @deprecated("Use 'UseMeInstead'") AndNotMe
+
+// Should show deprecated status
+// let v: someVariantWithDeprecated =
+//                                   ^com

analysis/tests/src/expected/Completion.res.txt

@@ -1625,8 +1625,8 @@ Resolved opens 2 Completion.res Completion.res
   }]
 
 Complete src/Completion.res 405:22
-posCursor:[405:22] posNoWhite:[405:21] Found expr:[405:11->445:0]
-Pexp_apply ...__ghost__[0:-1->0:-1] (...[405:11->423:17], ...[428:0->445:0])
+posCursor:[405:22] posNoWhite:[405:21] Found expr:[405:11->453:0]
+Pexp_apply ...__ghost__[0:-1->0:-1] (...[405:11->423:17], ...[428:0->453:0])
 posCursor:[405:22] posNoWhite:[405:21] Found expr:[405:11->423:17]
 Pexp_apply ...__ghost__[0:-1->0:-1] (...[405:11->405:19], ...[405:21->423:17])
 posCursor:[405:22] posNoWhite:[405:21] Found expr:[405:21->423:17]
@@ -1759,9 +1759,9 @@ Resolved opens 2 Completion.res Completion.res
     "documentation": {"kind": "markdown", "value": "\n  `getWithDefault(res, defaultValue)`: If `res` is `Ok(n)`, returns `n`,\n  otherwise `default`\n\n  ```res example\n  Belt.Result.getWithDefault(Ok(42), 0) == 42\n\n  Belt.Result.getWithDefault(Error(\"Invalid Data\"), 0) == 0\n  ```\n"}
   }]
 
-Complete src/Completion.res 442:15
-posCursor:[442:15] posNoWhite:[442:14] Found expr:[442:3->442:15]
-Pexp_field [442:3->442:12] so:[442:13->442:15]
+Complete src/Completion.res 443:15
+posCursor:[443:15] posNoWhite:[443:14] Found expr:[443:3->443:15]
+Pexp_field [443:3->443:12] so:[443:13->443:15]
 Completable: Cpath Value[rWithDepr].so
 Raw opens: 2 Shadow.B.place holder ... Shadow.A.place holder
 Resolved opens 2 Completion.res Completion.res
@@ -1779,3 +1779,34 @@ Resolved opens 2 Completion.res Completion.res
     "documentation": {"kind": "markdown", "value": "Deprecated: Use 'someInt'.\n\n"}
   }]
 
+Complete src/Completion.res 450:37
+XXX Not found!
+Completable: Cexpression Type[someVariantWithDeprecated]
+Raw opens: 2 Shadow.B.place holder ... Shadow.A.place holder
+Resolved opens 2 Completion.res Completion.res
+[{
+    "label": "DoNotUseMe",
+    "kind": 4,
+    "tags": [1],
+    "detail": "DoNotUseMe\n\ntype someVariantWithDeprecated =\n  | DoNotUseMe\n  | UseMeInstead\n  | AndNotMe",
+    "documentation": {"kind": "markdown", "value": "Deprecated: \n\n"},
+    "insertText": "DoNotUseMe",
+    "insertTextFormat": 2
+  }, {
+    "label": "UseMeInstead",
+    "kind": 4,
+    "tags": [],
+    "detail": "UseMeInstead\n\ntype someVariantWithDeprecated =\n  | DoNotUseMe\n  | UseMeInstead\n  | AndNotMe",
+    "documentation": null,
+    "insertText": "UseMeInstead",
+    "insertTextFormat": 2
+  }, {
+    "label": "AndNotMe",
+    "kind": 4,
+    "tags": [1],
+    "detail": "AndNotMe\n\ntype someVariantWithDeprecated =\n  | DoNotUseMe\n  | UseMeInstead\n  | AndNotMe",
+    "documentation": {"kind": "markdown", "value": "Deprecated: Use 'UseMeInstead'\n\n"},
+    "insertText": "AndNotMe",
+    "insertTextFormat": 2
+  }]
+