Forgot to reactivate windows CI test (#192)

GitHub Action checks out code on windows on CRLF. This PR tried many methods of just using CRLF or converting to LF.

Tips:
- `print_endline` and multiline strings on windows ocaml fork use CRLF. `open_in_bin` + `really_input_string` too (!)
- `dos2unix` hangs when used inside `test.sh` but doesn't hang inside `ci.yml`.
- `cat` and `pipe` don't change line ending.
- use `cat -A` to check for line endings visibly. Life saving debugger.
- `sed "s/\r\n/\n/g"` apparently doesn't work on CI windows...
- `git checkout` + `ocaml-env` bug (?) fdopen/opam-repository-mingw#92

Whichever method of directly using CRLF doesn't work because of the last issue; it's likely that I'm being dumb...
So right now we set git to checkout using LF, let our native code output to CRLF, then instead of `dos2unix` or `sed`, use a perl one-liner in `test.sh` to convert those back into LF for comparison.

Author: chenglou

.github/workflows/ci.yml

@@ -22,16 +22,18 @@ jobs:
             build: eval $(opam env) && cd analysis && make test
             artifact-folder: linux
           - os: windows-latest
-            build: |
-              cd analysis
-              # git checkout converted these to windows newline. Convert back to unix newline here
-              dos2unix test.sh tests/src/*.res tests/src/*.resi
-              & $env:CYGWIN_ROOT\\bin\\ocaml-env exec -- make
+            build: "cd analysis && & $env:CYGWIN_ROOT\\bin\\ocaml-env exec -- make test"
             artifact-folder: win32
 
     runs-on: ${{matrix.os}}
 
     steps:
+    # needed for Windows testing
+    - name: Set git to use LF
+      run: |
+        git config --global core.autocrlf false
+        git config --global core.eol lf
+
     - uses: actions/checkout@v2.3.4
 
     - name: Cache OCaml's opam

analysis/test.sh

@@ -1,9 +1,10 @@
-function exp {
-  echo "$(dirname $1)/expected/$(basename $1).txt"
-}
-
 for file in tests/src/*.{res,resi}; do
-  ./rescript-editor-analysis.exe test $file &> $(exp $file)
+  output="$(dirname $file)/expected/$(basename $file).txt"
+  ./rescript-editor-analysis.exe test $file &> $output
+  # CI. We use LF, and the CI OCaml fork prints CRLF. Convert.
+  if [ "$RUNNER_OS" == "Windows" ]; then
+    perl -pi -e 's/\r\n/\n/g' -- $output
+  fi
 done
 
 warningYellow='\033[0;33m'