Fix pipe completion across files.

Author: cristianoc

analysis/src/CompletionBackEnd.ml

@@ -927,6 +927,9 @@ and getCompletionsForContextPath ~debug ~full ~opens ~rawOpens ~allFiles ~pos
               if pathFromEnv = [] then None
               else if
                 env.file.moduleName <> envFromCompletionItem.file.moduleName
+                && found
+                (* If the module names are different, then one needs to qualify the path.
+                   But only if the path belongs to the env from completion *)
               then Some (envFromCompletionItem.file.moduleName :: pathFromEnv)
               else Some pathFromEnv
             | _ -> None)

analysis/tests/src/expected/CompletionInferValues.res.txt

@@ -799,6 +799,18 @@ Path CompletionSupport2.makeRenderer
 CPPipe env:CompletionInferValues envFromCompletionItem:CompletionSupport2.Internal
 CPPipe type path:ReactDOM.Client.Root.t
 CPPipe pathFromEnv:ReactDOM.Client.Root found:false
-Path CompletionSupport2.ReactDOM.Client.Root.
-[]
+Path ReactDOM.Client.Root.
+[{
+    "label": "ReactDOM.Client.Root.unmount",
+    "kind": 12,
+    "tags": [],
+    "detail": "(t, unit) => unit",
+    "documentation": null
+  }, {
+    "label": "ReactDOM.Client.Root.render",
+    "kind": 12,
+    "tags": [],
+    "detail": "(t, React.element) => unit",
+    "documentation": null
+  }]
 

analysis/tests/src/expected/CompletionPipeChain.res.txt

@@ -424,8 +424,14 @@ Path props
 CPPipe env:CompletionPipeChain envFromCompletionItem:CompletionSupport.Nested
 CPPipe type path:ReactDOM.Client.Root.t
 CPPipe pathFromEnv:ReactDOM.Client.Root found:false
-Path CompletionSupport.ReactDOM.Client.Root.ren
-[]
+Path ReactDOM.Client.Root.ren
+[{
+    "label": "ReactDOM.Client.Root.render",
+    "kind": 12,
+    "tags": [],
+    "detail": "(t, React.element) => unit",
+    "documentation": null
+  }]
 
 Complete src/CompletionPipeChain.res 88:16
 posCursor:[88:16] posNoWhite:[88:15] Found expr:[76:15->93:1]