missed traversing switch expr when no cases

Author: zth

analysis/src/CompletionFrontEnd.ml

@@ -780,8 +780,7 @@ let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor ~text =
     in
     typedCompletionExpr expr;
     match expr.pexp_desc with
-    | Pexp_match (_expr, []) -> ()
-    | Pexp_match (expr, cases) ->
+    | Pexp_match (expr, cases) when cases <> [] ->
       let ctxPath = exprToContextPath expr in
       let oldCtxPath = !currentCtxPath in
       cases

analysis/tests/src/expected/CompletionFunctionArguments.res.txt

@@ -57,8 +57,23 @@ Complete src/CompletionFunctionArguments.res 21:27
 posCursor:[21:27] posNoWhite:[21:26] Found expr:[19:8->25:1]
 Pexp_apply ...[19:8->19:14] (~isOn20:3->20:7=...[21:7->23:8])
 posCursor:[21:27] posNoWhite:[21:26] Found expr:[21:7->23:8]
-posCursor:[21:27] posNoWhite:[21:26] Found expr:[21:7->23:8]
-[]
+posCursor:[21:27] posNoWhite:[21:26] Found expr:[21:7->21:28]
+posCursor:[21:27] posNoWhite:[21:26] Found expr:[21:14->21:28]
+Pexp_apply ...[21:14->21:20] (~isOn21:22->21:26=...__ghost__[0:-1->0:-1])
+Completable: Cexpression CArgument Value[someFn](~isOn)
+[{
+    "label": "true",
+    "kind": 4,
+    "tags": [],
+    "detail": "bool",
+    "documentation": null
+  }, {
+    "label": "false",
+    "kind": 4,
+    "tags": [],
+    "detail": "bool",
+    "documentation": null
+  }]
 
 Complete src/CompletionFunctionArguments.res 34:24
 posCursor:[34:24] posNoWhite:[34:23] Found expr:[34:11->34:25]

analysis/tests/src/expected/CompletionPattern.res.txt

@@ -1,5 +1,5 @@
 Complete src/CompletionPattern.res 7:13
-XXX Not found!
+posCursor:[7:13] posNoWhite:[7:12] Found expr:[7:3->7:13]
 []
 
 Complete src/CompletionPattern.res 10:15