Fix error handling when rescript.json parsing fails #8067
Merged
+132
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
fix-experimental-panic
branch
from
a15116a to
0fe97c6
Compare
cknitt
commented
Dec 7, 2025
| let mut build_state: build::build_types::BuildCommandState = | ||
| build::initialize_build(None, filter, show_progress, path, plain_output, warn_error) | ||
| .expect("Can't initialize build"); | ||
| .with_context(|| "Could not initialize build")?; |
Member
Author
There was a problem hiding this comment.
Message changed for consistency with the build command and other error messages.
cknitt
force-pushed
the
fix-experimental-panic
branch
from
0fe97c6 to
c2184c0
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8034, and also makes sure that the error message is helpful to the user (pointing to the error location).
I.e., instead of a panic with
we'll now get a clean exit with