Over-restrictive regex for function definitions?

[mekhami]

In the regex for function definitions (specifically looked at arrow functions but could also apply to others, didn't look):

--regex-javascript=/^[ \t]*var[ \t]\{1,\}\([a-z_$][A-Za-z0-9_$]\{1,\}\)[ \t]*=.\{1,\}=>/\1/F,Function,Functions/b
--regex-javascript=/^[ \t]*let[ \t]\{1,\}\([a-z_$][A-Za-z0-9_$]\{1,\}\)[ \t]*=.\{1,\}=>/\1/F,Function,Functions/b
--regex-javascript=/^[ \t]*const[ \t]\{1,\}\([a-z_$][A-Za-z0-9_$]\{1,\}\)[ \t]*=.\{1,\}=>/\1/F,Function,Functions/b

Why does the first character of the function need to be lower cased? I specifically have a React component definition:

const MyModal = ({ prop1, prop2 }) => {

}

export default MyModal

This definition is skipped because of the capital case component function name.

[romainl]

I know. I have a local fix for that but it is not complete and fully tested so I've been sitting on it for a while. Thank you for reminding me!

[romainl]

@mekhami, the last commit should fix the issue.

FWIW: old school constructor-based "class" definitions are indistinguishable from plain function definition except for the convention of starting the name with an uppercase character. That's what lead me to that short-sighted casing restriction. Now, old school "class" definitions are just considered as functions.