From f37935d3dec364b2fbae610cb89f7fa1e03f189b Mon Sep 17 00:00:00 2001 From: Yasuo Honda Date: Wed, 13 May 2026 10:51:25 +0900 Subject: [PATCH] Drop redundant require "spec_helper" from spec files The project-level .rspec (added in #294) sets `--require spec_helper`, so each spec file's explicit `require "spec_helper"` is now redundant. Remove the require line and the trailing blank line from all 11 spec files under spec/plsql/. Net change: -22 LOC. No behavior change. Full suite is green (468 examples, 0 failures, 1 pre-existing pending). Co-Authored-By: Claude Opus 4.7 (1M context) --- spec/plsql/connection_spec.rb | 2 -- spec/plsql/package_spec.rb | 2 -- spec/plsql/procedure_spec.rb | 2 -- spec/plsql/schema_spec.rb | 2 -- spec/plsql/sequence_spec.rb | 2 -- spec/plsql/sql_statements_spec.rb | 2 -- spec/plsql/table_spec.rb | 2 -- spec/plsql/type_spec.rb | 2 -- spec/plsql/variable_spec.rb | 2 -- spec/plsql/version_spec.rb | 2 -- spec/plsql/view_spec.rb | 2 -- 11 files changed, 22 deletions(-) diff --git a/spec/plsql/connection_spec.rb b/spec/plsql/connection_spec.rb index c6f2e53..3ddb754 100644 --- a/spec/plsql/connection_spec.rb +++ b/spec/plsql/connection_spec.rb @@ -1,7 +1,5 @@ # encoding: utf-8 -require "spec_helper" - RSpec.describe "Connection" do before(:all) do diff --git a/spec/plsql/package_spec.rb b/spec/plsql/package_spec.rb index 71e0978..d3853f1 100644 --- a/spec/plsql/package_spec.rb +++ b/spec/plsql/package_spec.rb @@ -1,5 +1,3 @@ -require "spec_helper" - RSpec.describe "Package" do before(:all) do plsql.connection = get_connection diff --git a/spec/plsql/procedure_spec.rb b/spec/plsql/procedure_spec.rb index 9951d58..06cdeb6 100644 --- a/spec/plsql/procedure_spec.rb +++ b/spec/plsql/procedure_spec.rb @@ -1,7 +1,5 @@ # encoding: utf-8 -require "spec_helper" - RSpec.describe "Parameter type mapping /" do shared_examples "Function with string parameters" do |datatype| diff --git a/spec/plsql/schema_spec.rb b/spec/plsql/schema_spec.rb index 5df95a4..9d177a9 100644 --- a/spec/plsql/schema_spec.rb +++ b/spec/plsql/schema_spec.rb @@ -1,5 +1,3 @@ -require "spec_helper" - RSpec.describe "Schema" do it "should create Schema object" do diff --git a/spec/plsql/sequence_spec.rb b/spec/plsql/sequence_spec.rb index 9702e16..bfc9443 100644 --- a/spec/plsql/sequence_spec.rb +++ b/spec/plsql/sequence_spec.rb @@ -1,5 +1,3 @@ -require "spec_helper" - RSpec.describe "Table" do before(:all) do plsql.connection = get_connection diff --git a/spec/plsql/sql_statements_spec.rb b/spec/plsql/sql_statements_spec.rb index d5fd49d..d30a910 100644 --- a/spec/plsql/sql_statements_spec.rb +++ b/spec/plsql/sql_statements_spec.rb @@ -1,5 +1,3 @@ -require "spec_helper" - RSpec.describe "SQL statements /" do before(:all) do plsql.connect! CONNECTION_PARAMS diff --git a/spec/plsql/table_spec.rb b/spec/plsql/table_spec.rb index da636f5..9847bcc 100644 --- a/spec/plsql/table_spec.rb +++ b/spec/plsql/table_spec.rb @@ -1,5 +1,3 @@ -require "spec_helper" - RSpec.describe "Table" do before(:all) do plsql.connect! CONNECTION_PARAMS diff --git a/spec/plsql/type_spec.rb b/spec/plsql/type_spec.rb index b837371..acfb2c3 100644 --- a/spec/plsql/type_spec.rb +++ b/spec/plsql/type_spec.rb @@ -1,5 +1,3 @@ -require "spec_helper" - RSpec.describe "Type" do before(:all) do plsql.connection = get_connection diff --git a/spec/plsql/variable_spec.rb b/spec/plsql/variable_spec.rb index d4c6b46..8f57648 100644 --- a/spec/plsql/variable_spec.rb +++ b/spec/plsql/variable_spec.rb @@ -1,7 +1,5 @@ # encoding: utf-8 -require "spec_helper" - RSpec.describe "Package variables /" do describe "String" do diff --git a/spec/plsql/version_spec.rb b/spec/plsql/version_spec.rb index 476053e..d421e87 100644 --- a/spec/plsql/version_spec.rb +++ b/spec/plsql/version_spec.rb @@ -1,5 +1,3 @@ -require "spec_helper" - RSpec.describe "Version" do it "should return ruby-plsql version" do expect(PLSQL::VERSION).to eq(File.read(File.dirname(__FILE__) + "/../../VERSION").chomp) diff --git a/spec/plsql/view_spec.rb b/spec/plsql/view_spec.rb index dc40f42..47edefc 100644 --- a/spec/plsql/view_spec.rb +++ b/spec/plsql/view_spec.rb @@ -1,5 +1,3 @@ -require "spec_helper" - RSpec.describe "View" do before(:all) do plsql.connect! CONNECTION_PARAMS