From cd73027681f695dcdbb0e213cd5dd134df2bbea0 Mon Sep 17 00:00:00 2001 From: Yasuo Honda Date: Wed, 13 May 2026 11:00:08 +0900 Subject: [PATCH] Replace `if not value.nil?` with `unless value.nil?` Two adjacent `if not value.nil?` trailing modifiers in `add_argument`'s XMLTYPE branch used the awkward double negation form. Replace with `unless value.nil?` for idiomatic Ruby; same semantics, same line count. No behavior change. Full suite is green (468 examples, 0 failures, 1 pre-existing pending). Co-Authored-By: Claude Opus 4.7 (1M context) --- lib/plsql/procedure_call.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/plsql/procedure_call.rb b/lib/plsql/procedure_call.rb index e1624ff..f6824c7 100644 --- a/lib/plsql/procedure_call.rb +++ b/lib/plsql/procedure_call.rb @@ -243,8 +243,8 @@ def add_argument(argument, value, argument_metadata = nil) when "UNDEFINED", "XMLTYPE", "OPAQUE/XMLTYPE" if xmltype_argument?(argument_metadata) @declare_sql << "l_#{argument} XMLTYPE;\n" - @assignment_sql << "l_#{argument} := XMLTYPE(:#{argument});\n" if not value.nil? - @bind_values[argument] = value if not value.nil? + @assignment_sql << "l_#{argument} := XMLTYPE(:#{argument});\n" unless value.nil? + @bind_values[argument] = value unless value.nil? @bind_metadata[argument] = argument_metadata.merge(data_type: "CLOB") "l_#{argument}" end