evaluate_to should not rescue Exceptions

Author: pitr-ch

lib/concurrent/promises.rb

@@ -1284,7 +1284,7 @@ def evaluate_to(*args, &block)
       # @return [self]
       # @raise [Exception] also raise reason on rejection.
       def evaluate_to!(*args, &block)
-        promise.evaluate_to!(*args, block)
+        promise.evaluate_to(*args, block).wait!
       end
 
       # Creates new future wrapping receiver, effectively hiding the resolve method and similar.
@@ -1343,8 +1343,8 @@ def resolve_with(new_state, raise_on_reassign = true)
       def evaluate_to(*args, block)
         resolve_with Fulfilled.new(block.call(*args))
       rescue Exception => error
-        # TODO (pitr-ch 30-Jul-2016): figure out what should be rescued, there is an issue about it
         resolve_with Rejected.new(error)
+        raise error unless error.is_a?(StandardError)
       end
     end
 
@@ -1368,10 +1368,6 @@ def reject(reason, raise_on_reassign)
       end
 
       public :evaluate_to
-
-      def evaluate_to!(*args, block)
-        evaluate_to(*args, block).wait!
-      end
     end
 
     # @abstract

spec/concurrent/edge/promises_spec.rb

@@ -448,11 +448,17 @@ def behaves_as_delay(delay, value)
     end
 
     it 'resolves future when Exception raised' do
-      f = future { raise Exception, 'reject' }
-      f.wait 1
-      expect(f).to be_resolved
-      expect(f).to be_rejected
-      expect { f.value! }.to raise_error(Exception, 'reject')
+      message = 'reject by an Exception'
+      future  = future { raise Exception, message }
+      expect(future.wait(0.1)).to eq true
+      future.wait
+      expect(future).to be_resolved
+      expect(future).to be_rejected
+
+      expect(future.reason).to be_instance_of Exception
+      expect(future.result).to be_instance_of Array
+      expect(future.value).to be_nil
+      expect { future.value! }.to raise_error(Exception, message)
     end
 
     it 'runs' do