Support %a{implicitly-returns-nil} on MatchData#[]#2990
Open
ksss wants to merge 1 commit into
Open
Conversation
In the following case, even though the return value of `Regexp.last_match` cannot possibly be `nil`, the type still retains the possibility of being `nil`. ```rb when /\AArray<(?<inner_type>.+)>\z/ inner_type = Regexp.last_match[:inner_type] ``` Just like `Array#[]` and others, it would be more practical to make the possibility of `nil` implicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the following case, even though the return value of
Regexp.last_matchcannot possibly benil, the type still retains the possibility of beingnil.Just like
Array#[]and others, it would be more practical to make the possibility ofnilimplicit.