From e2f6866e2de9342b861512c9be54fb2412ee6678 Mon Sep 17 00:00:00 2001 From: overtrue Date: Sat, 28 Mar 2026 23:06:28 +0800 Subject: [PATCH 1/2] test(event): cover shorthand normalization dedup --- crates/cli/src/commands/event.rs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/crates/cli/src/commands/event.rs b/crates/cli/src/commands/event.rs index 28f706a..aecf3ba 100644 --- a/crates/cli/src/commands/event.rs +++ b/crates/cli/src/commands/event.rs @@ -474,6 +474,17 @@ mod tests { ); } + #[test] + fn test_parse_event_list_deduplicates_shorthand_against_canonical_name() { + let events = parse_event_list(&[ + "put".to_string(), + "s3:ObjectCreated:*".to_string(), + "PUT".to_string(), + ]); + + assert_eq!(events, vec!["s3:ObjectCreated:*".to_string()]); + } + #[test] fn test_infer_target_from_arn() { assert_eq!( From d7643a4cb6419a25ce9618708134c511957638c7 Mon Sep 17 00:00:00 2001 From: overtrue Date: Sun, 29 Mar 2026 03:06:13 +0800 Subject: [PATCH 2/2] test(event): expand shorthand normalization dedup coverage --- crates/cli/src/commands/event.rs | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/crates/cli/src/commands/event.rs b/crates/cli/src/commands/event.rs index aecf3ba..ddd553b 100644 --- a/crates/cli/src/commands/event.rs +++ b/crates/cli/src/commands/event.rs @@ -475,14 +475,21 @@ mod tests { } #[test] - fn test_parse_event_list_deduplicates_shorthand_against_canonical_name() { + fn test_parse_event_list_deduplicates_shorthand_and_canonical_names() { let events = parse_event_list(&[ - "put".to_string(), - "s3:ObjectCreated:*".to_string(), - "PUT".to_string(), + "put,s3:ObjectCreated:*".to_string(), + "GET,s3:ObjectAccessed:*".to_string(), + "delete,s3:ObjectRemoved:*".to_string(), ]); - assert_eq!(events, vec!["s3:ObjectCreated:*".to_string()]); + assert_eq!( + events, + vec![ + "s3:ObjectAccessed:*".to_string(), + "s3:ObjectCreated:*".to_string(), + "s3:ObjectRemoved:*".to_string(), + ] + ); } #[test]