Skip to content

Commit fee503e

Browse files
authored
Merge pull request #1887 from sap-tutorials/worktree-fix-srv-qa-route-drift-images
fix(ci): allowlist dark-launched image routes in srv-qa route-drift guard
2 parents a5b8925 + 8305797 commit fee503e

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

scripts/check-srv-qa-route-drift.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,21 @@ const ALLOWLIST_ONLY_ON_SRV: Record<string, string> = {
114114
'author-page and concept-page entries: the QA channel serves in-flight tutorials from ' +
115115
'-Contribution repos; advocate pages are out of its scope, and srv-qa wires no ' +
116116
'advocateServeHandler / advocate publish flow.',
117+
'GET /content/image-source':
118+
'Persist-tutorial-images (#1868/#1869/#1870) — streams stored image originals so the ' +
119+
'approuter can proxy raw-GitHub image URLs. DARK-LAUNCHED: no approuter route points at ' +
120+
'this endpoint on EITHER channel yet (served HTML still emits raw.githubusercontent.com ' +
121+
'URLs via scripts/parsers/images.ts), and the QA approuter wires no image-proxy route. ' +
122+
'Mirroring now would pull image-store/image-ingest deps into the srv-qa cp list for an ' +
123+
'unreachable surface. Re-evaluate QA parity when the image proxy goes live and gains an ' +
124+
'approuter route.',
125+
'POST /content/image':
126+
'Persist-tutorial-images bytes-in ingest (#1884) — the backfill script (scripts/' +
127+
'backfill-images.ts) and CI POST raw image bytes here so the srv never fetches GitHub ' +
128+
'itself. CI-only prod content maintenance, same rationale as POST /content/orphan-purge: ' +
129+
'not an author-preview endpoint. The QA publish flow (publish-content.ts --channel qa) ' +
130+
'never POSTs images, and srv-qa GET image-source self-heals via ingestImage directly ' +
131+
'without this route. Re-evaluate if QA gains an image backfill flow.',
117132
};
118133

119134
/**

0 commit comments

Comments
 (0)