Skip to content

Commit 3202163

Browse files
ctruedenclaude
andcommitted
Do not claim to fetch Java before knowing it will
resolve_java logged "Fetching zulu-jre:11..." at info level, even when jgo's JavaLocator then went on to use a suitable system Java. Log the request at debug level instead; jgo reports what is actually used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent a1be8d1 commit 3202163

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎src/scyjava/_jdk_fetch.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,12 @@ def resolve_java(vendor: str | None = None, version: str | None = None) -> None:
3232
if version is None:
3333
version = scyjava.config.get_java_version()
3434

35-
_logger.info(f"Fetching {vendor}:{version}...")
36-
3735
fetch = scyjava.config.get_fetch_java()
3836

37+
# Note: Whether Java gets downloaded is up to jgo's JavaLocator, which
38+
# logs what it actually ends up using.
39+
_logger.debug(f"Resolving Java {vendor}:{version} (fetch mode: {fetch})")
40+
3941
# Map scyjava fetch mode to jgo JavaSource strategy.
4042
# "always" -> DOWNLOAD: always use cjdk-managed Java, ignoring system Java.
4143
# "never" -> SYSTEM: always use system Java, never downloading via cjdk.

0 commit comments

Comments
 (0)