Skip to content

Commit 80e0731

Browse files
committed
build: Install just from apt in the devcontainer
The base image resolves to Debian trixie, which packages just, so drop the install script and version pin in favor of apt.
1 parent 5d89357 commit 80e0731

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

.devcontainer/Dockerfile

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ FROM mcr.microsoft.com/vscode/devcontainers/python:${VARIANT}
55
ARG NODE_VERSION="24"
66
ARG POETRY_VERSION="1.8.2"
77
ARG POETRY_SRC="https://install.python-poetry.org"
8-
ARG JUST_VERSION="1.57.0"
9-
ARG JUST_SRC="https://just.systems/install.sh"
108

119
# https://github.com/microsoft/vscode-dev-containers/blob/main/containers/go/.devcontainer/base.Dockerfile
1210
ENV USERNAME=vscode
@@ -20,16 +18,17 @@ RUN bash /tmp/library-scripts/node-debian.sh "${NVM_DIR}" "${NODE_VERSION}" "${U
2018
&& apt-get clean -y && rm -rf /var/lib/apt/lists/* \
2119
&& rm -rf /tmp/library-scripts
2220

21+
RUN apt-get update -y \
22+
&& apt-get install -y --no-install-recommends just \
23+
&& apt-get clean -y && rm -rf /var/lib/apt/lists/*
24+
2325
USER vscode
2426
WORKDIR /home/vscode
2527

2628
RUN curl -fsSL -o install-poetry.py "${POETRY_SRC}" \
2729
&& python install-poetry.py --version $POETRY_VERSION \
2830
&& rm install-poetry.py
2931

30-
RUN mkdir -p .local/bin \
31-
&& curl -fsSL "${JUST_SRC}" | bash -s -- --tag "${JUST_VERSION}" --to /home/vscode/.local/bin
32-
3332
RUN mkdir -p .config/git \
3433
&& echo ".vscode/*" >> .config/git/ignore \
3534
&& echo "*.code-workspace" >> .config/git/ignore \

.devcontainer/devcontainer.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"build": {
55
"dockerfile": "Dockerfile",
66
"args": {
7-
"JUST_VERSION": "1.57.0",
87
"NODE_VERSION": "24",
98
"POETRY_VERSION": "1.8.2",
109
"VARIANT": "3.12"

0 commit comments

Comments
 (0)