Skip to content

UIBarButtonItem with custom view using SimpleView crash #8

Description

@jjuliano

I add a UIButton to a UIBarButtonItem, the using the SimpleView button builder and the UI::UIButtonBuilder.new.build(..) crashed.

  1. This crashed
    @nav_add_button = UI::Layouts.setup(view) do
    button buttonType: UIButtonTypeCustom, width: 32, height: 32 do
    @view.setBackgroundImage(UIImage.imageNamed("normal.png"), forState:UIControlStateNormal)
    @view.setBackgroundImage(UIImage.imageNamed("clicked.png"), forState:UIControlStateHighlighted)
    @view.addTarget(self, action:'performAdd', forControlEvents:UIControlEventTouchUpInside)
    end
    end

    self.navigationItem.rightBarButtonItem = UIBarButtonItem.alloc.initWithCustomView(@nav_add_button)

  2. Crashed
    @nav_add_button = UI::UIButtonBuilder.new.build(UIButton, buttonType: UIButtonTypeCustom)
    @nav_add_button.setBackgroundImage(UIImage.imageNamed("normal.png"), forState:UIControlStateNormal)
    @nav_add_button.setBackgroundImage(UIImage.imageNamed("clicked.png"), forState:UIControlStateHighlighted)
    @nav_add_button.frame = [[0,0], [32, 32]]
    @nav_add_button.addTarget(self, action:'performAdd', forControlEvents:UIControlEventTouchUpInside)

    self.navigationItem.rightBarButtonItem = UIBarButtonItem.alloc.initWithCustomView(@nav_add_button)

  3. This works as expected

    @nav_add_button = UIButton.buttonWithType(UIButtonTypeCustom)
    @nav_add_button.setBackgroundImage(UIImage.imageNamed("normal.png"), forState:UIControlStateNormal)
    @nav_add_button.setBackgroundImage(UIImage.imageNamed("clicked.png"), forState:UIControlStateHighlighted)
    @nav_add_button.frame = [[0,0], [32, 32]]
    @nav_add_button.addTarget(self, action:'performAdd', forControlEvents:UIControlEventTouchUpInside)

    self.navigationItem.rightBarButtonItem = UIBarButtonItem.alloc.initWithCustomView(@nav_add_button)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions