fix: cli templates (#830)

* fix(cli-template-monorepo-ethers): update hook dependencies

* fix(cli-template-monorepo-subgraph): update hook dependencies

* docs: update template readme files

* Update packages/cli-template-contracts-hardhat/README.md

Co-authored-by: Cedoor <me@cedoor.dev>

* style: format code

* docs: update note text style

---------

Co-authored-by: Cedoor <me@cedoor.dev>

Author: vplasencia

packages/cli-template-contracts-hardhat/README.md

@@ -46,20 +46,17 @@ cp .env.example .env
 
 2. Add your environment variables.
 
-> **Note**  
+> [!NOTE]
 > You should at least set a valid Ethereum URL (e.g. Infura) and a private key with some ethers.
 
 3. And deploy your contract.
 
 ```bash
-yarn deploy --semaphore <semaphore-address> --group <group-id> --network sepolia
+yarn deploy --semaphore <semaphore-address> --network sepolia
 ```
 
-> **Note**  
-> Check the Semaphore contract addresses [here](https://docs.semaphore.pse.dev/deployed-contracts#semaphore).
-
-> **Warning**  
-> The group id is a number!
+> [!NOTE]
+> Check the Semaphore contract addresses [here](https://docs.semaphore.pse.dev/deployed-contracts).
 
 ### Code quality and formatting
 

packages/cli-template-monorepo-ethers/README.md

@@ -25,19 +25,16 @@ yarn dev
 1. Go to the `apps/contracts` directory and deploy your contract:
 
 ```bash
-yarn deploy --semaphore <semaphore-address> --group <group-id> --network arbitrum-sepolia
+yarn deploy --semaphore <semaphore-address> --network sepolia
 ```
 
-2. Update your `.env` file with your new contract address, the group id and the semaphore contract address.
+2. Update your `apps/web-app/.env.production` file with your new contract address and the group id.
 
 3. Copy your contract artifacts from `apps/contracts/artifacts/contracts/` folder to `apps/web-app/contract-artifacts` folder manually.
 
-> **Note**  
+> [!NOTE]
 > Check the Semaphore contract addresses [here](https://docs.semaphore.pse.dev/deployed-contracts).
 
-> **Warning**  
-> The group id is a number!
-
 ### Code quality and formatting
 
 Run [ESLint](https://eslint.org/) and [solhint](https://github.com/protofire/solhint) to analyze the code and catch bugs:

packages/cli-template-monorepo-ethers/apps/web-app/.env.production

@@ -1,5 +1,5 @@
 NEXT_PUBLIC_DEFAULT_NETWORK=sepolia
-NEXT_PUBLIC_FEEDBACK_CONTRACT_ADDRESS=0xC6446BB589E141fFACeaCd91953CbB0F2055C7e5
-NEXT_PUBLIC_SEMAPHORE_CONTRACT_ADDRESS=0x5B8e7cC7bAC61A4b952d472b67056B2f260ba6dc
+NEXT_PUBLIC_FEEDBACK_CONTRACT_ADDRESS=
+NEXT_PUBLIC_SEMAPHORE_CONTRACT_ADDRESS=0x1e0d7FF1610e480fC93BdEC510811ea2Ba6d7c2f
 NEXT_PUBLIC_OPENZEPPELIN_AUTOTASK_WEBHOOK=https://api.defender.openzeppelin.com/actions/20fce2ae-844b-4ec0-a6a2-90a3350a9d2c/runs/webhook/303216d1-fa7d-4fca-8c5b-7ba1ba544fc7/2T7i9xrkZA5j37hoaQLUuw
-NEXT_PUBLIC_GROUP_ID=9
+NEXT_PUBLIC_GROUP_ID=

packages/cli-template-monorepo-ethers/apps/web-app/src/app/groups/page.tsx

@@ -24,13 +24,13 @@ export default function GroupsPage() {
         }
 
         setIdentity(new Identity(privateKey))
-    }, [])
+    }, [router])
 
     useEffect(() => {
         if (_users.length > 0) {
             setLogs(`${_users.length} user${_users.length > 1 ? "s" : ""} retrieved from the group 🤙🏽`)
         }
-    }, [_users])
+    }, [_users, setLogs])
 
     const joinGroup = useCallback(async () => {
         if (!_identity) {
@@ -72,7 +72,7 @@ export default function GroupsPage() {
         }
 
         setLoading(false)
-    }, [_identity])
+    }, [_identity, addUser, setLogs])
 
     const userHasJoined = useCallback((identity: Identity) => _users.includes(identity.commitment.toString()), [_users])
 

packages/cli-template-monorepo-ethers/apps/web-app/src/app/page.tsx

@@ -23,7 +23,7 @@ export default function IdentitiesPage() {
         } else {
             setLogs("Create your Semaphore identity 👆🏽")
         }
-    }, [])
+    }, [setLogs])
 
     const createIdentity = useCallback(async () => {
         const identity = new Identity()
@@ -33,7 +33,7 @@ export default function IdentitiesPage() {
         localStorage.setItem("identity", identity.privateKey.toString())
 
         setLogs("Your new Semaphore identity has just been created 🎉")
-    }, [])
+    }, [setLogs])
 
     return (
         <>

packages/cli-template-monorepo-ethers/apps/web-app/src/app/proofs/page.tsx

@@ -24,13 +24,13 @@ export default function ProofsPage() {
         }
 
         setIdentity(new Identity(privateKey))
-    }, [])
+    }, [router])
 
     useEffect(() => {
         if (_feedback.length > 0) {
             setLogs(`${_feedback.length} feedback retrieved from the group 🤙🏽`)
         }
-    }, [_feedback])
+    }, [_feedback, setLogs])
 
     const sendFeedback = useCallback(async () => {
         if (!_identity) {
@@ -105,7 +105,7 @@ export default function ProofsPage() {
                 setLoading(false)
             }
         }
-    }, [_identity, _users])
+    }, [_identity, _users, addFeedback, setLogs])
 
     return (
         <>

packages/cli-template-monorepo-ethers/apps/web-app/src/components/PageContainer.tsx

@@ -21,7 +21,7 @@ export default function PageContainer({
     useEffect(() => {
         semaphore.refreshUsers()
         semaphore.refreshFeedback()
-    }, [])
+    }, [semaphore])
 
     function getExplorerLink(network: SupportedNetwork, address: string) {
         switch (network) {

packages/cli-template-monorepo-subgraph/README.md

@@ -25,19 +25,16 @@ yarn dev
 1. Go to the `apps/contracts` directory and deploy your contract:
 
 ```bash
-yarn deploy --semaphore <semaphore-address> --group <group-id> --network arbitrum-sepolia
+yarn deploy --semaphore <semaphore-address> --network sepolia
 ```
 
-2. Update your `.env` file with your new contract address, the group id and the semaphore contract address.
+2. Update your `apps/web-app/.env.production` file with your new contract address and the group id.
 
 3. Copy your contract artifacts from `apps/contracts/artifacts/contracts/` folder to `apps/web-app/contract-artifacts` folder manually.
 
-> **Note**  
+> [!NOTE]
 > Check the Semaphore contract addresses [here](https://docs.semaphore.pse.dev/deployed-contracts).
 
-> **Warning**  
-> The group id is a number!
-
 ### Code quality and formatting
 
 Run [ESLint](https://eslint.org/) and [solhint](https://github.com/protofire/solhint) to analyze the code and catch bugs:

packages/cli-template-monorepo-subgraph/apps/web-app/.env.production

@@ -1,5 +1,5 @@
 NEXT_PUBLIC_DEFAULT_NETWORK=sepolia
-NEXT_PUBLIC_FEEDBACK_CONTRACT_ADDRESS=0xC6446BB589E141fFACeaCd91953CbB0F2055C7e5
-NEXT_PUBLIC_SEMAPHORE_CONTRACT_ADDRESS=0x5B8e7cC7bAC61A4b952d472b67056B2f260ba6dc
+NEXT_PUBLIC_FEEDBACK_CONTRACT_ADDRESS=
+NEXT_PUBLIC_SEMAPHORE_CONTRACT_ADDRESS=0x1e0d7FF1610e480fC93BdEC510811ea2Ba6d7c2f
 NEXT_PUBLIC_OPENZEPPELIN_AUTOTASK_WEBHOOK=https://api.defender.openzeppelin.com/actions/20fce2ae-844b-4ec0-a6a2-90a3350a9d2c/runs/webhook/303216d1-fa7d-4fca-8c5b-7ba1ba544fc7/2T7i9xrkZA5j37hoaQLUuw
-NEXT_PUBLIC_GROUP_ID=9
+NEXT_PUBLIC_GROUP_ID=

packages/cli-template-monorepo-subgraph/apps/web-app/src/app/groups/page.tsx

@@ -24,13 +24,13 @@ export default function GroupsPage() {
         }
 
         setIdentity(new Identity(privateKey))
-    }, [])
+    }, [router])
 
     useEffect(() => {
         if (_users.length > 0) {
             setLogs(`${_users.length} user${_users.length > 1 ? "s" : ""} retrieved from the group 🤙🏽`)
         }
-    }, [_users])
+    }, [_users, setLogs])
 
     const joinGroup = useCallback(async () => {
         if (!_identity) {
@@ -72,7 +72,7 @@ export default function GroupsPage() {
         }
 
         setLoading(false)
-    }, [_identity])
+    }, [_identity, addUser, setLogs])
 
     const userHasJoined = useCallback((identity: Identity) => _users.includes(identity.commitment.toString()), [_users])