Unify Rubocop config

Author: alexeyr

.prettierignore

@@ -19,7 +19,6 @@ spec/dummy/public
 *.res.js
 
 # Prettier doesn't understand ERB syntax in YAML files and can damage templates
-.rubocop.yml
 *.yml
 *.yaml
 # Intentionally invalid

.rubocop.yml

@@ -0,0 +1,89 @@
+# Root RuboCop configuration for React on Rails monorepo
+# This contains shared settings inherited by react_on_rails/ and react_on_rails_pro/
+require:
+  - rubocop-performance
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable
+  DisplayCopNames: true
+  TargetRubyVersion: 3.0
+
+  Include:
+    - '**/Rakefile'
+    - '**/config.ru'
+    - 'Gemfile'
+    - '**/*.rb'
+    - '**/*.rake'
+
+  Exclude:
+    - '**/*.js'
+    - '**/node_modules/**/*'
+    - '**/public/**/*'
+    - '**/tmp/**/*'
+    - 'coverage/**/*'
+    - 'gen-examples/**/*'
+    - 'node_modules/**/*'
+    - 'spec/fixtures/**/*'
+    - 'spec/react_on_rails/dummy-for-generators/**/*'
+    - 'vendor/**/*'
+
+Naming/FileName:
+  Exclude:
+    - '**/Gemfile'
+    - '**/Rakefile'
+
+Layout/LineLength:
+  Max: 120
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/Documentation:
+  Enabled: false
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Metrics/AbcSize:
+  Max: 28
+
+Metrics/PerceivedComplexity:
+  Max: 10
+
+Metrics/ParameterLists:
+  Max: 5
+  CountKeywordArgs: false
+
+Metrics/MethodLength:
+  Max: 41
+
+Metrics/ModuleLength:
+  Max: 180
+
+RSpec/DescribeClass:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/MessageSpies:
+  Enabled: false
+
+RSpec/MessageChain:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 12
+
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: always

react_on_rails/.rubocop.yml

@@ -1,61 +1,18 @@
-# This is the configuration used to check the rubocop source code.
-# Check out: https://github.com/bbatsov/rubocop
-require:
-  - rubocop-performance
-  - rubocop-rspec
+# Inherits from root config
+inherit_from: ../.rubocop.yml
 
 AllCops:
-  NewCops: enable
-  DisplayCopNames: true
-  TargetRubyVersion: 3.0.0
   SuggestExtensions: false
 
-  Include:
-    - '**/Rakefile'
-    - '**/config.ru'
-    - 'Gemfile'
-    - '**/*.rb'
-    - '**/*.rake'
-
   Exclude:
-    - '**/*.js'
-    - '**/node_modules/**/*'
-    - '**/public/**/*'
-    - '**/tmp/**/*'
-    - 'coverage/**/*'
-    - 'gen-examples/examples/**/*'
-    - 'node_modules/**/*'
-    - '../react_on_rails_pro/**/*'  # Exclude pro package (has its own linting)
     - 'spec/dummy/bin/*'
-    - 'spec/fixtures/**/*'
-    - 'spec/react_on_rails/dummy-for-generators/**/*'
-    - 'tmp/**/*'
-    - 'vendor/**/*'
 
 Naming/FileName:
   Exclude:
     - '**/Gemfile*'
     - '**/Rakefile'
     - '**/Steepfile'
 
-Layout/LineLength:
-  Max: 120
-
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-Style/Documentation:
-  Enabled: false
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true
-
 Lint/AssignmentInCondition:
   Exclude:
     - 'spec/dummy/bin/spring'
@@ -66,33 +23,23 @@ Lint/SuppressedException:
     - 'spec/dummy/bin/rake'
 
 Metrics/AbcSize:
-  Max: 28
   Exclude:
     - 'lib/generators/react_on_rails/install_generator.rb'  # Generator setup methods require comprehensive error handling
 
 Metrics/CyclomaticComplexity:
   Max: 7
 
-Metrics/PerceivedComplexity:
-  Max: 10
-
 Metrics/ClassLength:
   Max: 150
   Exclude:
     - 'lib/generators/react_on_rails/base_generator.rb'  # Generator complexity justified
     - 'lib/react_on_rails/dev/server_manager.rb'  # Dev tool with comprehensive help system
 
-Metrics/ParameterLists:
-  Max: 5
-  CountKeywordArgs: false
-
 Metrics/MethodLength:
-  Max: 41
   Exclude:
     - 'lib/generators/react_on_rails/install_generator.rb'  # Generator setup methods require comprehensive error handling
 
 Metrics/ModuleLength:
-  Max: 180
   Exclude:
     - 'spec/react_on_rails/engine_spec.rb'  # Comprehensive engine tests require many examples
 
@@ -107,15 +54,6 @@ RSpec/AnyInstance:
     - 'spec/react_on_rails/binstubs/dev_static_spec.rb'
     - 'spec/react_on_rails/dev/**/*_spec.rb'  # Dev module tests require system mocking
 
-RSpec/DescribeClass:
-  Enabled: false
-
-RSpec/ExampleLength:
-  Enabled: false
-
-RSpec/MessageSpies:
-  Enabled: false
-
 RSpec/NestedGroups:
   Max: 4
 
@@ -127,19 +65,10 @@ RSpec/BeforeAfterAll:
     - 'spec/react_on_rails/binstubs/dev_static_spec.rb'
     - 'spec/react_on_rails/dev/**/*_spec.rb'  # Dev module tests require global setup
 
-RSpec/MessageChain:
-  Enabled: false
-
-RSpec/MultipleExpectations:
-  Enabled: false
-
 RSpec/MultipleDescribes:
   Exclude:
     - 'spec/dummy/spec/system/integration_spec.rb'
 
-RSpec/MultipleMemoizedHelpers:
-  Max: 12
-
 Style/GlobalVars:
   Exclude:
     - 'spec/dummy/config/environments/development.rb'
@@ -156,4 +85,3 @@ RSpec/InstanceVariable:
 RSpec/StubbedMock:
   Exclude:
     - 'spec/react_on_rails/dev/**/*_spec.rb'  # Dev module tests use mixed stub/mock patterns
-

react_on_rails_pro/.prettierignore

@@ -9,3 +9,6 @@ spec/dummy/.yalc/
 
 # File Generated by ROR FS-based Registry
 **/generated
+
+# Prettier doesn't understand ERB in RuboCop config
+.rubocop.yml

react_on_rails_pro/.rubocop.yml

@@ -1,90 +1,23 @@
-# This is the configuration used to check the rubocop source code.
-# Check out: https://github.com/bbatsov/rubocop
-require:
-  - rubocop-performance
-  - rubocop-rspec
+# Inherits from root config
+inherit_from: ../.rubocop.yml
 
 AllCops:
-  NewCops: enable
-  DisplayCopNames: true
-  TargetRubyVersion: 3.0
-
-  Include:
-    - '**/Rakefile'
-    - '**/config.ru'
-    - 'Gemfile'
-    - '**/*.rb'
-    - '**/*.rake'
-
   Exclude:
   <% `git status --ignored --porcelain`.lines.grep(/^!! /).each do |path| %>
     - <%= path.sub(/^!! /, '') %>
   <% end %>
-    - '**/node_modules/**/*'
     - 'db/schema.rb'
     - 'db/seeds.rb'
-    - 'spec/fixtures/**/*'
     - 'spec/dummy/db/schema.rb'
     - 'spec/dummy/bin/**/*'
-    - 'node_modules/**/*'
-    - 'coverage/**/*'
     - 'bin/**/*'
-    - 'vendor/**/*'
-
-Naming/FileName:
-  Exclude:
-    - '**/Gemfile'
-    - '**/Rakefile'
-
-Layout/LineLength:
-  Max: 120
-
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-Style/Documentation:
-  Enabled: false
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true
-
-Metrics/AbcSize:
-  Max: 28
 
 Metrics/CyclomaticComplexity:
   Max: 8
 
-Metrics/PerceivedComplexity:
-  Max: 10
-
 Metrics/ClassLength:
   Max: 140
 
-Metrics/ParameterLists:
-  Max: 5
-  CountKeywordArgs: false
-
-Metrics/MethodLength:
-  Max: 41
-
-Metrics/ModuleLength:
-  Max: 180
-
-RSpec/DescribeClass:
-  Enabled: false
-
-RSpec/ExampleLength:
-  Enabled: false
-
-RSpec/MessageSpies:
-  Enabled: false
-
 RSpec/NestedGroups:
   Max: 5
 
@@ -93,19 +26,10 @@ RSpec/BeforeAfterAll:
     - 'spec/react_on_rails/generators/dev_tests_generator_spec.rb'
     - 'spec/react_on_rails/generators/install_generator_spec.rb'
 
-RSpec/MessageChain:
-  Enabled: false
-
-RSpec/MultipleExpectations:
-  Enabled: false
-
 RSpec/MultipleDescribes:
   Exclude:
     - 'spec/dummy/spec/system/integration_spec.rb'
 
-RSpec/MultipleMemoizedHelpers:
-  Max: 12
-
 RSpec:
   Language:
     Expectations:
@@ -115,6 +39,3 @@ RSpec:
 Style/GlobalVars:
   Exclude:
     - 'spec/dummy/config/environments/development.rb'
-
-Style/FrozenStringLiteralComment:
-  EnforcedStyle: always