fix(desktop): a fixed root escapes ancestor padding — chat drew under the lights

Cursor's sharpest catch, and the audit was actively hiding the bug rather than
missing it. `position: fixed` resolves against the viewport, not the parent, so a
lane-aware shell's `padding-top` never moves it. The chat surfaces sit inside
`LogoShell` and still painted at viewport top, under the traffic lights, while the
check reported them covered — and adding the correct reservation would then have
tripped the nested-reservation check, so the audit pushed toward the wrong answer.

Roots matching `fixed inset-0` no longer inherit coverage and are exempt from the
doubled check. That reclassified seven surfaces, each decided on evidence:

- chat, its loading boundary, the loading state and the voice interface are
  full-window roots at `z-[100]` with their own top chrome — all now reserve;
- the file viewer wraps a full-bleed `<iframe>` whose content starts at viewport
  top — now reserves;
- session-expired centres its content with nothing in the lane, and the search
  modal's `fixed inset-0` is only its scrim (the panel sits at `top-[15%]`) — both
  allowlisted with that reasoning rather than an assumption.

Verified by reverting chat to a bare `fixed inset-0` inside `LogoShell`: it is
flagged now and was called covered before.

Author: waleedlatif1

apps/sim/app/(interfaces)/chat/[identifier]/chat.tsx

@@ -8,6 +8,7 @@ import {
   AGENT_STREAM_PROTOCOL_HEADER,
   AGENT_STREAM_PROTOCOL_V1,
 } from '@/lib/workflows/streaming/agent-stream-protocol'
+import { DesktopTitleBarLane } from '@/app/_shell/desktop-title-bar'
 import {
   ChatErrorState,
   ChatHeader,
@@ -440,7 +441,8 @@ export default function ChatClient({ identifier }: { identifier: string }) {
   }
 
   return (
-    <div className='light fixed inset-0 z-[100] flex flex-col bg-[var(--bg)] text-[var(--text-primary)]'>
+    <div className='light desktop-title-bar-page fixed inset-0 z-[100] flex flex-col bg-[var(--bg)] text-[var(--text-primary)]'>
+      <DesktopTitleBarLane />
       {/* Header component */}
       <ChatHeader chatConfig={chatConfig} starCount={starCount} />
 

apps/sim/app/(interfaces)/chat/[identifier]/loading.tsx

@@ -1,8 +1,10 @@
 import { Skeleton } from '@sim/emcn'
+import { DesktopTitleBarLane } from '@/app/_shell/desktop-title-bar'
 
 export default function ChatLoading() {
   return (
-    <div className='light fixed inset-0 z-[100] flex flex-col bg-[var(--bg)] text-[var(--text-primary)]'>
+    <div className='light desktop-title-bar-page fixed inset-0 z-[100] flex flex-col bg-[var(--bg)] text-[var(--text-primary)]'>
+      <DesktopTitleBarLane />
       <div className='border-[var(--border-1)] border-b px-4 py-3'>
         <div className='mx-auto flex max-w-3xl items-center justify-between'>
           <div className='flex items-center gap-[12px]'>

apps/sim/app/(interfaces)/chat/components/loading-state/loading-state.tsx

@@ -1,8 +1,10 @@
 import { Skeleton } from '@sim/emcn'
+import { DesktopTitleBarLane } from '@/app/_shell/desktop-title-bar'
 
 export function ChatLoadingState() {
   return (
-    <div className='light fixed inset-0 z-[100] flex flex-col bg-[var(--bg)]'>
+    <div className='light desktop-title-bar-page fixed inset-0 z-[100] flex flex-col bg-[var(--bg)]'>
+      <DesktopTitleBarLane />
       <div className='flex flex-1 items-center justify-center px-4'>
         <div className='w-full max-w-[410px]'>
           <div className='flex flex-col items-center justify-center'>

apps/sim/app/(interfaces)/chat/components/voice-interface/voice-interface.tsx

@@ -14,6 +14,7 @@ import {
   MAX_CHAT_SESSION_MS,
   SAMPLE_RATE,
 } from '@/lib/speech/config'
+import { DesktopTitleBarLane } from '@/app/_shell/desktop-title-bar'
 
 const ParticlesVisualization = dynamic(
   () =>
@@ -524,10 +525,11 @@ export function VoiceInterface({
   return (
     <div
       className={cn(
-        'light fixed inset-0 z-[100] flex flex-col bg-[var(--bg)] text-[var(--text-primary)]',
+        'light desktop-title-bar-page fixed inset-0 z-[100] flex flex-col bg-[var(--bg)] text-[var(--text-primary)]',
         className
       )}
     >
+      <DesktopTitleBarLane />
       <div className='flex flex-1 flex-col items-center justify-center px-8'>
         <div className='relative mb-16'>
           <ParticlesVisualization

apps/sim/app/_shell/desktop-title-bar-surfaces.test.ts

@@ -193,6 +193,10 @@ const LANE_EXEMPT: Record<string, string> = {
     'Marketing chrome. Verified: every consumer lives under app/(landing)/, and the desktop shell boots to /login or a workspace with no path to those routes.',
   'app/playground/page.tsx':
     'Verified dev-only: the page calls notFound() unless NEXT_PUBLIC_ENABLE_PLAYGROUND is set.',
+  'app/workspace/[workspaceId]/components/session-expired/session-expired.tsx':
+    'Centres its content (`items-center justify-center`) with no chrome in the lane, and is a transient sign-out notice.',
+  'app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx':
+    'The `fixed inset-0` here is the scrim, which carries no content. The panel itself is separately positioned at `top-[15%]`, well clear of the lane.',
   'app/_shell/desktop-update-gate.tsx':
     'Blocking overlay that centres its content, with no chrome in the lane. The lights stay usable regardless: under `titleBarStyle: hiddenInset` macOS draws them above the web contents, so web UI cannot cover them — this bug class is app chrome sitting *under* the lights, not the reverse.',
   'app/workspace/[workspaceId]/w/[workflowId]/components/error/index.tsx':
@@ -214,6 +218,16 @@ const LANE_EXEMPT: Record<string, string> = {
  * surface this PR converted lost its `min-h-screen` token and dropped out of the check
  * entirely, leaving the files most likely to regress unwatched.
  */
+/**
+ * A root positioned against the viewport rather than its parent.
+ *
+ * `position: fixed` ignores an ancestor's `padding-top`, so a lane-aware shell does NOT
+ * cover it — the chat surfaces sat inside `LogoShell` and still painted at viewport top,
+ * under the lights, while this check called them covered. Such a root must reserve for
+ * itself, and reserving must not then read as a double reservation.
+ */
+const ESCAPES_ANCESTOR_PADDING = /fixed inset-0/
+
 const FILLS_VIEWPORT = /\b(min-h-screen|h-screen)\b|fixed inset-0|desktop-title-bar-page/
 
 const LANE_AWARE_SHELL_USAGE = /<(AuthShell|LogoShell|WorkspaceChrome|InterfacesShell)\b/
@@ -290,9 +304,11 @@ function viewportRoots() {
         file,
         fillsViewport: FILLS_VIEWPORT.test(source),
         self: reservesLane(source),
+        escapesPadding: ESCAPES_ANCESTOR_PADDING.test(source),
         inherited:
           !SELF_RESERVE_REQUIRED.has(file) &&
           !DEFINES_LANE_SHELL.test(source) &&
+          !ESCAPES_ANCESTOR_PADDING.test(source) &&
           ancestorLayouts(file).some((l) => reservesLane(sourceOf(l))),
       }
     })
@@ -316,7 +332,7 @@ describe('desktop traffic-light lane coverage', () => {
     // drag strips and two controllers. Shipped exactly that on the resume loading skeleton,
     // and the file-local check could not see it.
     const doubled = viewportRoots()
-      .filter((r) => r.self && r.inherited)
+      .filter((r) => r.self && r.inherited && !r.escapesPadding)
       .map((r) => r.file)
 
     expect(doubled).toEqual([])

apps/sim/app/workspace/[workspaceId]/files/[fileId]/view/file-viewer.tsx

@@ -2,6 +2,7 @@
 
 import { createLogger } from '@sim/logger'
 import { useParams } from 'next/navigation'
+import { DesktopTitleBarLane } from '@/app/_shell/desktop-title-bar'
 import { useWorkspaceFileRecord } from '@/hooks/queries/workspace-files'
 
 const logger = createLogger('FileViewer')
@@ -20,7 +21,8 @@ export function FileViewer() {
   const serveUrl = `/api/files/serve/${encodeURIComponent(file.key)}?context=workspace&t=${file.size}`
 
   return (
-    <div className='fixed inset-0 z-50 bg-[var(--bg)]'>
+    <div className='desktop-title-bar-page fixed inset-0 z-50 bg-[var(--bg)]'>
+      <DesktopTitleBarLane />
       <iframe
         src={serveUrl}
         className='h-full w-full border-0'