fix(dashboards): drop inherited ordering on query-mode switches and cap diagnostics size

A panel switching away from the dashboard's query mode no longer inherits its
sort or limit, which name aggregate aliases or top-N groups in one mode and
rows in the other. Write diagnostics check the 128 KB source limit before
decoding the payload.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S6aTRnkiu7PxYZPNPXYEMV

Author: TheodoreSpeaks

apps/sim/lib/dashboards/diagnostics.ts

@@ -1,5 +1,9 @@
 import { DASHBOARD_CONTENT_TYPE } from '@/lib/dashboards/file'
-import { parseDashboardSpec } from '@/lib/dashboards/spec'
+import {
+  DASHBOARD_SOURCE_TOO_LARGE,
+  MAX_DASHBOARD_SOURCE_BYTES,
+  parseDashboardSpec,
+} from '@/lib/dashboards/spec'
 
 /**
  * Parse errors for a dashboard file's content, reported on write without blocking it, like
@@ -11,6 +15,7 @@ export function dashboardDiagnostics(
   content: Buffer | string
 ): string[] | undefined {
   if (contentType !== DASHBOARD_CONTENT_TYPE) return undefined
+  if (Buffer.byteLength(content) > MAX_DASHBOARD_SOURCE_BYTES) return [DASHBOARD_SOURCE_TOO_LARGE]
   const { error } = parseDashboardSpec(content.toString())
   return error ? error.split('\n') : []
 }

apps/sim/lib/dashboards/spec.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, it } from 'vitest'
-import { parseDashboardSpec } from '@/lib/dashboards/spec'
+import { parseDashboardSpec, resolveDashboardSource } from '@/lib/dashboards/spec'
 import {
   dashboardRangeFromCalendar,
   parseDashboardCustomRange,
@@ -124,6 +124,22 @@ describe('panel query modes', () => {
   })
 })
 
+describe('inherited ordering across query modes', () => {
+  it('does not carry a sort or limit into a panel that switches query mode', () => {
+    const resolved = resolveDashboardSource(
+      {
+        tableId: 'tbl_1',
+        groupBy: ['status'],
+        aggregate: { n: { op: 'count' } },
+        sort: [{ field: 'n', direction: 'desc' }],
+        limit: 5,
+      },
+      { columns: ['status'] }
+    )
+    expect(resolved).toEqual({ tableId: 'tbl_1', columns: ['status'] })
+  })
+})
+
 describe('dashboard parse errors', () => {
   it('names the block path, the allowed block kinds and any unknown key', () => {
     expect(parseDashboardSpec('title: Probe\nblocks:\n  - bogus: 1\n').error).toBe(

apps/sim/lib/dashboards/spec.ts

@@ -10,6 +10,10 @@ import {
   analyticsSelectionSchema,
 } from '@/lib/table/analytics/schema'
 
+/** Dashboard YAML is bounded before parsing; writes report the same limit without decoding. */
+export const MAX_DASHBOARD_SOURCE_BYTES = 128 * 1024
+export const DASHBOARD_SOURCE_TOO_LARGE = 'Dashboard source exceeds 128 KB'
+
 export const DASHBOARD_RANGES = ['1h', '24h', '7d', '30d', '90d'] as const
 export type DashboardRange = (typeof DASHBOARD_RANGES)[number]
 const rangeSchema = z.enum(DASHBOARD_RANGES)
@@ -89,19 +93,33 @@ const dashboardSchema: z.ZodType<DashboardSpec> = z
   })
   .strict()
 
+function queryMode(source: DashboardSource | undefined): 'columns' | 'aggregate' | undefined {
+  return source?.columns ? 'columns' : source?.aggregate ? 'aggregate' : undefined
+}
+
 /**
  * A panel's source shallowly overrides the dashboard's. Choosing a query mode (`aggregate` or
  * `columns`) drops the other mode's inherited fields, so shared defaults serve both panel kinds.
+ * Switching away from the dashboard's mode also drops its `sort` and `limit`, which name
+ * aggregate aliases or top-N groups in one mode and rows in the other.
  */
 export function resolveDashboardSource(
   defaults: DashboardSource | undefined,
   source: DashboardSource | undefined
 ): ResolvedDashboardSource {
-  const inherited = source?.columns
-    ? omit(defaults ?? {}, ['aggregate', 'groupBy', 'bucket'])
-    : source?.aggregate
-      ? omit(defaults ?? {}, ['columns'])
-      : defaults
+  const mode = queryMode(source)
+  const switched =
+    mode !== undefined && queryMode(defaults) !== undefined && mode !== queryMode(defaults)
+  const modeFields =
+    mode === 'columns'
+      ? (['aggregate', 'groupBy', 'bucket'] as const)
+      : mode === 'aggregate'
+        ? (['columns'] as const)
+        : []
+  const inherited = omit(defaults ?? {}, [
+    ...modeFields,
+    ...(switched ? (['sort', 'limit'] as const) : []),
+  ])
   const merged = { ...inherited, ...source }
   if (!merged.tableId)
     throw new Error('A data panel requires source.tableId, on the dashboard or on the panel')
@@ -163,8 +181,8 @@ export function parseDashboardSpec(
   content: string
 ): { spec: DashboardSpec; error?: never } | { error: string; spec?: never } {
   try {
-    if (new TextEncoder().encode(content).byteLength > 128 * 1024)
-      throw new Error('Dashboard source exceeds 128 KB')
+    if (new TextEncoder().encode(content).byteLength > MAX_DASHBOARD_SOURCE_BYTES)
+      throw new Error(DASHBOARD_SOURCE_TOO_LARGE)
     const raw: unknown = load(content, { schema: JSON_SCHEMA })
     const measured = measureYamlExpansion(raw, {
       maxNodes: 10000,