You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6cc25f6
Browse filesBrowse the repository at this point in the historyBrowse files
improvement(forking): make webhook url mapping clear (#6272)
* improvement(forking): make webhook url mapping clear
* fix(forking): honour drops before the unmapped gate, match provider on URL adoption
Review round 1 on #6272.
- Drop was inert for required references: `postCopyUnmappedRequired` gates before
the cleared-ref gate that honours acknowledgments, so a source-deleted reference
on a required field still failed with "map all required ... first". Verified drops
are now resolved once (`verifyForkDropAcknowledgments`) and subtracted from both
gates. Verification is not optional: an unmapped reference of a non-blocking kind
(credential, env-var) never re-blocks downstream, so subtracting raw
acknowledgments would let a crafted payload skip the required gate.
- URL adoption now requires provider equality. A count-only 1:1 pairing could hand a
GitHub URL to an arriving Slack trigger, keeping the endpoint alive while every
request failed signature verification - and reporting the URL as preserved.
- `resolveTriggerId` moved from `lib/webhooks/deploy.ts` to `@/triggers/webhook-url`
so the deploy path and the fork's provider check share one resolution.
- Trigger URL warnings render the full public URL in the heads-up section and name
the URL in the overwrite confirm, where identical workflow names were ambiguous.
- The Drop control renders once per resource and states how many fields it covers;
the remapper clears by reference, so a per-row control implied a choice the write
path cannot honour.
- Export clears `workflow-selector`: nothing on the import path remaps workflow ids
(`import-export.ts` re-creates each workflow under a fresh id), so a preserved
reference dangled - bundle or not.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
0 commit comments