fix(ci): align control regression tests with repository audits

Author: Bill Leoutsakos

apps/sim/app/(auth)/verify/otp-error-source.test.tsx

@@ -1,5 +1,7 @@
 /** @vitest-environment jsdom */
 import { act, type ButtonHTMLAttributes, type InputHTMLAttributes, type ReactNode } from 'react'
+import { emcnMock } from '@sim/testing/mocks/emcn.mock'
+import { nextNavigationMock } from '@sim/testing/mocks/next-navigation.mock'
 import { createRoot, type Root } from 'react-dom/client'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
@@ -8,11 +10,10 @@ const mocks = vi.hoisted(() => ({
   chatVerify: vi.fn(),
   fileRequest: vi.fn(),
   fileVerify: vi.fn(),
-  refresh: vi.fn(),
 }))
 
 vi.mock('@sim/emcn', () => ({
-  cn: (...values: Array<string | false | null | undefined>) => values.filter(Boolean).join(' '),
+  ...emcnMock,
   ChipInput: ({
     error: _error,
     size: _size,
@@ -75,7 +76,7 @@ vi.mock('@/components/auth/public-auth-header', () => ({
 vi.mock('@/app/f/[token]/public-file-auth-shell', () => ({
   PublicFileAuthShell: ({ children }: { children: ReactNode }) => <div>{children}</div>,
 }))
-vi.mock('next/navigation', () => ({ useRouter: () => ({ refresh: mocks.refresh }) }))
+vi.mock('next/navigation', () => nextNavigationMock)
 vi.mock('@/hooks/queries/chats', () => ({
   useChatEmailOtpRequest: () => ({ mutateAsync: mocks.chatRequest, isPending: false }),
   useChatEmailOtpVerify: () => ({ mutateAsync: mocks.chatVerify, isPending: false }),
@@ -96,6 +97,12 @@ function changeInput(input: HTMLInputElement, value: string) {
   input.dispatchEvent(new Event('input', { bubbles: true }))
 }
 
+function input(selector: string) {
+  const found = container.querySelector<HTMLInputElement>(selector)
+  if (!found) throw new Error(`Missing input: ${selector}`)
+  return found
+}
+
 function button(label: string) {
   const found = Array.from(container.querySelectorAll('button')).find(
     (candidate) => candidate.textContent?.trim() === label
@@ -114,7 +121,6 @@ function expectOtpInvalid(invalid: boolean) {
 }
 
 beforeEach(() => {
-  vi.clearAllMocks()
   vi.stubGlobal('IS_REACT_ACT_ENVIRONMENT', true)
   mocks.chatRequest.mockResolvedValue({})
   mocks.chatVerify.mockResolvedValue({})
@@ -128,15 +134,12 @@ beforeEach(() => {
 afterEach(() => {
   act(() => root.unmount())
   container.remove()
-  vi.unstubAllGlobals()
 })
 
 describe('OTP error provenance', () => {
   it('keeps the chat code valid on resend failure and marks only a failed verification invalid', async () => {
     act(() => root.render(<EmailAuth identifier='chat-1' />))
-    act(() =>
-      changeInput(container.querySelector<HTMLInputElement>('#email')!, 'member@example.com')
-    )
+    act(() => changeInput(input('#email'), 'member@example.com'))
     await act(async () => button('Continue').click())
 
     mocks.chatRequest.mockRejectedValueOnce(new Error('Delivery failed'))
@@ -145,18 +148,14 @@ describe('OTP error provenance', () => {
     expectOtpInvalid(false)
 
     mocks.chatVerify.mockRejectedValueOnce(new Error('Incorrect code'))
-    await act(async () =>
-      changeInput(container.querySelector<HTMLInputElement>('[data-testid="otp-code"]')!, '123456')
-    )
+    await act(async () => changeInput(input('[data-testid="otp-code"]'), '123456'))
     expect(container.textContent).toContain('Incorrect code')
     expectOtpInvalid(true)
   })
 
   it('keeps the public-file code valid on resend failure and marks only a failed verification invalid', async () => {
     act(() => root.render(<PublicFileEmailAuth token='share-1' />))
-    act(() =>
-      changeInput(container.querySelector<HTMLInputElement>('#email')!, 'member@example.com')
-    )
+    act(() => changeInput(input('#email'), 'member@example.com'))
     await act(async () => button('Continue').click())
 
     mocks.fileRequest.mockRejectedValueOnce(new Error('Delivery failed'))
@@ -165,9 +164,7 @@ describe('OTP error provenance', () => {
     expectOtpInvalid(false)
 
     mocks.fileVerify.mockRejectedValueOnce(new Error('Incorrect code'))
-    await act(async () =>
-      changeInput(container.querySelector<HTMLInputElement>('[data-testid="otp-code"]')!, '123456')
-    )
+    await act(async () => changeInput(input('[data-testid="otp-code"]'), '123456'))
     expect(container.textContent).toContain('Incorrect code')
     expectOtpInvalid(true)
   })

apps/sim/app/workspace/[workspaceId]/components/index.ts

@@ -42,7 +42,6 @@ export type {
   PaginationConfig,
   ResourceCell,
   ResourceCellEditing,
-  ResourceColumn,
   ResourceRow,
   ResourceTableHandle,
   RowDragDropConfig,

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-sidebar-layout.test.tsx

@@ -39,9 +39,11 @@ describe('table sidebar layout', () => {
     }
 
     render(true)
-    const dialog = container.querySelector<HTMLElement>('[role="dialog"]')!
-    const input = container.querySelector<HTMLInputElement>('input')!
-    const scrollBody = input.parentElement!
+    const dialog = container.querySelector<HTMLElement>('[role="dialog"]')
+    const input = container.querySelector<HTMLInputElement>('input')
+    if (!dialog || !input) throw new Error('Missing sidebar dialog or workflow input')
+    const scrollBody = input.parentElement
+    if (!scrollBody) throw new Error('Missing sidebar scroll body')
     expect(dialog.getAttribute('aria-label')).toBe('Configure workflow')
     expect(dialog.classList.contains('translate-x-0')).toBe(true)
     expect(dialog.classList.contains('shadow-overlay')).toBe(true)

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/chat/chat-field-error.test.tsx

@@ -1,4 +1,7 @@
 import type { ComponentProps, PropsWithChildren } from 'react'
+import { deploymentShapeMock } from '@sim/testing/mocks/deployment-shape.mock'
+import { emcnIconsMock } from '@sim/testing/mocks/emcn-icons.mock'
+import { emcnMock } from '@sim/testing/mocks/emcn.mock'
 import { JSDOM } from 'jsdom'
 import { renderToStaticMarkup } from 'react-dom/server'
 import { describe, expect, it, vi } from 'vitest'
@@ -12,27 +15,22 @@ const validation = vi.hoisted(() => ({
 }))
 
 vi.mock('@sim/emcn', () => ({
+  ...emcnMock,
   Input: (props: ComponentProps<'input'>) => <input {...props} />,
   Label: (props: ComponentProps<'label'>) => (
     <label htmlFor={props.htmlFor} className={props.className}>
       {props.children}
     </label>
   ),
-  cn: (...values: unknown[]) => values.filter(Boolean).join(' '),
   Tooltip: {
     Root: ({ children }: PropsWithChildren) => <>{children}</>,
     Trigger: ({ children }: PropsWithChildren) => <>{children}</>,
     Content: ({ children }: PropsWithChildren) => <>{children}</>,
   },
 }))
-vi.mock('@sim/emcn/icons', () => ({ Check: () => null, TriangleAlert: () => null }))
-vi.mock('@sim/logger', () => ({ createLogger: () => ({}) }))
+vi.mock('@sim/emcn/icons', () => emcnIconsMock)
 vi.mock('@/components/ui', () => ({ GeneratedPasswordInput: () => null }))
-vi.mock('@/lib/core/config/deployment-shape', () => ({ useDeploymentShape: () => ({}) }))
-vi.mock('@/lib/core/utils/urls', () => ({
-  getBaseUrl: () => 'https://sim.ai',
-  getEmailDomain: () => 'sim.ai',
-}))
+vi.mock('@/lib/core/config/deployment-shape', () => deploymentShapeMock)
 vi.mock('@/lib/messaging/email/validation', () => ({ validateAllowlistEntry: () => true }))
 vi.mock('@/lib/workflows/streaming/output-selector', () => ({
   formatInternalOutputSelector: () => '',

apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-editor/preview-readonly-styles.test.tsx

@@ -2,13 +2,11 @@
  * @vitest-environment jsdom
  */
 import { act } from 'react'
+import { nextNavigationMock, nextNavigationMockFns } from '@sim/testing/mocks/next-navigation.mock'
 import { createRoot, type Root } from 'react-dom/client'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
-vi.mock('next/navigation', () => ({
-  useParams: () => ({ workspaceId: 'workspace-1' }),
-  usePathname: () => '/workspace/workspace-1/w/workflow-1',
-}))
+vi.mock('next/navigation', () => nextNavigationMock)
 vi.mock('@/hooks/use-webhook-management', () => ({
   useWebhookManagement: () => ({ webhookUrl: null }),
 }))
@@ -33,6 +31,8 @@ let container: HTMLDivElement
 let root: Root
 
 beforeEach(() => {
+  nextNavigationMockFns.mockUseParams.mockReturnValue({ workspaceId: 'workspace-1' })
+  nextNavigationMockFns.mockUsePathname.mockReturnValue('/workspace/workspace-1/w/workflow-1')
   ;(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true
   container = document.createElement('div')
   document.body.appendChild(container)
@@ -78,10 +78,12 @@ describe('workflow preview read-only appearance', () => {
       )
     )
 
-    const preview = container.querySelector('[data-testid="preview"]')!
-    const previewSwitch = preview.querySelector('[role="switch"]') as HTMLButtonElement
-    const disabled = container.querySelector('[data-testid="disabled"]')!
-    const disabledSwitch = disabled.querySelector('[role="switch"]') as HTMLButtonElement
+    const preview = container.querySelector('[data-testid="preview"]')
+    const disabled = container.querySelector('[data-testid="disabled"]')
+    if (!preview || !disabled) throw new Error('Missing preview or disabled section')
+    const previewSwitch = preview.querySelector<HTMLButtonElement>('[role="switch"]')
+    const disabledSwitch = disabled.querySelector<HTMLButtonElement>('[role="switch"]')
+    if (!previewSwitch || !disabledSwitch) throw new Error('Missing preview or disabled switch')
 
     expect(preview.querySelector('[data-preview-readonly]')).not.toBeNull()
     expect(previewSwitch.hasAttribute('disabled')).toBe(true)
@@ -90,12 +92,14 @@ describe('workflow preview read-only appearance', () => {
     expect(getComputedStyle(previewSwitch).pointerEvents).toBe('none')
     const piiTrigger = Array.from(preview.querySelectorAll('button')).find((button) =>
       button.textContent?.includes('Configure PII Types')
-    )!
+    )
+    if (!piiTrigger) throw new Error('Missing PII configuration trigger')
     expect(piiTrigger.disabled).toBe(true)
     expect(piiTrigger.hasAttribute('data-preview-full-opacity')).toBe(true)
     const removeButton = Array.from(preview.querySelectorAll('button')).find((button) =>
       button.textContent?.includes('Remove file')
-    )!
+    )
+    if (!removeButton) throw new Error('Missing remove file button')
     expect(getComputedStyle(removeButton).pointerEvents).toBe('none')
     expect(getComputedStyle(removeButton).opacity).toBe('0.5')
 

packages/emcn/src/components/collapsible-card/collapsible-card.test.tsx

@@ -13,6 +13,7 @@ function mount(children: ReactNode) {
   document.body.appendChild(container)
   root = createRoot(container)
   act(() => root?.render(children))
+  return container
 }
 
 afterEach(() => {
@@ -37,9 +38,11 @@ describe('CollapsibleCard', () => {
         </CollapsibleCard>
       )
     }
-    mount(<Example />)
-    const card = container!.querySelector('[data-filter-id="condition-1"]')!
-    const trigger = card.querySelector<HTMLElement>('[role="button"]')!
+    const mountedContainer = mount(<Example />)
+    const card = mountedContainer.querySelector('[data-filter-id="condition-1"]')
+    if (!card) throw new Error('Missing condition card')
+    const trigger = card.querySelector<HTMLElement>('[role="button"]')
+    if (!trigger) throw new Error('Missing collapse trigger')
     expect(trigger.getAttribute('aria-expanded')).toBe('false')
     expect(card.querySelector('input')).toBeNull()
     act(() => trigger.click())
@@ -56,7 +59,7 @@ describe('CollapsibleCard', () => {
     const add = vi.fn()
     const remove = vi.fn()
     const parentClick = vi.fn()
-    mount(
+    const mountedContainer = mount(
       <CollapsibleCard
         title={<span>Long condition name</span>}
         badge={<span>Text</span>}
@@ -77,8 +80,9 @@ describe('CollapsibleCard', () => {
         Content
       </CollapsibleCard>
     )
-    const trigger = container!.querySelector('[role="button"]')!
-    const [addButton, deleteButton] = container!.querySelectorAll('button')
+    const trigger = mountedContainer.querySelector('[role="button"]')
+    const [addButton, deleteButton] = mountedContainer.querySelectorAll('button')
+    if (!trigger || !addButton || !deleteButton) throw new Error('Missing card actions')
     expect(trigger.contains(addButton)).toBe(false)
     act(() => {
       addButton.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter', bubbles: true }))

packages/emcn/src/components/field-divider/field-divider.dom.test.tsx

@@ -39,7 +39,8 @@ describe('FieldDisclosure', () => {
       </form>
     )
     act(() => root?.render(render(false)))
-    const button = container.querySelector('button')!
+    const button = container.querySelector('button')
+    if (!button) throw new Error('Missing field disclosure button')
     expect(button.getAttribute('aria-expanded')).toBe('false')
     expect(button.getAttribute('aria-controls')).toBe('additional-fields')
     act(() => {

scripts/check-unused-exports.baseline.json

@@ -371,7 +371,6 @@
   "apps/sim/app/workspace/[workspaceId]/components/index.ts#ResourceCell",
   "apps/sim/app/workspace/[workspaceId]/components/index.ts#ResourceCellEditing",
   "apps/sim/app/workspace/[workspaceId]/components/index.ts#ResourceChromeFallback",
-  "apps/sim/app/workspace/[workspaceId]/components/index.ts#ResourceNotFound",
   "apps/sim/app/workspace/[workspaceId]/components/index.ts#ResourceRow",
   "apps/sim/app/workspace/[workspaceId]/components/index.ts#ResourceRowSelection",
   "apps/sim/app/workspace/[workspaceId]/components/index.ts#ResourceTableHandle",