improvement(audits): rebaseline ratchets on current staging, lint newly covered uploads files, anchor suppression detection to comments

Author: waleedlatif1

apps/sim/lib/uploads/contexts/workspace/workspace-file-query.test.ts

@@ -152,9 +152,6 @@ describe('listWorkspaceFiles', () => {
     resetDbChainMock()
   })
 
-  const lastProjection = () =>
-    Object.keys((dbChainMockFns.select.mock.calls.at(-1)?.[0] ?? {}) as Record<string, unknown>)
-
   it('caps the rows read when the caller only needs to fit a budget', async () => {
     queueTableRows(schemaMock.workspaceFiles, [buildRow()])
 

apps/sim/lib/uploads/providers/s3/client.test.ts

@@ -7,7 +7,6 @@ import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const {
   mockSend,
-  mockS3Client,
   mockS3ClientConstructor,
   mockPutObjectCommand,
   mockGetObjectCommand,

apps/sim/lib/uploads/utils/file-utils.ts

@@ -10,14 +10,6 @@ import {
 import { isUuid } from '@/executor/constants'
 import type { UserFile } from '@/executor/types'
 
-interface FileAttachment {
-  id: string
-  key: string
-  filename: string
-  media_type: string
-  size: number
-}
-
 export interface MessageContent {
   type: 'text' | 'image' | 'document' | 'audio' | 'video'
   text?: string

scripts/check-explicit-any.baseline.json

@@ -5,7 +5,7 @@
     "apps/realtime/src/handlers/variables.ts": 2,
     "apps/sim/app/(auth)/login/login-form.tsx": 2,
     "apps/sim/app/(auth)/verify/use-verification.ts": 1,
-    "apps/sim/app/(interfaces)/resume/[workflowId]/[executionId]/resume-page-client.tsx": 17,
+    "apps/sim/app/(interfaces)/resume/[workflowId]/[executionId]/resume-page-client.tsx": 16,
     "apps/sim/app/api/auth/oauth/utils.test.ts": 2,
     "apps/sim/app/api/auth/sso/register/route.ts": 3,
     "apps/sim/app/api/chat/[identifier]/route.test.ts": 1,
@@ -33,7 +33,6 @@
     "apps/sim/app/api/workflows/route.ts": 1,
     "apps/sim/app/api/workflows/utils.ts": 1,
     "apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/components/chat-message/chat-message.tsx": 1,
-    "apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/hooks/use-change-detection.ts": 2,
     "apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/connection-blocks/connection-blocks.tsx": 3,
     "apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/checkbox-list/checkbox-list.tsx": 1,
     "apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/condition-input/condition-input.tsx": 2,
@@ -79,15 +78,15 @@
     "apps/sim/app/workspace/providers/socket-provider.tsx": 10,
     "apps/sim/background/workflow-execution.ts": 2,
     "apps/sim/blocks/blocks/agent.test.ts": 1,
-    "apps/sim/blocks/blocks/agent.ts": 7,
+    "apps/sim/blocks/blocks/agent.ts": 6,
     "apps/sim/blocks/blocks/airtable.ts": 5,
     "apps/sim/blocks/blocks/apify.ts": 2,
     "apps/sim/blocks/blocks/browser_use.ts": 2,
     "apps/sim/blocks/blocks/context_dev.ts": 1,
     "apps/sim/blocks/blocks/deployments.ts": 2,
     "apps/sim/blocks/blocks/discord.ts": 1,
     "apps/sim/blocks/blocks/enrich.ts": 2,
-    "apps/sim/blocks/blocks/evaluator.ts": 5,
+    "apps/sim/blocks/blocks/evaluator.ts": 4,
     "apps/sim/blocks/blocks/firecrawl.ts": 1,
     "apps/sim/blocks/blocks/github.ts": 2,
     "apps/sim/blocks/blocks/gitlab.ts": 2,
@@ -109,7 +108,6 @@
     "apps/sim/blocks/blocks/mongodb.ts": 1,
     "apps/sim/blocks/blocks/mysql.ts": 1,
     "apps/sim/blocks/blocks/neo4j.ts": 1,
-    "apps/sim/blocks/blocks/notion.ts": 1,
     "apps/sim/blocks/blocks/pinecone.ts": 3,
     "apps/sim/blocks/blocks/pipedrive.ts": 1,
     "apps/sim/blocks/blocks/polymarket.ts": 1,
@@ -175,7 +173,7 @@
     "apps/sim/executor/orchestrators/loop.ts": 2,
     "apps/sim/executor/orchestrators/parallel.test.ts": 2,
     "apps/sim/executor/orchestrators/parallel.ts": 5,
-    "apps/sim/executor/types.ts": 24,
+    "apps/sim/executor/types.ts": 18,
     "apps/sim/executor/utils.ts": 1,
     "apps/sim/executor/utils/errors.ts": 1,
     "apps/sim/executor/utils/json.ts": 1,
@@ -205,11 +203,10 @@
     "apps/sim/hooks/use-undo-redo.ts": 43,
     "apps/sim/lib/auth/auth.ts": 3,
     "apps/sim/lib/auth/connectors/providers.ts": 4,
-    "apps/sim/lib/billing/client/types.ts": 2,
+    "apps/sim/lib/billing/client/types.ts": 1,
     "apps/sim/lib/billing/client/upgrade.ts": 3,
     "apps/sim/lib/billing/core/subscription.ts": 1,
     "apps/sim/lib/billing/subscriptions/utils.ts": 7,
-    "apps/sim/lib/billing/types/index.ts": 6,
     "apps/sim/lib/content/mdx.tsx": 15,
     "apps/sim/lib/content/registry-factory.ts": 3,
     "apps/sim/lib/core/config/redis.ts": 1,
@@ -257,7 +254,7 @@
     "apps/sim/lib/webhooks/providers/vercel.test.ts": 2,
     "apps/sim/lib/webhooks/providers/zoho-desk.test.ts": 8,
     "apps/sim/lib/workflows/blocks/block-outputs.ts": 8,
-    "apps/sim/lib/workflows/comparison/compare.test.ts": 13,
+    "apps/sim/lib/workflows/comparison/compare.test.ts": 15,
     "apps/sim/lib/workflows/comparison/format-description.test.ts": 1,
     "apps/sim/lib/workflows/custom-blocks/child-execution.test.ts": 1,
     "apps/sim/lib/workflows/custom-tools/operations.ts": 1,
@@ -386,7 +383,6 @@
     "apps/sim/tools/confluence/create_page.ts": 2,
     "apps/sim/tools/confluence/create_page_property.ts": 2,
     "apps/sim/tools/confluence/list_page_properties.ts": 1,
-    "apps/sim/tools/confluence/types.ts": 1,
     "apps/sim/tools/confluence/update.ts": 1,
     "apps/sim/tools/confluence/upload_attachment.ts": 1,
     "apps/sim/tools/confluence/utils.ts": 1,
@@ -419,7 +415,7 @@
     "apps/sim/tools/discord/create_thread.ts": 1,
     "apps/sim/tools/discord/edit_message.ts": 1,
     "apps/sim/tools/discord/execute_webhook.ts": 1,
-    "apps/sim/tools/discord/types.ts": 23,
+    "apps/sim/tools/discord/types.ts": 22,
     "apps/sim/tools/discord/update_channel.ts": 1,
     "apps/sim/tools/discord/update_member.ts": 1,
     "apps/sim/tools/discord/update_role.ts": 1,
@@ -598,7 +594,6 @@
     "apps/sim/tools/google_slides/types.ts": 1,
     "apps/sim/tools/google_vault/create_matters_export.ts": 1,
     "apps/sim/tools/google_vault/create_matters_holds.ts": 2,
-    "apps/sim/tools/google_vault/types.ts": 2,
     "apps/sim/tools/google_vault/update_matters_holds.ts": 2,
     "apps/sim/tools/grafana/create_dashboard.ts": 2,
     "apps/sim/tools/grain/create_hook.ts": 1,
@@ -658,7 +653,7 @@
     "apps/sim/tools/intercom/snooze_conversation.ts": 2,
     "apps/sim/tools/intercom/tag_contact.ts": 1,
     "apps/sim/tools/intercom/tag_conversation.ts": 1,
-    "apps/sim/tools/intercom/types.ts": 2,
+    "apps/sim/tools/intercom/types.ts": 1,
     "apps/sim/tools/intercom/untag_contact.ts": 1,
     "apps/sim/tools/intercom/update_contact.ts": 4,
     "apps/sim/tools/intercom/update_ticket.ts": 3,
@@ -688,7 +683,7 @@
     "apps/sim/tools/kalshi/amend_order.ts": 3,
     "apps/sim/tools/kalshi/create_order.ts": 2,
     "apps/sim/tools/kalshi/get_orders.ts": 1,
-    "apps/sim/tools/kalshi/types.ts": 2,
+    "apps/sim/tools/kalshi/types.ts": 1,
     "apps/sim/tools/knowledge/create_document.ts": 1,
     "apps/sim/tools/knowledge/delete_chunk.ts": 1,
     "apps/sim/tools/knowledge/delete_document.ts": 1,
@@ -746,7 +741,7 @@
     "apps/sim/tools/mailchimp/get_interests.ts": 1,
     "apps/sim/tools/mailchimp/get_merge_field.ts": 1,
     "apps/sim/tools/mailchimp/get_segments.ts": 1,
-    "apps/sim/tools/memory/types.ts": 2,
+    "apps/sim/tools/memory/types.ts": 1,
     "apps/sim/tools/microsoft_excel/table_add.ts": 3,
     "apps/sim/tools/microsoft_excel/utils.ts": 5,
     "apps/sim/tools/microsoft_excel/write.ts": 8,
@@ -795,7 +790,7 @@
     "apps/sim/tools/pinecone/list_indexes.ts": 1,
     "apps/sim/tools/pinecone/search_text.ts": 1,
     "apps/sim/tools/pinecone/search_vector.ts": 1,
-    "apps/sim/tools/pinecone/types.ts": 14,
+    "apps/sim/tools/pinecone/types.ts": 11,
     "apps/sim/tools/pipedrive/create_activity.ts": 1,
     "apps/sim/tools/pipedrive/create_deal.ts": 1,
     "apps/sim/tools/pipedrive/create_lead.ts": 1,
@@ -844,7 +839,6 @@
     "apps/sim/tools/posthog/list_session_recordings.ts": 1,
     "apps/sim/tools/posthog/list_surveys.ts": 3,
     "apps/sim/tools/posthog/query.ts": 3,
-    "apps/sim/tools/posthog/types.ts": 28,
     "apps/sim/tools/posthog/update_cohort.ts": 4,
     "apps/sim/tools/posthog/update_event_definition.ts": 1,
     "apps/sim/tools/posthog/update_experiment.ts": 4,
@@ -876,7 +870,6 @@
     "apps/sim/tools/reddit/submit_post.ts": 2,
     "apps/sim/tools/reddit/types.ts": 1,
     "apps/sim/tools/request-transport.ts": 5,
-    "apps/sim/tools/response/types.ts": 1,
     "apps/sim/tools/s3/utils.ts": 1,
     "apps/sim/tools/safe-assign.test.ts": 9,
     "apps/sim/tools/salesforce/create_account.ts": 1,
@@ -1080,7 +1073,6 @@
     "apps/sim/triggers/circleback/utils.ts": 1,
     "apps/sim/triggers/confluence/utils.ts": 6,
     "apps/sim/triggers/googleforms/webhook.ts": 1,
-    "apps/sim/triggers/types.ts": 1,
     "apps/sim/vitest.setup.ts": 2,
     "packages/db/scripts/deregister-sso-provider.ts": 3,
     "packages/db/scripts/migrate-block-api-keys-to-byok.ts": 2,
@@ -1107,7 +1099,7 @@
     "scripts/check-fork-dependent-coverage.ts": 2,
     "scripts/check-import-specifiers.ts": 1,
     "scripts/create-single-release.ts": 2,
-    "scripts/generate-docs.ts": 43,
+    "scripts/generate-docs.ts": 41,
     "scripts/generate-v2-cli-api.ts": 3
   },
   "nonNullAssertion": {
@@ -1215,7 +1207,7 @@
     "apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-field.test.tsx": 2,
     "apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/xlsx-preview.tsx": 1,
     "apps/sim/app/workspace/[workspaceId]/home/components/knowledge-search-results/knowledge-search-results.tsx": 1,
-    "apps/sim/app/workspace/[workspaceId]/home/components/knowledge-search-results/search-transitions.test.tsx": 14,
+    "apps/sim/app/workspace/[workspaceId]/home/components/knowledge-search-results/search-transitions.test.tsx": 13,
     "apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/external-link.test.tsx": 1,
     "apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/source-chip/source-icon.test.tsx": 1,
     "apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/special-tags/special-tags.test.tsx": 2,
@@ -1264,6 +1256,7 @@
     "apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx": 2,
     "apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-editor/preview-editor.tsx": 1,
     "apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/components/pending-invitations/view-invitations-modal.test.tsx": 1,
+    "apps/sim/app/workspace/[workspaceId]/w/components/workflow-diff/components/change-list/value-presentation.test.ts": 17,
     "apps/sim/app/workspace/[workspaceId]/w/hooks/use-import-workflow.ts": 6,
     "apps/sim/background/cleanup-soft-deletes.test.ts": 2,
     "apps/sim/background/cleanup-table-row-ttl.integration.ts": 2,
@@ -1596,6 +1589,7 @@
     "apps/sim/lib/mothership/agent-cli/resource-owner.test.ts": 1,
     "apps/sim/lib/mothership/agent-cli/run-cli-files.test.ts": 1,
     "apps/sim/lib/mothership/agent-cli/saved-run-read.live.test.ts": 18,
+    "apps/sim/lib/mothership/agent-cli/workbench-file-provenance.integration.ts": 4,
     "apps/sim/lib/mothership/agent-cli/workbench-file-provenance.ts": 2,
     "apps/sim/lib/mothership/assistant/tool-policy.test.ts": 2,
     "apps/sim/lib/mothership/async-runs/orphaned-runs.integration.ts": 11,
@@ -1737,10 +1731,11 @@
     "apps/sim/lib/webhooks/providers/twilio-voice.test.ts": 11,
     "apps/sim/lib/webhooks/providers/twilio.test.ts": 9,
     "apps/sim/lib/webhooks/providers/vercel.test.ts": 4,
-    "apps/sim/lib/webhooks/providers/whatsapp.test.ts": 7,
+    "apps/sim/lib/webhooks/providers/whatsapp.test.ts": 6,
     "apps/sim/lib/webhooks/providers/zendesk.test.ts": 7,
     "apps/sim/lib/webhooks/providers/zoom.test.ts": 1,
     "apps/sim/lib/webhooks/slack-execution-stream.test.ts": 14,
+    "apps/sim/lib/workflows/application/compare-workflow-versions.integration.ts": 3,
     "apps/sim/lib/workflows/application/inspect-workflow-tools.ts": 1,
     "apps/sim/lib/workflows/application/mapped-import.ts": 1,
     "apps/sim/lib/workflows/application/read-workflow-graph.test.ts": 1,
@@ -1750,6 +1745,7 @@
     "apps/sim/lib/workflows/autolayout/utils.ts": 1,
     "apps/sim/lib/workflows/blocks/block-path-calculator.ts": 1,
     "apps/sim/lib/workflows/blocks/flatten-outputs.ts": 2,
+    "apps/sim/lib/workflows/comparison/redact.test.ts": 2,
     "apps/sim/lib/workflows/credentials/credential-extractor.ts": 3,
     "apps/sim/lib/workflows/diff/diff-engine.ts": 1,
     "apps/sim/lib/workflows/editing/block-enablement.ts": 1,
@@ -1969,6 +1965,7 @@
     "packages/emcn/src/components/toast/toast.tsx": 1,
     "packages/sim-cli/src/contract/reference.ts": 6,
     "packages/sim-cli/src/runtime/execute.test.ts": 3,
+    "packages/sim-cli/src/runtime/result.test.ts": 1,
     "packages/sim-cli/src/transfer/embedded-files.test.ts": 1,
     "packages/sim-setup/src/lifecycle.test.ts": 3,
     "packages/ts-sdk/examples/basic-usage.ts": 4,

scripts/check-explicit-any.ts

@@ -79,7 +79,8 @@ function collect(): Baseline {
 
 /** `biome-ignore` comments for either rule, which would hide a hit from Biome's count. */
 function suppressions(): string[] {
-  const pattern = `biome-ignore(-all|-start)?[[:space:]]+(${Object.values(METRICS).join('|')})`
+  // Anchored to a comment opener so the phrase inside a string literal (a test fixture) is not a hit.
+  const pattern = `^[[:space:]]*(//|/\\*|\\{/\\*)[[:space:]]*biome-ignore(-all|-start)?[[:space:]]+(${Object.values(METRICS).join('|')})`
   const result = Bun.spawnSync(
     ['git', 'grep', '-nE', '--untracked', pattern, '--', 'apps', 'packages', 'scripts'],
     { cwd: ROOT, stdout: 'pipe', stderr: 'pipe' }