Skip to content

Commit ad947f8

Browse files
committed
chore(tests): remove quarantined integration suites
The seven suites excluded from the integration run since 2026-09-25 failed against a freshly provisioned database (fixtures predate connector and credential changes) and never ran in CI. Delete them, the quarantine list in vitest.config.ts, their explicit-any baseline entries, and getCredentialGroupOAuthContext (plus its @sim/testing mock), whose only caller was the GitHub member suite. The testing rule now says to fix or delete a failing suite rather than exclude it.
1 parent 2008383 commit ad947f8

13 files changed

Lines changed: 5 additions & 4316 deletions

‎.claude/rules/sim-testing.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ contracts, and demonstrated regressions.
4848
those checks. Isolate with a unique schema or generated IDs, and clean up in `afterAll`.
4949
- Integration files run one at a time against one shared database. A new `*.integration.ts` is
5050
picked up by CI with no workflow change, and the run writes the JSON report configured in
51-
`vitest.shared.ts`, which CI uploads. Never add a passing suite to the quarantine list in
52-
`apps/sim/vitest.config.ts`.
51+
`vitest.shared.ts`, which CI uploads. Never exclude a failing suite from the run in
52+
`apps/sim/vitest.config.ts`: fix it or delete it.
5353
- `bun run test:integration` starts disposable Postgres and Redis containers, provisions the schema,
5454
and runs both workspaces; pass filenames to narrow the `apps/sim` run.
5555

‎.cursor/rules/sim-testing.mdc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ contracts, and demonstrated regressions.
4646
those checks. Isolate with a unique schema or generated IDs, and clean up in `afterAll`.
4747
- Integration files run one at a time against one shared database. A new `*.integration.ts` is
4848
picked up by CI with no workflow change, and the run writes the JSON report configured in
49-
`vitest.shared.ts`, which CI uploads. Never add a passing suite to the quarantine list in
50-
`apps/sim/vitest.config.ts`.
49+
`vitest.shared.ts`, which CI uploads. Never exclude a failing suite from the run in
50+
`apps/sim/vitest.config.ts`: fix it or delete it.
5151
- `bun run test:integration` starts disposable Postgres and Redis containers, provisions the schema,
5252
and runs both workspaces; pass filenames to narrow the `apps/sim` run.
5353

‎apps/sim/lib/credential-groups/enrollments.ts‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,20 +1348,6 @@ async function completeResolvedCredentialGroupEnrollment(
13481348
})
13491349
}
13501350

1351-
/** Resolves the private, server-only context bound to a public enrollment link and option. */
1352-
export async function getCredentialGroupOAuthContext(
1353-
token: string,
1354-
optionId: string
1355-
): Promise<CredentialGroupOAuthContext | null> {
1356-
const row = await resolvePublicEnrollmentRowByIdentity({
1357-
invitationTokenHash: hashInvitationToken(token),
1358-
})
1359-
if (!row) return null
1360-
const option = row.options.find((candidate) => candidate.id === optionId)
1361-
if (!option || option.status !== 'active') return null
1362-
return credentialGroupOAuthContextFromRow(row, option)
1363-
}
1364-
13651351
export async function getAuthorizedCredentialGroupOAuthContext(
13661352
identity: PublicCredentialGroupEnrollmentIdentity,
13671353
optionId: string

0 commit comments

Comments
 (0)