Skip to content

Commit b96b7e7

Browse files
committed
fix(resource): self-remove keydown listener on Escape and include session loading in isLoading guard
1 parent f5d22b9 commit b96b7e7

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

apps/sim/app/workspace/[workspaceId]/components/resource/resource.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,10 @@ export const ResourceTable = memo(function ResourceTable({
233233
if (!contextMenuRowId) return
234234
const clear = () => setContextMenuRowId(null)
235235
const handleKeyDown = (e: KeyboardEvent) => {
236-
if (e.key === 'Escape') clear()
236+
if (e.key === 'Escape') {
237+
document.removeEventListener('keydown', handleKeyDown)
238+
clear()
239+
}
237240
}
238241
const timeoutId = setTimeout(() => {
239242
document.addEventListener('pointerdown', clear, { once: true })

apps/sim/hooks/use-user-permissions.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,17 @@ export function useUserPermissions(
3333
permissionsLoading = false,
3434
permissionsError: string | null = null
3535
): WorkspaceUserPermissions {
36-
const { data: session } = useSession()
36+
const { data: session, isPending: sessionLoading } = useSession()
3737

3838
const userPermissions = useMemo((): WorkspaceUserPermissions => {
3939
const sessionEmail = session?.user?.email
40-
if (permissionsLoading || !sessionEmail) {
40+
if (permissionsLoading || sessionLoading || !sessionEmail) {
4141
return {
4242
canRead: false,
4343
canEdit: false,
4444
canAdmin: false,
4545
userPermissions: 'read',
46-
isLoading: permissionsLoading,
46+
isLoading: permissionsLoading || sessionLoading,
4747
error: permissionsError,
4848
}
4949
}
@@ -99,7 +99,7 @@ export function useUserPermissions(
9999
isLoading: false,
100100
error: permissionsError,
101101
}
102-
}, [session, workspacePermissions, permissionsLoading, permissionsError])
102+
}, [session, sessionLoading, workspacePermissions, permissionsLoading, permissionsError])
103103

104104
return userPermissions
105105
}

0 commit comments

Comments
 (0)