fix optional hosted key

Author: icecrasher321

apps/sim/tools/params.test.ts

@@ -209,6 +209,45 @@ describe('Tool Parameters Utils', () => {
       expect(selfHostedSchema.properties.apiKey.description).not.toContain('hosted key')
     })
 
+    it.concurrent('keeps the key required for conditionally hosted tools', () => {
+      const enabled = Object.assign(
+        (params: Record<string, unknown>) => params.provider === 'falai',
+        {
+          condition: { field: 'provider', operator: 'equals' as const, value: 'falai' },
+        }
+      )
+      const conditionalTool = {
+        ...mockToolConfig,
+        id: 'conditional_hosted_tool',
+        params: {
+          apiKey: {
+            type: 'string',
+            required: true,
+            visibility: 'user-only' as ParameterVisibility,
+            description: 'Provider API Key',
+          },
+        },
+        hosting: {
+          enabled,
+          envKeyPrefix: 'FALAI_API_KEY',
+          apiKeyParam: 'apiKey',
+          byokProviderId: 'falai',
+          pricing: { type: 'per_request' as const, cost: 0.01 },
+          rateLimit: { mode: 'per_request' as const, requestsPerMinute: 100 },
+        },
+      }
+
+      const schema = createUserToolSchema(conditionalTool, {
+        surface: 'copilot',
+        hostedKeySupport: true,
+      })
+
+      // Injection only happens when the predicate passes at runtime, so the
+      // schema must not promise a hosted key for every configuration.
+      expect(schema.required).toContain('apiKey')
+      expect(schema.properties.apiKey.description).not.toContain('hosted key')
+    })
+
     it.concurrent('does not relax required keys on tools without hosting', () => {
       const plainTool = {
         ...mockToolConfig,

apps/sim/tools/params.ts

@@ -131,10 +131,14 @@ export interface UserToolSchemaOptions {
   surface?: 'default' | 'copilot'
   /**
    * Set when the deployment provides hosted API keys for tools with a
-   * `hosting` config. The hosted key param then stays in the schema only as an
-   * optional bring-your-own-key override instead of a required argument — the
-   * executor injects the hosted key server-side after validation, and the key
-   * value itself is never exposed to the model or the mothership.
+   * `hosting` config. For unconditionally hosted tools the key param then
+   * stays in the schema only as an optional bring-your-own-key override
+   * instead of a required argument — the executor injects the hosted key
+   * server-side after validation, and the key value itself is never exposed
+   * to the model or the mothership. Tools with a conditional
+   * `hosting.enabled` predicate keep the key required, since injection only
+   * happens for configurations that satisfy the predicate (mirrors the VFS
+   * `conditional_hosted_or_byok` auth mode).
    */
   hostedKeySupport?: boolean
 }
@@ -514,7 +518,9 @@ export function createUserToolSchema(
 ): ToolSchema {
   const surface = options.surface ?? 'default'
   const hostedApiKeyParam =
-    options.hostedKeySupport && toolConfig.hosting ? toolConfig.hosting.apiKeyParam : undefined
+    options.hostedKeySupport && toolConfig.hosting && !toolConfig.hosting.enabled
+      ? toolConfig.hosting.apiKeyParam
+      : undefined
   const schema: ToolSchema = {
     type: 'object',
     properties: {},