refactor(connectors): decouple rehydrate from fullSync deletion semantics

The transclusion refresh only needs re-hydration, but reusing the fullSync flag
also activated its deletion-cleanup semantics — which bypass three previously
unreachable safety guards (empty-listing wipe, listingCapped, and the >50%
mass-deletion threshold). Since fullSync had no caller before this PR, the new
'Full resync' button would have exposed all three to any KB editor.

Introduce a dedicated 'rehydrate' request that ONLY forces re-hydration + re-index
of already-synced docs. Listing and deletion reconciliation are identical to a
normal sync (all safety guards stay armed). fullSync's cleanup semantics remain
dormant and untouched.

Author: waleedlatif1

apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/sync/route.test.ts

@@ -138,11 +138,11 @@ describe('Connector Manual Sync API Route', () => {
     expect(mockDispatchSync).toHaveBeenCalledWith('conn-456', {
       billingAttribution,
       requestId: 'test-req-id',
-      fullSync: false,
+      rehydrate: false,
     })
   })
 
-  it('dispatches a full resync when fullSync=true is set', async () => {
+  it('dispatches a full resync when rehydrate=true is set', async () => {
     const billingAttribution = {
       actorUserId: 'external-admin',
       workspaceId: 'ws-1',
@@ -173,15 +173,15 @@ describe('Connector Manual Sync API Route', () => {
       'POST',
       undefined,
       {},
-      'http://localhost:3000/api/knowledge/kb-123/connectors/conn-456/sync?fullSync=true'
+      'http://localhost:3000/api/knowledge/kb-123/connectors/conn-456/sync?rehydrate=true'
     )
     const response = await POST(req as never, { params: mockParams })
 
     expect(response.status).toBe(200)
     expect(mockDispatchSync).toHaveBeenCalledWith('conn-456', {
       billingAttribution,
       requestId: 'test-req-id',
-      fullSync: true,
+      rehydrate: true,
     })
   })
 })

apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/sync/route.ts

@@ -29,7 +29,7 @@ export const POST = withRouteHandler(async (request: NextRequest, context: Route
   const parsed = await parseRequest(triggerKnowledgeConnectorSyncContract, request, context)
   if (!parsed.success) return parsed.response
   const { id: knowledgeBaseId, connectorId } = parsed.data.params
-  const fullSync = parsed.data.query?.fullSync === 'true'
+  const rehydrate = parsed.data.query?.rehydrate === 'true'
 
   try {
     const auth = await checkSessionOrInternalAuth(request, { requireWorkflowId: false })
@@ -83,7 +83,7 @@ export const POST = withRouteHandler(async (request: NextRequest, context: Route
           })
 
     logger.info(
-      `[${requestId}] Manual ${fullSync ? 'full ' : ''}sync triggered for connector ${connectorId}`
+      `[${requestId}] Manual sync${rehydrate ? ' (full rehydrate)' : ''} triggered for connector ${connectorId}`
     )
 
     captureServerEvent(
@@ -112,12 +112,12 @@ export const POST = withRouteHandler(async (request: NextRequest, context: Route
         knowledgeBaseName: writeCheck.knowledgeBase.name,
         connectorType: connectorRows[0].connectorType,
         connectorStatus: connectorRows[0].status,
-        syncType: fullSync ? 'manual-full' : 'manual',
+        syncType: rehydrate ? 'manual-rehydrate' : 'manual',
       },
       request,
     })
 
-    dispatchSync(connectorId, { billingAttribution, requestId, fullSync }).catch((error) => {
+    dispatchSync(connectorId, { billingAttribution, requestId, rehydrate }).catch((error) => {
       logger.error(
         `[${requestId}] Failed to dispatch manual sync for connector ${connectorId}`,
         error

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.tsx

@@ -127,14 +127,14 @@ export function ConnectorsSection({
   }, [])
 
   const handleSync = useCallback(
-    (connectorId: string, fullSync = false) => {
+    (connectorId: string, rehydrate = false) => {
       if (isSyncOnCooldown(connectorId)) return
 
       syncTriggeredAt.current[connectorId] = Date.now()
       addToSet(setSyncingIds, connectorId)
 
       triggerSync(
-        { knowledgeBaseId, connectorId, fullSync },
+        { knowledgeBaseId, connectorId, rehydrate },
         {
           onSuccess: () => {
             setError(null)
@@ -226,7 +226,7 @@ export function ConnectorsSection({
               isSyncPending={syncingIds.has(connector.id)}
               isUpdating={updatingIds.has(connector.id)}
               syncCooldown={isSyncOnCooldown(connector.id)}
-              onSync={(fullSync) => handleSync(connector.id, fullSync)}
+              onSync={(rehydrate) => handleSync(connector.id, rehydrate)}
               onTogglePause={() => handleTogglePause(connector)}
               onEdit={() => setEditingConnector(connector)}
               onDelete={() => setDeleteTarget(connector.id)}
@@ -285,7 +285,7 @@ interface ConnectorCardProps {
   isSyncPending: boolean
   isUpdating: boolean
   syncCooldown: boolean
-  onSync: (fullSync?: boolean) => void
+  onSync: (rehydrate?: boolean) => void
   onEdit: () => void
   onTogglePause: () => void
   onDelete: () => void

apps/sim/hooks/queries/kb/connectors.ts

@@ -204,18 +204,18 @@ export function useDeleteConnector() {
 interface TriggerSyncParams {
   knowledgeBaseId: string
   connectorId: string
-  /** Force a full resync (re-hydrate + re-index rendered content). Defaults to incremental. */
-  fullSync?: boolean
+  /** Force re-hydration + re-index of rendered content (the "Full resync" action). */
+  rehydrate?: boolean
 }
 
 async function triggerSync({
   knowledgeBaseId,
   connectorId,
-  fullSync,
+  rehydrate,
 }: TriggerSyncParams): Promise<void> {
   await requestJson(triggerKnowledgeConnectorSyncContract, {
     params: { id: knowledgeBaseId, connectorId },
-    query: fullSync ? { fullSync: 'true' } : {},
+    query: rehydrate ? { rehydrate: 'true' } : {},
   })
 }
 

apps/sim/lib/api/contracts/knowledge/connectors.ts

@@ -152,13 +152,14 @@ export const deleteKnowledgeConnectorContract = defineRouteContract({
 
 export const triggerKnowledgeConnectorSyncQuerySchema = z.object({
   /**
-   * Force a full resync: re-list everything and, for connectors whose rendered
-   * content can drift without a hash change (e.g. Confluence transclusions),
-   * re-hydrate and re-index every document rather than only hash-changed ones.
-   * Omitted performs the normal incremental, hash-gated sync. Modeled as a string
-   * literal (not a boolean) so it round-trips cleanly through the query string.
+   * Force re-hydration: for connectors whose rendered content can drift without a
+   * hash change (e.g. Confluence transclusions), re-fetch and re-index every
+   * already-synced document rather than only hash-changed ones. Listing and
+   * deletion reconciliation are unchanged from a normal sync. Omitted performs the
+   * normal hash-gated sync. Modeled as a string literal (not a boolean) so it
+   * round-trips cleanly through the query string.
    */
-  fullSync: z.enum(['true', 'false']).optional(),
+  rehydrate: z.enum(['true', 'false']).optional(),
 })
 
 export const triggerKnowledgeConnectorSyncContract = defineRouteContract({

apps/sim/lib/knowledge/connectors/queue.ts

@@ -19,13 +19,21 @@ const logger = createLogger('ConnectorSyncQueue')
 export interface ConnectorSyncPayload {
   connectorId: string
   fullSync?: boolean
+  /**
+   * Force re-hydration + re-indexing of already-synced documents for connectors
+   * whose rendered content can drift without a hash change (see
+   * `ConnectorMeta.rehydrateOnFullSync`). Unlike `fullSync`, this does NOT alter
+   * listing or bypass any deletion-reconciliation safety guard.
+   */
+  rehydrate?: boolean
   requestId: string
   billingAttribution: BillingAttributionSnapshot
 }
 
 export interface DispatchSyncOptions {
   billingAttribution: BillingAttributionSnapshot
   fullSync?: boolean
+  rehydrate?: boolean
   requestId?: string
 }
 
@@ -46,13 +54,17 @@ export function assertConnectorSyncPayload(value: unknown): ConnectorSyncPayload
   if (value.fullSync !== undefined && typeof value.fullSync !== 'boolean') {
     throw new Error('Connector sync payload fullSync must be a boolean when provided')
   }
+  if (value.rehydrate !== undefined && typeof value.rehydrate !== 'boolean') {
+    throw new Error('Connector sync payload rehydrate must be a boolean when provided')
+  }
   if (value.billingAttribution === undefined) {
     throw new Error('Connector sync payload requires billing attribution')
   }
 
   return {
     connectorId: value.connectorId,
     fullSync: value.fullSync as boolean | undefined,
+    rehydrate: value.rehydrate as boolean | undefined,
     requestId: value.requestId,
     billingAttribution: assertBillingAttributionSnapshot(value.billingAttribution),
   }
@@ -74,6 +86,7 @@ export async function dispatchSync(
   const payload = assertConnectorSyncPayload({
     connectorId,
     fullSync: options?.fullSync,
+    rehydrate: options?.rehydrate,
     requestId,
     billingAttribution: options?.billingAttribution,
   })
@@ -147,6 +160,7 @@ export async function dispatchSync(
 
   executeSync(connectorId, {
     fullSync: payload.fullSync,
+    rehydrate: payload.rehydrate,
     billingAttribution: payload.billingAttribution,
   }).catch((error) => {
     logger.error(`Sync failed for connector ${connectorId}`, {

apps/sim/lib/knowledge/connectors/sync-engine.ts

@@ -318,7 +318,11 @@ async function resolveAccessToken(
  */
 export async function executeSync(
   connectorId: string,
-  options: { billingAttribution: BillingAttributionSnapshot; fullSync?: boolean }
+  options: {
+    billingAttribution: BillingAttributionSnapshot
+    fullSync?: boolean
+    rehydrate?: boolean
+  }
 ): Promise<SyncResult> {
   const billingAttribution = assertBillingAttributionSnapshot(options?.billingAttribution)
   const result: SyncResult = {
@@ -438,11 +442,16 @@ export async function executeSync(
       isIncremental && connector.lastSyncAt ? new Date(connector.lastSyncAt) : undefined
 
     /**
-     * On an explicit full resync, re-hydrate and re-index connectors whose rendered
-     * content can drift without a hash change (transclusions) — see
-     * `ConnectorMeta.rehydrateOnFullSync`. Incremental syncs stay hash-gated.
+     * Re-hydrate and re-index connectors whose rendered content can drift without a
+     * hash change (transclusions) — see `ConnectorMeta.rehydrateOnFullSync`. Driven
+     * by the dedicated `rehydrate` request (the "Full resync" action) or implied by a
+     * true `fullSync`. This ONLY affects hydration/indexing — it does not change
+     * listing or bypass any deletion-reconciliation guard. Incremental syncs of other
+     * connectors stay hash-gated.
      */
-    const forceRehydrate = Boolean(options?.fullSync && connectorConfig.rehydrateOnFullSync)
+    const forceRehydrate = Boolean(
+      (options?.rehydrate || options?.fullSync) && connectorConfig.rehydrateOnFullSync
+    )
 
     for (let pageNum = 0; hasMore && pageNum < MAX_PAGES; pageNum++) {
       if (pageNum > 0 && connectorConfig.auth.mode === 'oauth') {