Fix linting bugs

Author: kzscisoft

simvue/api/objects/events.py

@@ -204,7 +204,15 @@ def histogram(
             start point for event time range
         timestamp_end : datetime.datetime
             end point for event time range
+        window : int
+            the interval for metric aggregation
+        filters : list[str] | None
+            filters to apply to select on runs
 
+        Returns
+        -------
+        list[dict[str, str | int]]
+            histogram response from server
         """
         if timestamp_end - timestamp_begin <= datetime.timedelta(seconds=window):
             raise ValueError(

simvue/api/request.py

@@ -87,6 +87,9 @@ def post(
         timeout for the request
     files : dict[str, Any] | None = None
         file data for this request
+    verify : str | bool, optional
+        whether to verify the request, if a string, the certificate
+        to use for verification
 
     Returns
     -------
@@ -163,6 +166,9 @@ def put(
         send as JSON string, by default True
     timeout : int, optional
         timeout of request, by default DEFAULT_API_TIMEOUT
+    verify : str | bool, optional
+        whether to verify the request, if a string, the certificate
+        to use for verification
 
     Returns
     -------
@@ -209,11 +215,12 @@ def put(
 )
 def get(
     url: str,
+    *,
     headers: dict[str, str] | None = None,
     params: dict[str, str | int | float | None] | None = None,
     timeout: int = DEFAULT_API_TIMEOUT,
-    verify: str | bool = True,
     json: dict[str, typing.Any] | None = None,
+    verify: str | bool = True,
 ) -> requests.Response:
     """HTTP GET.
 
@@ -229,6 +236,9 @@ def get(
         timeout of request, by default DEFAULT_API_TIMEOUT
     json : dict[str, Any] | None, optional
         any json to send in request
+    verify : str | bool, optional
+        whether to verify the request, if a string, the certificate
+        to use for verification
 
     Returns
     -------
@@ -238,12 +248,7 @@ def get(
     """
     logger.debug("GET: %s\n\tparams=%s", url, params)
     response = requests.get(
-        url,
-        headers=headers,
-        timeout=timeout,
-        params=params,
-        json=json,
-        verify=verify
+        url, headers=headers, timeout=timeout, params=params, json=json, verify=verify
     )
 
     if response.status_code in RETRY_STATUSES:
@@ -268,10 +273,11 @@ def get(
 )
 def delete(
     url: str,
+    *,
     headers: dict[str, str],
     timeout: int = DEFAULT_API_TIMEOUT,
-    verify: str | bool = True,
     params: dict[str, typing.Any] | None = None,
+    verify: str | bool = True,
 ) -> requests.Response:
     """HTTP DELETE.
 
@@ -285,6 +291,9 @@ def delete(
         timeout of request, by default DEFAULT_API_TIMEOUT
     params : dict, optional
         parameters for deletion
+    verify : str | bool, optional
+        whether to verify the request, if a string, the certificate
+        to use for verification
 
     Returns
     -------
@@ -293,7 +302,9 @@ def delete(
 
     """
     logger.debug("DELETE: %s\n\tparams=%s", url, params)
-    response = requests.delete(url, headers=headers, timeout=timeout, params=params, verify=verify)
+    response = requests.delete(
+        url, headers=headers, timeout=timeout, params=params, verify=verify
+    )
 
     if response.status_code in RETRY_STATUSES:
         raise RetryableHTTPError(

simvue/config/parameters.py

@@ -28,8 +28,8 @@ class CertificateSpecifications(pydantic.BaseModel):
     @pydantic.model_validator(mode="before")
     @classmethod
     def check_for_cert_env(
-        cls, values: dict[str, pathlib.Path | None | str]
-    ) -> dict[str, pathlib.Path | None | str]:
+        cls, values: dict[str, pathlib.Path | str | None]
+    ) -> dict[str, pathlib.Path | str | None]:
         """Check for CA certificate for storage specification in environment."""
         if (
             _env_ca_cert := os.environ.get("SIMVUE_STORAGE_CA_CERTIFICATE")
@@ -38,7 +38,7 @@ def check_for_cert_env(
         if (_env_ca_cert := os.environ.get("SIMVUE_SERVER_CA_CERTIFICATE")) is not None:
             values["server_ca_cert"] = _env_ca_cert
         if _env_client_cert := os.environ.get("SIMVUE_SERVER_CLIENT_CERTIFICATE"):
-            values["client_cert"] = _env_ca_cert
+            values["client_cert"] = _env_client_cert
         return values
 
 

simvue/config/user.py

@@ -122,10 +122,11 @@ def _load_pyproject_configs(cls) -> dict | None:
     @functools.lru_cache
     def _check_server(
         cls,
+        *,
         token: str,
         url: str,
-        verify: str | bool,
         mode: typing.Literal["offline", "online", "disabled"],
+        verify: str | bool,
     ) -> semver.Version | None:
         if mode in {"offline", "disabled"}:
             return None