Skip to content

Split replace/delete original from response type#9

Closed
SiebeVE wants to merge 1 commit into
slack-php:mainfrom
SiebeVE:main
Closed

Split replace/delete original from response type#9
SiebeVE wants to merge 1 commit into
slack-php:mainfrom
SiebeVE:main

Conversation

@SiebeVE

@SiebeVE SiebeVE commented Mar 28, 2022

Copy link
Copy Markdown

Add ability to delete/replace original and change the response type.

This change isn't backwards compatible and should be considered a major change.

@jlindblom-godaddy

Copy link
Copy Markdown

The code looks good, but I don't understand the reason for it. Can you explain why it's necessary to split them? What have I overlooked?

@SiebeVE

SiebeVE commented Jun 1, 2022

Copy link
Copy Markdown
Author

It isn't possible if you want to add the directive replace_original and delete_original, you can only add one because it is stored in the same directive variable.

#[FauxProperty('response_type', 'replace_original', 'delete_original')]
public ?MessageDirective $directive;

This PR changes the behaviour and allows you to send replace_original and delete_original.
(Required if you want to change an ephemeral message with an in channel message)

@SiebeVE

SiebeVE commented Aug 8, 2022

Copy link
Copy Markdown
Author

See #19

@SiebeVE SiebeVE closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants